Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix and improve debug-break-on-uncaught #10370

Closed
wants to merge 1 commit into from
Closed

test: fix and improve debug-break-on-uncaught #10370

wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test debugger

Description of change

This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed vars to lets or consts.

Refer: #10361

@thefourtheye thefourtheye added debugger test Issues and PRs related to the tests. labels Dec 21, 2016
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 21, 2016
@thefourtheye thefourtheye mentioned this pull request Dec 21, 2016
Closed
Trott
Trott approved these changes Dec 21, 2016
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If you want, I think you can remove the result argument that appears in two callbacks. It is unused.

@thefourtheye
test: fix and improve debug-break-on-uncaught
0010e62 
This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed `var`s to `let`s or `const`s.

Refer: nodejs#10361
@thefourtheye thefourtheye force-pushed the fix-test-debug-break-on-uncaught branch from dafb597 to 0010e62 Compare December 21, 2016 06:15
@thefourtheye
Copy link
Contributor Author

@Trott Good catch. Removed them :-)

@jasnell
Copy link
Member

jasnell commented Dec 23, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5558/

jasnell pushed a commit that referenced this pull request Dec 24, 2016
@thefourtheye @jasnell
test: fix and improve debug-break-on-uncaught
c74d9d6 
This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed `var`s to `let`s or `const`s.

Refs: #10361
PR-URL: #10370
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
@jasnell
Copy link
Member

jasnell commented Dec 24, 2016

Landed in c74d9d6

@jasnell jasnell closed this Dec 24, 2016
@thefourtheye thefourtheye deleted the fix-test-debug-break-on-uncaught branch December 26, 2016 06:40
@evanlucas evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@thefourtheye @evanlucas
test: fix and improve debug-break-on-uncaught
44c340c 
This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed `var`s to `let`s or `const`s.

Refs: #10361
PR-URL: #10370
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@thefourtheye @evanlucas
test: fix and improve debug-break-on-uncaught
d33e560 
This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed `var`s to `let`s or `const`s.

Refs: #10361
PR-URL: #10370
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@thefourtheye @MylesBorins
test: fix and improve debug-break-on-uncaught
4743066 
This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed `var`s to `let`s or `const`s.

Refs: #10361
PR-URL: #10370
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@thefourtheye @MylesBorins
test: fix and improve debug-break-on-uncaught
f80084c 
This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed `var`s to `let`s or `const`s.

Refs: #10361
PR-URL: #10370
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@thefourtheye @MylesBorins
test: fix and improve debug-break-on-uncaught
3210653 
This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed `var`s to `let`s or `const`s.

Refs: #10361
PR-URL: #10370
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@thefourtheye @MylesBorins
test: fix and improve debug-break-on-uncaught
6bb735a 
This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed `var`s to `let`s or `const`s.

Refs: #10361
PR-URL: #10370
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@thefourtheye @MylesBorins
test: fix and improve debug-break-on-uncaught
5f18f0c 
This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed `var`s to `let`s or `const`s.

Refs: #10361
PR-URL: #10370
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@thefourtheye @MylesBorins
test: fix and improve debug-break-on-uncaught
dbfec29 
This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed `var`s to `let`s or `const`s.

Refs: #10361
PR-URL: #10370
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thefourtheye @jasnell @Trott @cjihrig @MylesBorins @nodejs-github-bot