test: improve the code in test-pipe.js #10452

edsadr · 2016-12-25T19:01:44Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

Description of change

use const and let instead of var
use common.mustCall to control functions executions
use assert.strictEqual instead of assert.equal
use assert.ifError to handle errors
use arrow functions

mscdex · 2016-12-25T19:09:12Z

test/sequential/test-pipe.js


  req.pipe(socket);

-  req.on('end', function() {
+  req.on('end', common.mustCall(() => {
    res.writeHead(200);
    res.write('thanks');
    res.end();
    console.log('response with \'thanks\'');


Can we remove these log statements too? Also the process.stdout.write() statements.

mscdex · 2016-12-25T19:09:52Z

test/sequential/test-pipe.js


-  req.connection.on('error', function(e) {
+  req.connection.on('error', (e) => {
+    assert.ifError(e);
    console.log('http server-side error: ' + e.message);
    process.exit(1);


I think this can be removed now that we're asserting.

edsadr · 2016-12-25T19:27:35Z

@mscdex, changed as suggested

mscdex · 2016-12-25T20:33:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/5582/

mscdex · 2016-12-26T18:52:33Z

LGTM

lpinca · 2016-12-26T20:02:44Z

test/sequential/test-pipe.js

    res.setEncoding('utf8');
-    res.on('data', function(string) {
-      assert.equal('thanks', string);
+    res.on('data', (string) => {


Nit: how about wrapping this listener with common.mustCall and remove the gotThanks flag?

@lpinca the problem adding the common.mustCall for this event, is that we are not sure about the exact number of times this function will be called, every time the test run the number could be different, so adding it will make the test to fail sporadically

@edsadr there is an assertion which basically check that the listener is called once.

assert.strictEqual('thanks', string);

If the are multiple chunks then the assertion fails anyway.

* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write

edsadr · 2016-12-27T17:16:38Z

@lpinca , I stand corrected I was checking the other event:

s.on('data', (d) => {
    tcpLengthSeen += d.length;
    for (let j = 0; j < d.length; j++) {
      assert.strictEqual(buffer[i], d[j]);
      i++;
    }
  });

That one is the one being called multiple times, just fixed the one you suggested and I guess just left to set the CI

lpinca · 2016-12-27T17:23:24Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/5597/

italoacasas · 2016-12-27T18:28:30Z

Landed fc103bb

* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write PR-URL: #10452 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>

nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 25, 2016

mscdex reviewed Dec 25, 2016

View reviewed changes

mscdex added http Issues or PRs related to the http subsystem. net Issues and PRs related to the net subsystem. labels Dec 25, 2016

edsadr force-pushed the test-pipe branch from 1d7fafb to 466fd9a Compare December 25, 2016 19:25

nodejs-github-bot added the lts-watch-v6.x label Dec 25, 2016

jasnell approved these changes Dec 26, 2016

View reviewed changes

lpinca reviewed Dec 26, 2016

View reviewed changes

lpinca approved these changes Dec 26, 2016

View reviewed changes

test: improve the code in test-pipe.js

448d193

* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write

edsadr force-pushed the test-pipe branch from 466fd9a to 448d193 Compare December 27, 2016 17:12

nodejs-github-bot added the lts-watch-v6.x label Dec 27, 2016

italoacasas closed this Dec 27, 2016

evanlucas mentioned this pull request Jan 3, 2017

v7.4.0 release proposal #10589

Merged

MylesBorins added land-on-v4.x and removed lts-watch-v6.x labels Jan 23, 2017

This was referenced Jan 24, 2017

v4.8.0 proposal #10973

Merged

v6.10.0 proposal #10974

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: improve the code in test-pipe.js #10452

test: improve the code in test-pipe.js #10452

edsadr commented Dec 25, 2016

mscdex Dec 25, 2016 •

edited

Loading

mscdex Dec 25, 2016

edsadr commented Dec 25, 2016

mscdex commented Dec 25, 2016

mscdex commented Dec 26, 2016

lpinca Dec 26, 2016

edsadr Dec 27, 2016 •

edited

Loading

lpinca Dec 27, 2016

edsadr commented Dec 27, 2016

lpinca commented Dec 27, 2016

italoacasas commented Dec 27, 2016

test: improve the code in test-pipe.js #10452

test: improve the code in test-pipe.js #10452

Conversation

edsadr commented Dec 25, 2016

Checklist

Affected core subsystem(s)

Description of change

mscdex Dec 25, 2016 • edited Loading

Choose a reason for hiding this comment

mscdex Dec 25, 2016

Choose a reason for hiding this comment

edsadr commented Dec 25, 2016

mscdex commented Dec 25, 2016

mscdex commented Dec 26, 2016

lpinca Dec 26, 2016

Choose a reason for hiding this comment

edsadr Dec 27, 2016 • edited Loading

Choose a reason for hiding this comment

lpinca Dec 27, 2016

Choose a reason for hiding this comment

edsadr commented Dec 27, 2016

lpinca commented Dec 27, 2016

italoacasas commented Dec 27, 2016

mscdex Dec 25, 2016 •

edited

Loading

edsadr Dec 27, 2016 •

edited

Loading