Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: v7.x: #10654 #10889

Merged
merged 6 commits into from
Jan 25, 2017
Merged

backport: v7.x: #10654 #10889

merged 6 commits into from
Jan 25, 2017

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jan 19, 2017 •
edited
Loading

Backport of #10654 to v7.x.

CI: https://ci.nodejs.org/job/node-test-pull-request/6039/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
  • http

mscdex added 6 commits January 18, 2017 21:56
@mscdex
http: optimize short path validation
c9bff04 
PR-URL: nodejs#10654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@mscdex
http: optimize default method case
e7859c2 
PR-URL: nodejs#10654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@mscdex
http: avoid duplicate isArray()
44c0e4f 
PR-URL: nodejs#10654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@mscdex
http: misc ClientRequest cleanup
5059b76 
PR-URL: nodejs#10654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@mscdex
benchmark: add ClientRequest creation benchmark
be24cc0 
PR-URL: nodejs#10654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@mscdex
test: add http.ClientRequest defaults test
4ff1d31 
PR-URL: nodejs#10654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@mscdex mscdex added http Issues or PRs related to the http subsystem. v7.x labels Jan 19, 2017
@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. v7.x labels Jan 19, 2017
@mscdex mscdex mentioned this pull request Jan 19, 2017
Closed
@mscdex mscdex merged commit 4ff1d31 into nodejs:v7.x-staging Jan 25, 2017
@mscdex mscdex deleted the backport-v7.x-10654 branch January 25, 2017 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italoacasas italoacasas italoacasas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mscdex @jasnell @italoacasas @nodejs-github-bot