Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: unlock the assert API #11304

Closed
wants to merge 1 commit into from
Closed

assert: unlock the assert API #11304

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 10, 2017

Change the Stability Index on assert from Locked to Stable.

Refs: #11200

@nodejs/ctc

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

assert

@Trott
assert: unlock the assert API
e5cb1a3 
Change the Stability Index on `assert` from Locked to Stable.

Refs: nodejs#11200
@Trott Trott added assert Issues and PRs related to the assert subsystem. ctc-review labels Feb 10, 2017
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Feb 10, 2017
@Trott Trott mentioned this pull request Feb 10, 2017
Closed
2 tasks
@sam-github
Copy link
Contributor

Note that this is not intended to encourage changes to assert, but to allow it when its useful for node (as has happened recently, in violation of the documented stability level), and possibly to simplify the stability levels by removing Locked altogether.

@gibfahn gibfahn mentioned this pull request Feb 12, 2017
Closed
2 tasks
thefourtheye
thefourtheye approved these changes Feb 12, 2017
View reviewed changes
Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided we will not lock it again.

@ChALkeR
Copy link
Member

ChALkeR commented Feb 12, 2017

+1 to this change and LGTM (reviewed above).

I would prefer this to be mentioned in the next CTC meeting, though (with no specific action required, just that this doesn't get missed and to make sure we collect possible objections, if any).

@ChALkeR
Copy link
Member

ChALkeR commented Feb 12, 2017

Ah, sorry, it looks that I shouldn't do that per the updated Governance rules that tend to be more async =).
Removing the ctc-agenda label.

@ChALkeR ChALkeR mentioned this pull request Feb 12, 2017
Closed
@Trott Trott mentioned this pull request Feb 13, 2017
Closed
@Trott Trott added notable-change PRs with changes that should be highlighted in changelogs. and removed ctc-review labels Feb 15, 2017
Trott added a commit to Trott/io.js that referenced this pull request Feb 15, 2017
@Trott
assert: unlock the assert API
797ec33 
Change the Stability Index on `assert` from Locked to Stable.

PR-URL: nodejs#11304
Ref: nodejs#11200
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Feb 15, 2017

Consensus achieved, it would seem. 7 CTC members (if you include me) approve, none object, open for five days, @nodejs/ctc pinged, was listed for review in this week's CTC meeting agenda issue...

Landed in 797ec33

@Trott Trott closed this Feb 15, 2017
@ChALkeR ChALkeR mentioned this pull request Feb 15, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 16, 2017
@Trott @italoacasas
assert: unlock the assert API
c31d27f 
Change the Stability Index on `assert` from Locked to Stable.

PR-URL: nodejs#11304
Ref: nodejs#11200
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
@Trott @italoacasas
assert: unlock the assert API
0762482 
Change the Stability Index on `assert` from Locked to Stable.

PR-URL: #11304
Ref: #11200
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Merged
@ChALkeR ChALkeR mentioned this pull request Mar 6, 2017
Closed
3 tasks
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@Trott @jasnell
assert: unlock the assert API
e652927 
Change the Stability Index on `assert` from Locked to Stable.

PR-URL: #11304
Ref: #11200
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@Trott @jasnell
assert: unlock the assert API
6a80edc 
Change the Stability Index on `assert` from Locked to Stable.

PR-URL: #11304
Ref: #11200
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott @MylesBorins
assert: unlock the assert API
fb75bed 
Change the Stability Index on `assert` from Locked to Stable.

PR-URL: #11304
Ref: #11200
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott @MylesBorins
assert: unlock the assert API
77f23ec 
Change the Stability Index on `assert` from Locked to Stable.

PR-URL: #11304
Ref: #11200
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@Trott Trott deleted the unlock-assert branch January 13, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.