linkedlist: remove public module

[mscdex]

This removes the public _linklist node core module which has been (runtime) deprecated since v5.0.0.

CI: https://ci.nodejs.org/job/node-test-pull-request/7086/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/677/

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

• linkedlist

[mscdex]

/cc @nodejs/ctc

[Trott]

Since _linklist will not exist anymore with this change, can you remove it from the list of restricted modules in .eslintrc.yaml?

  no-restricted-modules: [2, sys, _linklist]

to:

  no-restricted-modules: [2, sys]

[mscdex]

@Trott Done.

[Trott]

Should we do a check to see how often including _linklist happens in the npm registry?

[jasnell]

Definitely. Tho a quick github search shows only hits for node.js core forks. I'm sure some uses still exist out there. Paging @ChALkeR :-)

[evanlucas]

LGTM provided there are no uses found by @ChALkeR in the ecosystem

[jasnell]

Ping @ChALkeR ...

[jasnell]

A code search on github showed no significant hits (a couple of old projects that haven't been updated in a number of years). I'm going to go ahead and land given the approvals.

[jasnell]

Landed in 84a2339

[ChALkeR]

Yes, sorry for missing this one. The old usage stats from 1½ years ago consisted of 17 modules: #3078 (comment).

More up to date data (2017-02):

2418    babybird-0.0.1.tgz/benchmark/lib/timers-ctx.js:23:var L = require('_linklist');
1929    commonjs-everywhere-0.9.7.tgz/node/lib/timers.js:23:var L = require('_linklist');
165     micropromise-0.4.10.tgz/promise-bench/benchmark/lib/timers-ctx.js:23:var L = require('_linklist');
67      candle-0.4.0.tgz/timers.js:23:var L = require('_linklist');
64      ape-algorithm-0.0.8.tgz/linklist.js:2://var L = require('_linklist');
38      biojs-vis-blast-0.1.5.tgz/node/lib/timers.js:23:var L = require('_linklist');
38      biojs-vis-blast-0.1.5.tgz/node/test/simple/test-timers-linked-list.js:24:var L = require('_linklist');
37      portable-js-0.0.3.tgz/misc/io/timers.js:4:const L = require('_linklist');
37      portable-js-0.0.3.tgz/misc/node/timers.js:25:var L = require('_linklist');
28      jsg-0.0.3.tgz/testdata/node_core_modules/timers.js:23:var L = require('_linklist');
21      chromify-0.0.2.tgz/builtins/timers.js:23:var L = require('_linklist');
19      flush-all-0.1.1.tgz/node-v0.13/lib/timers.js:25:var L = require('_linklist');
19      flush-all-0.1.1.tgz/node-v0.13/test/simple/test-timers-linked-list.js:24:var L = require('_linklist');
19      promise-bench-0.0.2.tgz/benchmark/lib/timers-ctx.js:23:var L = require('_linklist');
18      node-core-lib-0.11.11.tgz/timers.js:23:var L = require('_linklist');
16      node-core-test-simple-0.11.11.tgz/test-timers-linked-list.js:24:var L = require('_linklist');
16      persha-0.2.1.tgz/node-lib/timers.js:23:var L = require('_linklist');
13      pezhu-0.0.0.tgz/Downloads/node-v0.9.11/lib/timers.js:23:var L = require('_linklist');
13      pezhu-0.0.0.tgz/Downloads/node-v0.9.11/test/simple/test-timers-linked-list.js:24:var L = require('_linklist');
9       perf-timers-0.1.0.tgz/bench/settimeout/timers.js:23:var L = require('_linklist');
9       perf-timers-0.1.0.tgz/bench/settimeout/timers2.js:23:var L = require('_linklist');
9       perf-timers-0.1.0.tgz/bench/settimeout/timers3.js:23:var L = require('_linklist');
8       node-natives-0.10.25.tgz/timers.js:23:var L = require('_linklist');
5       perf-time-0.1.0.tgz/bench/settimeout/timers.js:23:var L = require('_linklist');
5       perf-time-0.1.0.tgz/bench/settimeout/timers2.js:23:var L = require('_linklist');
5       perf-time-0.1.0.tgz/bench/settimeout/timers3.js:23:var L = require('_linklist');

There are 18 modules, but those are mostly unused, and they require _linklist from bechmarks and/or copies of Node.js timers.js file.

[ChALkeR]

Late LGTM ;-). Sorry for not responding earlier.