tools: update ESLint to v4.0.0 #13645

Trott · 2017-06-13T03:53:45Z

Update ESLint and configuration to version 4.0.0.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

tools

Trott · 2017-06-13T04:00:05Z

This will give us access to more strict indentation linting as well as several new rules (such as no-buffer-constructor hooray hooray!).

sam-github

please remove the tools/eslint/node_modules/.bin/eslint dangling symlink

Trott · 2017-06-13T05:26:25Z

please remove the tools/eslint/node_modules/.bin/eslint dangling symlink

Every. Single. Time.

not-an-aardvark

Mostly-rubberstamp LGTM

vsemozhetbyt · 2017-06-13T08:29:25Z

Linter CI: https://ci.nodejs.org/job/node-test-linter/9802/

(is it executed with the new version?).

vsemozhetbyt · 2017-06-13T08:35:08Z

Linter CI was suspiciously quick. Is "Linting is not available through the source tarball" message OK?

targos · 2017-06-13T08:39:34Z

That doesn't look right.

cjihrig

Rubberstamp LGTM

gibfahn · 2017-06-13T11:59:38Z

The Makefile checks for tools/eslint/lib/eslint.js. That exists on master but not in this PR.

lib/eslint.js was renamed to lib/linter.js in eslint/eslint@3ec436e. The Makefile and vcbuild.bat will have to be updated. It looks like tools/jslint.js will still work though.

vsemozhetbyt · 2017-06-13T12:30:28Z

Should not the Linter CI fail in such cases?

gibfahn · 2017-06-13T13:44:04Z

Should not the Linter CI fail in such cases?

Yes, #13658

Refs: nodejs#13645 (comment)

jasnell · 2017-06-13T16:12:15Z

Rubber stamp LGTM

silverwind · 2017-06-13T16:14:57Z

Can you split into two commits? One for the config changes and one for the update? Not that I care much, but this is how we've been doing it in the past.

Trott · 2017-06-13T16:40:59Z

Can you split into two commits? One for the config changes and one for the update? Not that I care much, but this is how we've been doing it in the past.

Not in this case because then one of the commits will be broken. The config changes are necessary for this version of ESLint. They need to happen in the same commit.

silverwind · 2017-06-13T16:44:46Z

Not in this case because then one of the commits will be broken

Right, this is a special case with the major version, so it's okay.

refack

Works on windows 👍
Rubber stamp code

Trott · 2017-06-15T20:34:42Z

Removed dangling symlink.

Make the "can we lint?" check in Makefile and vcbuild.bat depend on bin/eslint.js rather than lib/eslint.js. In ESLint 4.0.0, lib/eslint.js is not present. The lint rules call bin/eslint.js so check for that instead.

Update ESLint and configuration to version 4.0.0.

Update ESLint and configuration to version 4.0.0. PR-URL: #13645 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Make the "can we lint?" check in Makefile and vcbuild.bat depend on bin/eslint.js rather than lib/eslint.js. In ESLint 4.0.0, lib/eslint.js is not present. The lint rules call bin/eslint.js so check for that instead. PR-URL: #13645 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Update ESLint and configuration to version 4.0.0. PR-URL: #13645 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #13658 Ref: #13645 (comment) Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Make the "can we lint?" check in Makefile and vcbuild.bat depend on bin/eslint.js rather than lib/eslint.js. In ESLint 4.0.0, lib/eslint.js is not present. The lint rules call bin/eslint.js so check for that instead. PR-URL: #13645 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Update ESLint and configuration to version 4.0.0. PR-URL: #13645 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #13658 Ref: #13645 (comment) Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins · 2017-07-17T18:38:21Z

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace the backport request label with do-not-land if it shouldn't land

Make the "can we lint?" check in Makefile and vcbuild.bat depend on bin/eslint.js rather than lib/eslint.js. In ESLint 4.0.0, lib/eslint.js is not present. The lint rules call bin/eslint.js so check for that instead. PR-URL: nodejs#13645 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Trott · 2017-07-18T06:38:13Z

@MylesBorins Backported in #14340

Update ESLint and configuration to version 4.0.0. PR-URL: nodejs#13645 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Make the "can we lint?" check in Makefile and vcbuild.bat depend on bin/eslint.js rather than lib/eslint.js. In ESLint 4.0.0, lib/eslint.js is not present. The lint rules call bin/eslint.js so check for that instead. Backport-PR-URL: #14340 PR-URL: #13645 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Update ESLint and configuration to version 4.0.0. Backport-PR-URL: #14340 PR-URL: #13645 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Trott added the tools Issues and PRs related to the tools directory. label Jun 13, 2017

Trott force-pushed the eslint-v4.0.0 branch 2 times, most recently from d0e42e3 to 0069a4d Compare June 13, 2017 03:56

sam-github reviewed Jun 13, 2017

View reviewed changes

not-an-aardvark approved these changes Jun 13, 2017

View reviewed changes

cjihrig reviewed Jun 13, 2017

View reviewed changes

cjihrig approved these changes Jun 13, 2017

View reviewed changes

gibfahn mentioned this pull request Jun 13, 2017

build: fail linter if linting not available #13658

Closed

2 tasks

gibfahn added a commit to gibfahn/node that referenced this pull request Jun 13, 2017

build: fail linter if linting not available

2f141ca

Refs: nodejs#13645 (comment)

refack approved these changes Jun 13, 2017

View reviewed changes

Trott added blocked PRs that are blocked by other issues or PRs. and removed blocked PRs that are blocked by other issues or PRs. labels Jun 15, 2017

Trott force-pushed the eslint-v4.0.0 branch from 0069a4d to 0bcc084 Compare June 15, 2017 20:34

Trott added 2 commits June 15, 2017 13:55

build: check for linter in bin rather than lib

8eaf72c

Make the "can we lint?" check in Makefile and vcbuild.bat depend on bin/eslint.js rather than lib/eslint.js. In ESLint 4.0.0, lib/eslint.js is not present. The lint rules call bin/eslint.js so check for that instead.

tools: update ESLint to v4.0.0

ad0702c

Update ESLint and configuration to version 4.0.0.

Trott force-pushed the eslint-v4.0.0 branch from 0bcc084 to ad0702c Compare June 15, 2017 20:55

refack mentioned this pull request Jun 19, 2017

doc: document res.connection and res.socket #13617

Closed

2 tasks

addaleax mentioned this pull request Jun 21, 2017

v8.2.0 proposal #13744

Merged

addaleax mentioned this pull request Jun 21, 2017

v8.1.3 proposal #13861

Merged

MylesBorins added backport-requested-v6.x labels Jul 17, 2017

MylesBorins added backported-to-v6.x and removed backport-requested-v6.x labels Jul 18, 2017

MylesBorins mentioned this pull request Jul 18, 2017

v6.11.2 proposal #14356

Merged

Trott deleted the eslint-v4.0.0 branch October 10, 2021 01:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: update ESLint to v4.0.0 #13645

tools: update ESLint to v4.0.0 #13645

Trott commented Jun 13, 2017

Trott commented Jun 13, 2017 •

edited

Loading

sam-github left a comment

Trott commented Jun 13, 2017

not-an-aardvark left a comment

vsemozhetbyt commented Jun 13, 2017 •

edited

Loading

vsemozhetbyt commented Jun 13, 2017

targos commented Jun 13, 2017

cjihrig left a comment

gibfahn commented Jun 13, 2017 •

edited

Loading

vsemozhetbyt commented Jun 13, 2017

gibfahn commented Jun 13, 2017

jasnell commented Jun 13, 2017

silverwind commented Jun 13, 2017

Trott commented Jun 13, 2017

silverwind commented Jun 13, 2017

refack left a comment

Trott commented Jun 15, 2017

MylesBorins commented Jul 17, 2017

Trott commented Jul 18, 2017

tools: update ESLint to v4.0.0 #13645

tools: update ESLint to v4.0.0 #13645

Conversation

Trott commented Jun 13, 2017

Checklist

Affected core subsystem(s)

Trott commented Jun 13, 2017 • edited Loading

sam-github left a comment

Choose a reason for hiding this comment

Trott commented Jun 13, 2017

not-an-aardvark left a comment

Choose a reason for hiding this comment

vsemozhetbyt commented Jun 13, 2017 • edited Loading

vsemozhetbyt commented Jun 13, 2017

targos commented Jun 13, 2017

cjihrig left a comment

Choose a reason for hiding this comment

gibfahn commented Jun 13, 2017 • edited Loading

vsemozhetbyt commented Jun 13, 2017

gibfahn commented Jun 13, 2017

jasnell commented Jun 13, 2017

silverwind commented Jun 13, 2017

Trott commented Jun 13, 2017

silverwind commented Jun 13, 2017

refack left a comment

Choose a reason for hiding this comment

Trott commented Jun 15, 2017

MylesBorins commented Jul 17, 2017

Trott commented Jul 18, 2017

Trott commented Jun 13, 2017 •

edited

Loading

vsemozhetbyt commented Jun 13, 2017 •

edited

Loading

gibfahn commented Jun 13, 2017 •

edited

Loading