v8.1.3 proposal #13861
Merged
v8.1.3 proposal #13861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #11607 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
test-child-process-stdio-big-write-end was failing on ubuntu1604-arm64 because the while loop that was supposed to fill up the buffer ended up being an infinite loop. This increases the size of the writes in the loop by 1K until the buffer fills up. PR-URL: #13626 Fixes: #13603 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Confirm that callback is not being invoked in test-http-eof-on-connect.js. PR-URL: #13587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The earlier version `napi_callback` returns `void` but now is `napi_value`. The document of this section hasn't been modified. PR-URL: #13570 Fixes: #12248 Fixes: #13562 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #13620 Fixes: #13616 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Minor correction in the comment regarding ssl_set_pkey. PR-URL: #13653 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add common.mustCall() check to test-child-process-stdio-big-write-end. PR-URL: #13605 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Use common.mustNotCall() in test/sequential/test-fs-watch.js in situations where the call to watch() is expected to throw. PR-URL: #13595 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add a note to clarify that any platform that is EoL will not be supported by Node.js. PR-URL: #12672 Fixes: nodejs/build#688 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Updated onboarding-extras.md to /cc @nodejs/v8-inspector for inspector issues and reorganized /cc list in alphabetical order. PR-URL: #13632 Fixes: #13621 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Also, add tests to ensure they will always return this, and to confirm they return this when these doc changes are back-ported to earlier release lines. PR-URL: #13531 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* block scope `paused` * change name of block-scoped `file3` etc. to `file` * alphabetize modules * confirm contents provided in `data` callback * confirm `data` callbacks will not fire on tests for errors PR-URL: #13618 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
> Generally it will correspond the name of the resource's constructor. should read "Generally, it will correspond to the name..." PR-URL: #13666 Fixes: #13663 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
In non-buffer tests, change usage of the Buffer constructor to one of the recommended alternatives. PR-URL: #13649 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Brian White <mscdex@mscdex.net>
* use common.mustNotCall() to confirm callback is not invoked * blank line after common module per test writing guide PR-URL: #13661 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* Adding --inspect-port with debug port, instead of parsing `execArgv`
* Export CLI debug options to `process.binding('config').debugOptions`
(currently used only in tests)
PR-URL: #13619
Refs: #9659
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
oath.md: make order of properties consistent tls.md: remove spaces in getPeerCertificate signature tls.md: add deprecation notice to server.connections http.md: fix signature of request.end crypto.md: change crypto parameters to camelCase vm.md: add missing apostrophe vm.md: fix signature of vm.runInNewContext zlib.md: improve description of zlib.createXYZ PR-URL: #13491 Ref: #9538 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Add doc for napi_create_string_latin1(). - Fix signatures where c string was specified instead of napi_value. - Fix return type of napi_callback. - Update to specify that napi_escape_handle() can only be called once for a given scope. PR-URL: #13650 Fixes: #13555 Fixes: #13556 Fixes: #13562 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
There are a number of void casts of clear_error_on_return which is a usage of the RAII idiom. The ClearErrorOnReturn struct only has a destructor and no constructor which I believe was an issue in GCC prior to version 4.8.0, which lead to a unused variable warning. I'm wondering if these cast could be removed since GCC 4.8.5 or newer is required now. An alternative solution would be to add an empty constructor which should work allowing the compiler to detect that a variable is used only for its side-effects. Not sure if this was the sole reason for having these casts but wanted to bring it up just in case. Refs: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10416 PR-URL: #13669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* Add common.mustCall(). * Add check for error existence, not only for error details. * Use test(), not match() in a boolean context. * Properly reverse meanings of assert messages. PR-URL: #13680 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #13685 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
In util.format, if a percent sign without a known type is encountered, just print it instead of silently ignoring it and the next character. PR-URL: #13674 Fixes: #13665 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
* alphabetize modules * replace callback invocation counts with common.mustCall() * add block-scoping * remove commented-out code that uses an identifier not in the test * move exit handlers to relevant blocks to keep tests cohesive * common.noop -> common.mustNotCall() * check results from `data` event PR-URL: #13643 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #13673 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #13658 Ref: #13645 (comment) Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #13413 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #13713 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
@rvagg I don’t have much docker experience, so I really don’t have any idea how to get core dumps either. If you think giving me access is okay, I’ll see what I can do, but I can’t promise anything. @refack Mostly, yes. To be clear, I never expected 8.2.0 to be released quickly, it’s a pretty big change, and I do think we should get out the streams fixes soon-ish. |
|
@addaleax: ssh root@107.170.75.204 and you should get in with one of your keys in github. Run |
|
@rvagg Thanks, I tried it but I couldn’t get it to fail manually. I’m afraid I’m done for today. :/ It’s probably really best to take a look at the errors coming from a normal |
|
Just chatting with @MylesBorins and we're thinking that it'd be best to defer this until next week because of the crappy nature of Friday releases. There's nothing super urgent here that would override that is there? (the non-Friday thing is normally strict for LTS which generally happens on Tuesday but I don't believe we've ever had a strong convention for Current releases). |
|
#13850 is the only half-urgent one. But early next week is ok, too. This should be added to this release proposal. It is already in master. |
This commit aims to improve the documentation examples that send sockets over IPC channels. Specifically, pauseOnConnect is added to a server that inspects the socket before sending and a 'message' handler adds a check that the socket still exists. PR-URL: #13196 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
When _write completes with an Error, 'finish' was emitted before 'error' if the callback was asynchronous. This commit restore the previous behavior. The logic is still less then ideal, because we call the write() callback before emitting error if asynchronous, but after if synchronous. This commit do not try to change the behavior. This commit fixes a regression introduced by: #13195. Fixes: #13812 PR-URL: #13850 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
test-global-console-exists cannot use the common module as explained in a comment but it was included later anyway. This change removes it. PR-URL: #13748 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
In preparation for applying the more strict indentation linting available in ESLint 4.0.0, correct minor indentation issues in tools/eslint-rules/required-modules.js. This is the only file with indentation that does not conform to the stricter checks. PR-URL: #13758 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
ESLint 4.0.0 provides stricter (and more granular) indentation checking than previous versions. Apply the stricter indentation rules to the tools directory. PR-URL: #13758 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fix previously-unnoticed typo in `required-modules.js`. Refs: #13758 (comment) PR-URL: #13758 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* Use common.mustCall() to confirm that _write() is called only once. * Check that _write() is called with the correct argument PR-URL: #13823 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
* Use `common.mustCall()` to track callback invocations * Remove console.log() statements unrelated to the test * Add blank line to conform with test-writing guide PR-URL: #13802 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
* also update STYLE_GUIDE comment about Em dashes PR-URL: #13749 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
addaleax
force-pushed
the
v8.1.3-proposal
branch
from
70a17ba to
0a8e9c9
Compare
|
I’ve updated this proposal with the other streams fix and the test/doc changes since the last update. CI: https://ci.nodejs.org/job/node-test-commit/10768/ |
|
Are we releasing 8.1.3 this week? |
Unless anybody objects to that, I think that’s the plan. (@rvagg ?) |
|
This needs to wait for #13969 |
|
@refack Why? The original PR isn’t included so my first thought would be that the revert isn’t needed either. |
Ok. Makes sense. Hit the "panic" button too soon. |
Had a third thought; Nightlies... They will break. |
Notable changes
* **Stream**
Two regressions with the `stream` module have been fixed:
* The `finish` event will now always be emitted after the `error` event
if one is emitted:
[[`0a9e96e86c`](0a9e96e86c)]
[#13850](#13850)
* In object mode, readable streams can now use `undefined` again.
[[`5840138e70`](5840138e70)]
[#13760](#13760)
|
Test run @ https://ci.nodejs.org/job/node-test-commit/10807/ looks great excl the expected Alpine segfault and UCS2 error on the Pi's. |
|
thanks for the hard work @addaleax, release is done |
|
Thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking with @mcollina for a bit, we agreed that it would be best to do a patch release soon rather than waiting for 8.2.0, so this is a light version of that proposal. We’d like to include #13850 once that lands, but that should be about it.
I’ve marked 8.2.0 as blocked for now, but if any of the release people have the time to create RC builds for 8.2.0, I think that would still be a good way to get feedback on TF+I in Node 8.
/cc @nodejs/release @nodejs/ctc
2017-06-??, Version 8.1.3 (Current), @addaleax
Notable changes
Two regressions with the
streammodule have been fixed:finishevent will now always be emitted after theerroreventif one is emitted:
[
0a9e96e86c]#13850
undefinedagain.[
5840138e70]#13760
Commits
11f45623ac] - benchmark: remove needless RegExp capturing (Vse Mozhet Byt) #137182ce236e173] - build: check for linter in bin rather than lib (Rich Trott) #1364518f073f0fe] - build: fail linter if linting not available (Gibson Fahnestock) #13658465bd48b14] - configure: add mips64el to valid_arch (Aditya Anand) #136201fe455f525] - dgram: change parameter name in set(Multicast)TTL (Tobias Nießen) #13747a63e54a94c] - doc: update backporting guide (Refael Ackermann) #137490bb53a7aa2] - doc: make socket IPC examples more robust (cjihrig) #1319657b7285400] - doc: mention rebasing of v?.x-staging post release (Anna Henningsen) #13742cb932835d5] - doc:path.relativeusescwd(DuanPengfei) #1371461714acbe5] - doc: add hasIntl to test/common/README.md (Daniel Bevenius) #136992a95cfb4ef] - doc: fix typo in changelog (Teddy Katz) #1371331ae193b99] - doc: small makeover for onboarding.md (Anna Henningsen) #13413c27ffadf8e] - doc: fix a few n-api doc issues (Michael Dawson) #13650c142f1d316] - doc: fix minor issues reported in A collection of minor issues with the docs #9538 (Tobias Nießen) #13491f28dd8e680] - doc: fixes a typo in the async_hooks documentation (Chris Young) #1366658e177cde1] - doc: document and test that methods return this (Sam Roberts) #13531f5f2a0e968] - doc: sort and update /cc list for inspector issues (Aditya Anand) #13632dc06a0a85a] - doc: note that EoL platforms are not supported (Gibson Fahnestock) #126729b74dded0d] - doc: update async_hooks providers list (Anna Henningsen) #13561cc922310e3] - doc: fix out of date napi_callback doc (XadillaX) #135708cb7d96569] - fs: don't conflate data and callback in appendFile (Nikolai Vavilov) #11607233545a81c] - inspector,cluster: fix inspect port assignment (cornholio) #13619cbe7c5c617] - lib: correct typo in createSecureContext (Daniel Bevenius) #13653f49dd21b2f] - n-api: avoid crash in napi_escape_scope() (Michael Dawson) #1365128166770bd] - net: fix abort on bad address input (Ruben Bridgewater) #13726e786926de9] - readline,repl,url,util: remove needless capturing (Vse Mozhet Byt) #137183322191d2f] - src: don't set --icu_case_mapping flag on startup (Ben Noordhuis) #13698a27a35b997] - src: fix decoding base64 with whitespace (Nikolai Vavilov) #136605b3e5fac38] - src: remove void casts for clear_error_on_return (Daniel Bevenius) #136690a9e96e86c] - stream: finish must always follow error (Matteo Collina) #138505840138e70] - stream: fixundefinedin Readable object mode (Anna Henningsen) #13760f1d96f0b2a] - test: refactor test-http-set-timeout-server (Rich Trott) #13802b23f2461cb] - test: refactor test-stream2-writable (Rich Trott) #138239ff9782f66] - test: remove common module from test it thwarts (Rich Trott) #137481f32d9ef5b] - test: fix RegExp nits (Vse Mozhet Byt) #137703306fd1d97] - test: accommodate AIX by watching file (Rich Trott) #13766c8b134bc6d] - test: remove node-tap lookalike (cjihrig) #13707d4a05b2d9c] - test: make test-http(s)-set-timeout-server alike (jklepatch) #13625d0f39cc38a] - test: delete outdated fixtures/stdio-filter.js (Vse Mozhet Byt) #13712b2a5399760] - test: refactor test-fs-watch-stop-sync (Rich Trott) #1368910aee10c0c] - test: check zlib version for createDeflateRaw (Daniel Bevenius) #136970d3b52e9de] - test: add hasIntl to failing test (Daniel Bevenius) #1369970fb1bd038] - test: improve http test reliability (Brian White) #136935e59c2d21d] - test: increase coverage for internal/module.js (Tamás Hódi) #13673ba20627520] - test: refactor test-fs-read-stream (Rich Trott) #13643e203e392d7] - test: refactor test-cluster-worker-isconnected.js (cjihrig) #1368580e6524ff0] - test: fix nits in test-fs-mkdir-rmdir.js (Vse Mozhet Byt) #13680406c09aacb] - test: fix test-inspector-port-zero-cluster (Refael Ackermann) #13373af46cf621b] - test: refactor test-fs-watch-stop-async (Rich Trott) #136616920d5c9f9] - test: change deprecated method to recommended (Rich Trott) #136490d87b3102a] - test: refactor test-fs-read-stream-inherit (Rich Trott) #1361880fa13b93f] - test: use mustNotCall() in test-fs-watch (Rich Trott) #135957874360ca2] - test: add mustCall() to child-process test (Rich Trott) #136055cb3fac396] - test: use mustNotCall in test-http-eof-on-connect (Rich Trott) #135874afa7483b1] - test: increase bufsize in child process write test (Rich Trott) #136260ef687e858] - tools: fix error in custom ESLint rule (Rich Trott) #13758b171e728e5] - tools: apply stricter indentation rules to tools (Rich Trott) #137589c2abc3e29] - tools: fix indentation in required-modules.js (Rich Trott) #13758ff568d4b63] - tools: update ESLint to v4.0.0 (Rich Trott) #13645c046a21321] - util: ignore invalid format specifiers (Michaël Zasso) #13674c68e472b76] - v8: fix RegExp nits in v8_prof_polyfill.js (Vse Mozhet Byt) #13709