Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-cluster-worker-isconnected.js #13685

Closed
wants to merge 1 commit into from
Closed

test: refactor test-cluster-worker-isconnected.js #13685

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 14, 2017

This commit:

  • Uses assert.strictEqual() instead of assert.ok().
  • Verifies that the 'disconnect' listeners are called using common.mustCall().
  • Verifies that 'disconnect' is emitted on cluster.worker.process in the worker.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 14, 2017
@DavidCai1111
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/8665/

jasnell pushed a commit that referenced this pull request Jun 16, 2017
@cjihrig @jasnell
test: refactor test-cluster-worker-isconnected.js
06ca205 
PR-URL: #13685
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 16, 2017

Landed in 06ca205

@jasnell jasnell closed this Jun 16, 2017
@cjihrig cjihrig deleted the disconnect branch June 16, 2017 16:02
addaleax pushed a commit that referenced this pull request Jun 17, 2017
@cjihrig @addaleax
test: refactor test-cluster-worker-isconnected.js
6607003 
PR-URL: #13685
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Jun 17, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@cjihrig @addaleax
test: refactor test-cluster-worker-isconnected.js
e203e39 
PR-URL: #13685
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
@cjihrig @MylesBorins
test: refactor test-cluster-worker-isconnected.js
ef3698c 
PR-URL: #13685
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidCai1111 DavidCai1111 DavidCai1111 approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @DavidCai1111 @jasnell @refack @danbev @lpinca @MylesBorins @nodejs-github-bot