Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: SHASUMS256, not SHASUM256 #15101

Closed
wants to merge 1 commit into from
Closed

doc: SHASUMS256, not SHASUM256 #15101

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

As an example, curl https://nodejs.org/dist/v8.4.0/SHASUM256.txt will
return a 404 right now.

Checklist
Affected core subsystem(s)

doc

@maclover7
doc: SHASUMS256, not SHASUM256
6e9eef2 
As an example, `curl https://nodejs.org/dist/v8.4.0/SHASUM256.txt` will
return a 404 right now.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 30, 2017
@BridgeAR
Copy link
Member

I think this does not need the typical 48 hours.

refack
refack approved these changes Aug 30, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for fast tracking

@refack refack self-assigned this Aug 30, 2017
@refack
Copy link
Contributor

refack commented Aug 30, 2017

  • 5 Approvals in an hour
  • 4 👍 for fast-tracking
  • Small doc fix

Landing.

@refack
Copy link
Contributor

refack commented Aug 30, 2017

Landed in 676522f
(after local lint + mdlint run)

@refack refack closed this Aug 30, 2017
refack pushed a commit that referenced this pull request Aug 30, 2017
@maclover7 @refack
doc: /s/SHASUM256/SHASUMS256
676522f 
As an example, `curl https://nodejs.org/dist/v8.4.0/SHASUM256.txt` will
return a 404 right now.

PR-URL: #15101
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@maclover7 maclover7 deleted the jm-shasums branch August 30, 2017 21:18
cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
@maclover7 @cjihrig
doc: /s/SHASUM256/SHASUMS256
8d8a99a 
As an example, `curl https://nodejs.org/dist/v8.4.0/SHASUM256.txt` will
return a 404 right now.

PR-URL: nodejs#15101
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@maclover7 @MylesBorins
doc: /s/SHASUM256/SHASUMS256
daaa4f1 
As an example, `curl https://nodejs.org/dist/v8.4.0/SHASUM256.txt` will
return a 404 right now.

PR-URL: #15101
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@maclover7 @MylesBorins
doc: /s/SHASUM256/SHASUMS256
959b270 
As an example, `curl https://nodejs.org/dist/v8.4.0/SHASUM256.txt` will
return a 404 right now.

PR-URL: #15101
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 20, 2017
@maclover7 @MylesBorins
doc: /s/SHASUM256/SHASUMS256
2166503 
As an example, `curl https://nodejs.org/dist/v8.4.0/SHASUM256.txt` will
return a 404 right now.

PR-URL: #15101
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 26, 2017
@maclover7 @MylesBorins
doc: /s/SHASUM256/SHASUMS256
1b0e660 
As an example, `curl https://nodejs.org/dist/v8.4.0/SHASUM256.txt` will
return a 404 right now.

PR-URL: #15101
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack refack removed their assignment Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maclover7 @BridgeAR @refack @jasnell @benjamingr @lpinca @MylesBorins @nodejs-github-bot