Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.5.0 proposal #15308

Merged
merged 231 commits into from
Sep 12, 2017
Merged

v8.5.0 proposal #15308

merged 231 commits into from
Sep 12, 2017

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Sep 10, 2017

2017-09-12, Version 8.5.0 (Current), @MylesBorins

Notable Changes

Notable Changes

  • build
    • Snapshots are now re-enabled in V8
      #14875
  • console
    • Implement minimal console.group().
      #14910
  • deps
    • upgrade libuv to 1.14.1
      #14866
    • update nghttp2 to v1.25.0
      #14955
  • dns
    • Add verbatim option to dns.lookup(). When true, results from the DNS
      resolver are passed on as-is, without the reshuffling that Node.js
      otherwise does that puts IPv4 addresses before IPv6 addresses.
      #14731
  • fs
    • add fs.copyFile and fs.copyFileSync which allows for more efficient
      copying of files.
      #15034
  • inspector
    • Enable async stack traces #13870
  • module
    • Add support for ESM. This is currently behind the --experimental-modules flag
      and requires the .mjs extension.
      node --experimental-modules index.mjs
      #14369
  • napi
  • os
    • Add support for CIDR notation to the output of the networkInterfaces() method.
      #14307
  • perf_hooks
    • An initial implementation of the Performance Timing API for Node.js. This is the
      same Performance Timing API implemented by modern browsers with a number of Node.js
      specific properties. The User Timing mark() and measure() APIs are implemented,
      as is a Node.js specific flavor of the Frame Timing for measuring event loop duration.
      #14680
  • tls
    • multiple PFX in createSecureContext
      #14793
  • Added new collaborators

Commits

  • [87c3e1d7de] - fix --prof-process --preprocess flag (davidmarkclements) #14966
  • [bcf0e5d676] - assert: handle errors properly with deep*Equal (Ruben Bridgewater) #15001
  • [7174dc2e8a] - assert: handle sparse arrays in deepStrictEqual (Ruben Bridgewater) #15027
  • [b40105df3b] - async_hooks: don't abort unnecessarily (Trevor Norris) #14722
  • [3e73ea8745] - async_hooks: improve comments and function names (Trevor Norris) #14722
  • [700d576962] - async_hooks: emitAfter correctly on fatalException (Trevor Norris) #14914
  • [78a36e0dd1] - async_wrap: unroll unnecessarily DRY code (Trevor Norris) #14722
  • [fadccbaa17] - async_wrap: return undefined if domain is disposed (Trevor Norris) #14722
  • [8d11220e0b] - benchmark: add default configs to buffer benchmark (Rich Trott) #15175
  • [7feb99455a] - benchmark: fix issues in dns benchmark (Ian Perkins) #14936
  • [978889f8c0] - benchmark: fix dgram/bind-params.js benchmark (Rich Trott) #14948
  • [7f1ea7c3af] - benchmark: removed unused arguments from callbacks (Abhishek Raj) #14919
  • [ca3ec90285] - benchmark: convert var to es6 const (Sebastian Murphy) #12886
  • [bda5585012] - buffer: fix MAX_LENGTH constant export (Anna Henningsen) #14821
  • [b9e1f60333] - buffer: increase coverage by removing dead code (Marcelo Gobelli) #15100
  • [5b8fa29649] - build: display HTTP2 configure --help options (Daniel Bevenius) #15198
  • [6de4e10c7a] - build: add NetBSD support to opensslconf.h (Roy Marples) #14313
  • [ebb3c2ce6f] - build: add npx to zip and 7z packages (Richard Lau) #15033
  • [b946693f4b] - build: fix indentation in node.gyp (Alexey Orlenko) #15051
  • [c8be90cabf] - build: for --enable-static, run only cctest (Daniel Bevenius) #14892
  • [77dfa73cf2] - build: better support for python3 systems (Ben Noordhuis) #14737
  • [8f3537f66a] - build: allow proper generation of html docs (Jon Moss) #14932
  • [838d3fef72] - build: don't add libraries when --enable-static (Daniel Bevenius) #14912
  • [9d373981f4] - build: remove duplicated code (Ruslan Bekenev) #13482
  • [e12a9c567c] - build: re-enable snapshots in v8.x (Myles Borins) #14875
  • [3a68b0bb98] - console: improve console.group() (Rich Trott) #14999
  • [a46e59d52d] - (SEMVER-MINOR) console: implement minimal console.group() (Rich Trott) #14910
  • [78a71aa123] - crypto: fix error of createCipher in wrap mode (Shigeki Ohtsu) #15037
  • [41bf40e209] - crypto: warn if counter mode used in createCipher (Shigeki Ohtsu) #13821
  • [ba5a697bdb] - deps: cherry-pick 5005faed5 from V8 upstream (Miguel Martins) #15177
  • [d18bb3d1dd] - deps: cherry-pick 1aead19 from upstream V8 (Ben Noordhuis) #15184
  • [acf9650730] - deps: upgrade libuv to 1.14.1 (cjihrig) #14866
  • [296729c41e] - deps: cherry-pick 0ef4a0c64b6 from c-ares upstream (Anna Henningsen) #15023
  • [3f7bdc5ab7] - deps: cherry-pick e020aae394 from V8 upstream (Ben Noordhuis) #14913
  • [c46e7e1988] - deps: fixup nghttp2 version number (Anna Henningsen) #14955
  • [4eb907f26b] - deps: update nghttp2 to v1.25.0 (Anna Henningsen) #14955
  • [9f46bde440] - deps: backport d727680 from V8 upstream (Matt Loring) #14947
  • [56bb199ef0] - deps: cherry-pick eb306f463e from nghttp2 upstream (Anna Henningsen) #14808
  • [55eed604a9] - deps: backport f9c4b7a from upstream V8 (Matt Loring) #14001
  • [b7f7d67677] - deps: backport bca8409 from upstream V8 (Matt Loring) #14001
  • [a67e7f9b35] - deps: backport 6e9e2e5 from upstream V8 (Matt Loring) #14001
  • [6e2f62262d] - deps: backport 3d8e87a from upstream V8 (Matt Loring) #14001
  • [6cb718b87a] - deps: backport 5152d97 from upstream V8 (Matt Loring) #14001
  • [c6e2b8adf7] - deps: backport c4852ea from upstream V8 (Matt Loring) #14001
  • [bfb97b71b6] - deps: cherry-pick fa4ec9f from V8 upstream (Jaideep Bajwa) #14608
  • [1a2f749e16] - deps: fix inspector v8 test (Eugene Ostroukhov) #14827
  • [13577d4ada] - dns: add verbatim option to dns.lookup() (Ben Noordhuis) #14731
  • [ffed33710c] - doc: add ESM doc to _toc.md and all.md (Vse Mozhet Byt) #15248
  • [1b51287603] - doc: fix Error property markdown level (Sam Roberts) #15247
  • [af3b173e82] - doc: add missing space in test/README.md (Vse Mozhet Byt) #15278
  • [c90c68e8a0] - doc: document bytes to chars after setEncoding (Jessica Quynh Tran) #13442
  • [ea86cb59b9] - doc: describe what security issues are (Sam Roberts) #14485
  • [ddbcc9e59d] - doc: add options argument to crypto docs (Adina Shanholtz) #14846
  • [da5e6d33d5] - doc: instructions for generating coverage reports (Simon Brewster) #15190
  • [286111a2b0] - doc: clarify async/asynchronous in deprecations.md (Rich Trott) #15172
  • [9542844feb] - doc: readFileSync instead of fs.readFileSync (Piotr Mionskowski) #15137
  • [959b270fe1] - doc: /s/SHASUM256/SHASUMS256 (Jon Moss) #15101
  • [3697cd86c4] - doc: fix comment about http2.createSecureServer (creeperyang) #15085
  • [76780445b3] - doc: remove braces which shouldn't be there (Jan Schär) #15094
  • [2610ae326f] - doc: clarify http.get data consumption requirement (AJ Jordan) #15049
  • [e7838d7077] - doc: add 8.4.0 link to CHANGELOG.md (Ruslan Iusupov) #15064
  • [feeff48d5c] - doc: add links to alternative versions of doc (Chris Young) #10958
  • [a5242851b9] - doc: update configure to require g++ 4.9.4 (Dave Olszewski) #14204
  • [87ff86b2d8] - doc: building - note on Windows SDK 15063 (Refael Ackermann) #14394
  • [449549bc4f] - doc: threadpool size, and APIs using the pool (Sam Roberts) #14995
  • [6bb8133638] - doc: sort bottom-of-file dns markdown links (Sam Roberts) #14992
  • [a06d1295c5] - doc: crypto.randomBytes does not block when async (Sam Roberts) #14993
  • [83ba2aa46b] - doc: environmental->environment & NodeJS->Node.js (Rod Vagg) #14974
  • [f1bc168ad5] - doc: fix typo in Buffer.from(string, [encoding]) (Michał Wadas) #15013
  • [9b9e7b4044] - doc: add note for Windows build path (Kyle Lamse) #14354
  • [57c7eae1df] - doc: rephrase text of child_process.execSync() (hafiz) #14953
  • [188713ca46] - doc: beautify net.md formats (sevenryze) #14987
  • [a8648e287c] - doc: link to correct "OS Constants" heading in docs (James Kyle) #14969
  • [e187c98186] - doc: remove misterdjules from the CTC members list (Julien Gilli) #1498
  • [78b2bc77f2] - doc: update http2.md example code (RefinedSoftwareLLC) #14979
  • [6179c2764a] - doc: fix doc for napi_get_value_string_utf8 (Daniel Taveras) #14529
  • [daae6bc652] - doc: fixed link definitions in http2.md footer (sharababy) #14946
  • [6c93d01fba] - doc: remove you and fixup note in stream.md (James M Snell) #14938
  • [96d95d4fed] - doc: minor fixes to http/2 docs (Anand Suresh) #14877
  • [bfa3cbe158] - doc: remove redundant only from doc/api/stream.md (George Sapkin) #14858
  • [c5380c83c6] - doc: add missing word (Jon Moss) #14924
  • [abe014834e] - doc: fix http api document (陈刚) #14625
  • [050a2249c1] - doc: explain what to do if git push is rejected (Rich Trott) #14848
  • [3d621393bd] - doc: add BridgeAR to collaborators (Ruben Bridgewater) #14862
  • [c8f0e5ab82] - doc: fix typo in cli.md (hsmtkk) #14855
  • [0dc9d284a4] - doc: added napi_get_value_string_latin1 (Kyle Farnung) #14678
  • [72cc2caf78] - doc: fix word wrapping for api stability boxes (Saad Quadri) #14809
  • [205d5f674a] - doc,fs: rename defaultEncoding option to encoding (Aleh Zasypkin) #14867
  • [aaf55db95b] - doc,lib,src,test: strip executable bits off files (Anna Henningsen) #15132
  • [7f62378e76] - doc,stream: remove wrong remark on readable.read (Jan Schär) #15014
  • [ea2b5760d5] - errors: remove duplicated ERR_HTTP_INVALID_STATUS_CODE error (Jon Moss) #15003
  • [71f90c6f80] - (SEMVER-MINOR) fs: add fs.copyFile{Sync} (cjihrig) #15034
  • [3d9ad82729] - gyp: fix ninja build failure (GYP patch) (Daniel Bevenius) #12484
  • [12191f6ed8] - gyp: enable cctest to use objects (gyp part) (Daniel Bevenius) #12450
  • [538894978b] - gyp: add compile_commands.json gyp generator (Ben Noordhuis) #12450
  • [7eb3679eea] - gyp: inherit parent for *.host (Johan Bergström) #6173
  • [5fb252a5a2] - gyp: fix gyp to work on MacOSX without XCode (Shigeki Ohtsu) iojs/io.js#1325
  • [0343eceda4] - http2: fix refs to status 205, add tests (Anatoli Papirovski) #15153
  • [d8ff550528] - http2: store headersSent after stream destroyed (Anatoli Papirovski) #15232
  • [4882f079f1] - http2: set decodeStrings to false, test (Anatoli Papirovski) #15140
  • [93a4cf60ff] - http2: use session not socket timeout, tests (Anatoli Papirovski) #15188
  • [764213cc7b] - http2: add compat trailers, adjust multi-headers (Anatoli Papirovski) #15193
  • [cc82f541e5] - http2: fix closedCode NaN, increase test coverage (Anatoli Papirovski) #15154
  • [afa72dfdf3] - http2: guard against destroyed session, timeouts (James M Snell) #15106
  • [f6c51888db] - http2: correct emit error in onConnect, full tests (Anatoli Papirovski) #15080
  • [fd51cb8ca3] - http2: adjust error types, test coverage (Anatoli Papirovski) #15109
  • [f612a6dd5c] - http2: handle 100-continue flow & writeContinue (Anatoli Papirovski) #15039
  • [989dfaf930] - http2: refactor error handling (Matteo Collina) #14991
  • [d231ef645e] - http2: ignore invalid headers explicitly (Anna Henningsen) #14955
  • [1b57c375aa] - http2: minor refactor of passing headers to JS (Anna Henningsen) #14808
  • [80fe40aabf] - http2: handful of http/2 src cleanups (James M Snell) #14825
  • [9589641c5c] - http2: Expose Http2ServerRequest/Response (Pini Houri) #14690
  • [8c61b72f90] - (SEMVER-MINOR) inspector: enable async stack traces (Miroslav Bajtoš) #13870
  • [e2ae08b48d] - inspector: rewrite inspector test helper (Eugene Ostroukhov) #14797
  • [105acf4af7] - inspector: log exceptions in message handlers (Eugene Ostroukhov) #14980
  • [d5a376ab7a] - lib: remove circular reference (Ruben Bridgewater) #14885
  • [605d625e62] - lib: simplify the readonly properties of icu (Jackson Tian) #13221
  • [ea0a882041] - lib: remove the invalid command line options (Jackson Tian) #13764
  • [9129057e03] - lib: clean up usage of threw (Jackson Tian) #10534
  • [f34e0f97e7] - lib: instantiate console methods eagerly (Ben Noordhuis) #14791
  • [01846a06c2] - meta: merge TSC and CTC back into a single body (James M Snell) #14973
  • [859abe5169] - meta: considerations for new core modules (James M Snell) #15022
  • [cc72118e71] - meta: improve definition of a collaborator (James M Snell) #14981
  • [865a3c3daf] - (SEMVER-MINOR) module: Allow runMain to be ESM (Bradley Farias) #14369
  • [4bf0d4e133] - n-api: implement napi_run_script (Gabriel Schulhof) #15216
  • [3a18df0750] - n-api: adds function to adjust external memory (Chris Young) #14310
  • [503370e2d3] - (SEMVER-MINOR) n-api: implement promise (Gabriel Schulhof) #14365
  • [a6344d5a83] - (SEMVER-MINOR) n-api: add ability to remove a wrapping (Gabriel Schulhof) #14658
  • [67fde146e0] - net: check EADDRINUSE after binding localPort (Joyee Cheung) #15097
  • [b4e8850576] - net: move debug statement (Brian White) #12616
  • [136eea4bcb] - (SEMVER-MINOR) os: add CIDR support (Mudit Ameta) #14307
  • [29f9101a0f] - path: fix normalize on directories with two dots (Michaël Zasso) #14107
  • [e3f5c58423] - perf_hooks: fix presumed typo in node_perf.cc (Anna Henningsen) #15019
  • [69e3bc64cc] - perf_hooks: mark as experimental (James M Snell) #14997
  • [f75faddb1f] - (SEMVER-MINOR) perf_hooks: implementation of the perf timing API (James M Snell) #14680
  • [4d2aa16d33] - process: keep process prototype in inheritance chain (Jimmy Thomson) #14715
  • [ae85d5f024] - promises: more robust stringification (Timothy Gu) #13784
  • [eee2aa693b] - repl: force editorMode in .load (Lance Ball) #14861
  • [f81812b1ff] - src: turn key length exception into CHECK (Ben Noordhuis) #15183
  • [f113d7332f] - src: fix compiler warnings in node_perf.cc (Daniel Bevenius) #15112
  • [a83d427091] - src: remove unused persistent properties from env (Anna Henningsen) #15096
  • [391855c252] - src: fix build on certain platforms (Anna Henningsen) #14996
  • [8cee5d66bd] - src: reduce code duplication (James M Snell) #14937
  • [5a05dfe0a7] - src: fixup strings, reduce duplication (James M Snell) #14937
  • [1c3cb49f00] - src: miscellaneous cleanups for node_config (James M Snell) #14868
  • [7213be9f59] - src: fix DEBUG_HTTP2 type arguments (Daniel Bevenius) #15197
  • [ffe572addd] - src: replace assert() with CHECK() (Ben Noordhuis) #14663
  • [abc5cdc923] - src: remove unnecessary helper function (Brian White) #14959
  • [992d1dd956] - src: detect nul bytes in InternalModuleReadFile() (Ben Noordhuis) #14854
  • [4570fa16c7] - src: remove extra copy from Copy() in node_url.cc (Anna Henningsen) #14907
  • [081c3e107d] - src: minor cleanup for node_revert (James M Snell) #14864
  • [dcd7817fbc] - src: use unordered_set instead of custom rb tree (Anna Henningsen) #14826
  • [fadcbab617] - src: Node implementation of v8::Platform (Matt Loring) #14001
  • [c861462faa] - stream: fix Writable instanceof for subclasses (Anna Henningsen) #14945
  • [2adabe6777] - test: fix single test runner regression (Timothy Gu) #15329
  • [e3d0ff901b] - test: split test-cli-node-options (Refael Ackermann) #14195
  • [e87cb32db2] - test: remove envPlus, use Object.assign everywhere (Gibson Fahnestock) #14845
  • [dea959e841] - test: fix flaky test-readline-interface (Rich Trott) #15066
  • [ae91b1efc0] - test: continue normalizing fixtures use (Miguel Angel Asencio Hurtado) #14716
  • [77bc72ad54] - (SEMVER-MINOR) test: fix inspector helper port sniffing (Timothy Gu) #13870
  • [7facfaab66] - test: preserve env in test cases (Beth Griggs) #14822
  • [2310cfcea1] - test: exclude write-coverage from coverage report (Benjamin Coe) #15194
  • [6fa05e671c] - test: use no-save and no-package-lock flags (Simon Brewster) #15196
  • [ac71d99253] - test: add http2 compat setTimeout tests (Anatoli Papirovski) #15156
  • [7106734773] - test: add test-benchmark-buffer (Rich Trott) #15175
  • [0b9fde4d4a] - test: refactor test-fs-readfile-unlink (Rich Trott) #15173
  • [9f79bd8fba] - test: http2 test coverage for NghttpError (James M Snell) #15105
  • [c0dba0f3f4] - test: http2 test coverage for assertValidPseudoHeader (James M Snell) #15105
  • [837c29c73b] - test: http2 test coverage for updateOptionsBuffer (James M Snell) #15105
  • [e3e9e5039d] - test: increase Http2ServerResponse test coverage (Anatoli Papirovski) #15074
  • [72aae0417c] - test: split path tests into multiple files (Michaël Zasso) #15093
  • [d176a18547] - test: add a test for Expect & checkExpectation (Anatoli Papirovski) #15040
  • [cfbf5057d6] - test: add http2 test for method CONNECT (Anatoli Papirovski) #15052
  • [5b13add028] - test: remove unused param in test-graph.pipe (Simon Brewster) #15007
  • [5cb6500de9] - test: increase coverage for http2 response headers (Anatoli Papirovski) #15035
  • [7050608593] - test: fix hijackStdout behavior in console (XadillaX) #14647
  • [458b8ab5df] - test: add regression test for 14814 (Anna Henningsen) #15023
  • [f89ef77144] - test: run abort tests (Rich Trott) #14013
  • [a91a3fe6c4] - test: improve test-abort-backtrace (Rich Trott) #14013
  • [b85a73407b] - test: improve test-abort-uncaught-exception (Rich Trott) #14013
  • [f694ea6f2b] - test: pipe some error output if npm fails (Jeremiah Senkpiel) #12490
  • [f1284d32a5] - test: simplify test-tls-client-default-ciphers (Jon Moss) #14928
  • [d4c2eba376] - test: remove unused function args (Mohd Maqbool Alam) #14971
  • [9c7f27b91b] - test: extend async addon test (Anna Henningsen) #14922
  • [8c927dd71f] - test: fix async-hooks tests (Bartosz Sosnowski) #14865
  • [1849c519ca] - test: add test-benchmark-process (Rich Trott) #14951
  • [b480b20e02] - test: add test-benchmark-path (Rich Trott) #14951
  • [2e3e136519] - test: add test-benchmark-os (Rich Trott) #14951
  • [7e541d6a97] - test: add test-benchmark-events (Rich Trott) #14951
  • [981ef464e2] - test: add test-benchmark-domain (Rich Trott) #14951
  • [34d1a779b1] - test: add known issue for vm module (Franziska Hinkelmann) #14661
  • [ae27cb8ea3] - test: do not modify fixtures in test-fs-chmod (Rich Trott) #14926
  • [eb46609622] - test: improve assertion fail messages (Refael Ackermann) #14949
  • [36b8b46443] - test: remove unused parameters (Daniil Shakir) #14968
  • [6421a9cb9a] - test: remove unused arguments from function (Ankit Parashar) #14931
  • [e244f8433e] - test: update windows module load error message (cjihrig) #14950
  • [8f61bf2cda] - test: increase coverage for http2.connect (Michael Albert) #14832
  • [c0312dc781] - test: make timers-blocking-callback more reliable (Rich Trott) #14831
  • [762155578a] - test: remove erroneous assert message from test (Beth Griggs) #14918
  • [1217b1a556] - test: add test for cluster benchmarks (Rich Trott) #14812
  • [03fd38c1bb] - test: Mark test-stop-profile-after-done flaky (Eugene Ostroukhov)
  • [4f49ae52f8] - test: check util.inspect circular Set and Map refs (Ruben Bridgewater) #14790
  • [4dd095c982] - test: refactor async-hooks/test-httparser tests (Runite618) #14818
  • [27ec693a53] - test: add missing console.error to exec-maxBuffer (Beth Griggs) #14796
  • [7f02c36c4f] - test: fix test-cluster-send-handle-large-payload (Rich Trott) #14780
  • [4205648216] - test: invoke callback with common.mustCall() (Griffith Tchenpan) #8597
  • [a3feb54c7f] - test: make test-tls-alert-handling more strict (Rich Trott) #14650
  • [d4f2a52953] - test: check crypto before requiring tls module (Daniel Bevenius) #14708
  • [868b441f3e] - test: begin normalizing fixtures use (James M Snell) #14332
  • [c76ec7130e] - test: improve multiple zlib tests (James M Snell) #14455
  • [8fb0895176] - test: improve multiple vm tests (James M Snell) #14458
  • [4d6da3f770] - test, win: fix IPv6 detection on Windows (Bartosz Sosnowski) #14865
  • [02260eab98] - test,doc: make module name match gyp target name (Gabriel Schulhof) #15209
  • [dae86e4cf5] - timers: fix outdated comment (Tim Costa) #14314
  • [d6ad9d72f7] - (SEMVER-MINOR) tls: multiple PFX in createSecureContext (Yury Popov) #14793
  • [97908ea4d0] - tools: bump vswhere helper to 2.0.0 (Refael Ackermann) #14557
  • [87e44d8651] - tools: add eslint rule for inspector checking (Daniel Bevenius) #13813
  • [1d97ff4800] - tools: add eslint rule for hasCrypto checking (Daniel Bevenius) #13813
  • [bc250a1e38] - tools: fix linter error in html.js (Michaël Zasso) #15063
  • [5ee4e86efc] - tools: add custom private key option (Ruslan Bekenev) #14401
  • [8f34b834b7] - tools: update GYP to 324dd166 (Refael Ackermann) #14718
  • [e4ea45412e] - tools: remove stray package-lock.json file (Rich Trott) #14873
  • [37c43ede43] - tools: fix update-eslint.sh (Myles Borins) #14850
  • [b0f4539ce5] - tools: delete an unused argument (phisixersai) #14251
  • [9da6c1056c] - tools: checkout for unassigned DEP00XX codes (James M Snell) #14702
  • [bd40cc6ef8] - tracing: Update to use new Platform tracing apis (Matt Loring) #14001
  • [a4fc43202e] - url: remove unused code from autoEscapeStr (Cyril Lakech) #15086
  • [2aec977fa2] - util: remove duplicate code in format (Anatoli Papirovski) #15098
  • [de10c0f515] - util: fix inspect array w. negative maxArrayLength (Ruben Bridgewater) #14880
  • [c3c6cb1c13] - util: use proper circular reference checking (Anna Henningsen) #14790

MylesBorins and others added 12 commits September 10, 2017 01:26
When 5d5e31c was backported to v8.x as e2b306c it was missing the
configure changes from 8dce05f. This patch actually re-enables
snapshots!

Fixes: #14870

PR-URL: #14875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
PR-URL: #14458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #14455
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Adds a new `../common/fixtures' module to begin normalizing
`test/fixtures` use. Our test code is a bit inconsistent with
regards to use of the fixtures directory. Some code uses
`path.join()`, some code uses string concats, some other
code uses template strings, etc. In mnay cases, significant
duplication of code is seen when accessing fixture files, etc.

This updates many (but by no means all) of the tests in the
test suite to use the new consistent API. There are still
many more to update, which would make an excelent Code-n-Learn
exercise.

PR-URL: #14332
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
test-tls-session-cache currently fails if built --without-ssl:
internal/util.js:82
    throw new errors.Error('ERR_NO_CRYPTO');
    ^

Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto
support
    at Object.assertCrypto (internal/util.js:82:11)
    at tls.js:26:14
    at NativeModule.compile (bootstrap_node.js:586:7)
    at Function.NativeModule.require (bootstrap_node.js:531:18)
    at Function.Module._load (module.js:449:25)
    at Module.require (module.js:517:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous>
(/node/test/parallel/test-tls-session-cache.js:26:13)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)

The test has a crypto check but it come after the require of the tls
module.

This commit moves the crypto check to come before the require of tls and
allows the test to pass.

PR-URL: #14708
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Use `common.mustCall()` and `common.mustNotCall()` to more rigorously
check that functions (especially no-op error handlers) are called the
expected number of times in test-tls-alert-handling.

PR-URL: #14650
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
* invoke callback with `common.mustCall()` in test-crypto-hash
* order module declarations aphabetically per test-writing-guide

PR-URL: #8597
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This patch adds support for CIDR notation to the output of the
`networkInterfaces()` method

PR-URL: #14307
Fixes: #14006
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
On macOS, the parent process might not receive a message if it
is sent to soon, and then subsequent messages are also sometimes not
received.

(Is this a bug or expected operating system behavior like the
way a file watcher is returned before it's actually watching the file
system on/ macOS?)

Send a second message after a delay on macOS.

While at it, minor refactoring to the test:

* Blank line after loading `common` module per test-writing guide
* Wrap arrow function in braces where implicit return is not needed
* Remove unnecessary unref in subprocess

PR-URL: #14780
Fixes: #14747
Reviewed-By: Anna Henningsen <anna@addaleax.net>
The global `process` object had its prototype replaced with a
fresh object that had `EventEmitter.prototype` as its prototype.
With this change, the original `process.constructor.prototype` is
modified to have `EventEmitter.prototype` as its prototype, reflecting
that `process` objects are also `EventEmitter`s.

Fixes: #14699
PR-URL: #14715
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Check for `DEP00XX` codes on release build like we do with `REPLACEME`

PR-URL: #14702
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Adds the missing console.error to test-child-process-exec-maxBuffer

PR-URL: #14796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v8.x labels Sep 10, 2017
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Sep 10, 2017

@mscdex mscdex removed build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. tools Issues and PRs related to the tools directory. labels Sep 10, 2017
@MylesBorins
Copy link
Contributor Author

@nodejs/platform-windows
anyone know why the things are all breaking?
https://ci.nodejs.org/job/node-test-binary-windows/11017/

MylesBorins added a commit that referenced this pull request Sep 10, 2017
Notable Changes

* Snapshots are back on
* Modules Modules Modules
* More Coming Soon

PR-URL: #15308
@MylesBorins
Copy link
Contributor Author

When ESM support was added it created a regression in the test runner
that broke the ability to run individual tests. This commit
re-introduces the use of `NormalizePath` which fixes the regression
in the test runner

Refs: #15300
PR-URL: #15329
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins added a commit that referenced this pull request Sep 12, 2017
Notable Changes

* Snapshots are back on
* Modules Modules Modules
* More Coming Soon

PR-URL: #15308
@MylesBorins
Copy link
Contributor Author

One more citgm run against 8.4.0 for comparison

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/979/

@MylesBorins
Copy link
Contributor Author

I've updated the changelog and am signing off on the tests. Kicking off build now

Notable Changes

* build:
  * Snapshots are now re-enabled in V8
  #14875

* console:
  * Implement minimal `console.group()`.
  #14910

* deps:
  * upgrade libuv to 1.14.1
    #14866
  * update nghttp2 to v1.25.0
    #14955

* dns:
  * Add `verbatim` option to dns.lookup(). When true, results from the
    DNS resolver are passed on as-is, without the reshuffling that
    Node.js otherwise does that puts IPv4 addresses before IPv6
    addresses.
    #14731

* fs:
  * add fs.copyFile and fs.copyFileSync which allows for more efficient
    copying of files.
    #15034

* inspector:
  * Enable async stack traces
    #13870

* module:
  * Add support for ESM. This is currently behind the
    `--experimental-modules` flag and requires the .mjs extension.
    `node --experimental-modules index.mjs`
    #14369

* napi:
  * implement promise
    #14365

* os:
  * Add support for CIDR notation to the output of the
    networkInterfaces() method.
    #14307

* perf_hooks:
  * An initial implementation of the Performance Timing API for
    Node.js. This is the same Performance Timing API implemented by
    modern browsers with a number of Node.js specific properties. The
    User Timing mark() and measure() APIs are implemented, as is a
    Node.js specific flavor of the Frame Timing for measuring event
    loop duration.
    #14680

* tls:
  * multiple PFX in createSecureContext
    [#14793](#14793)

* Added new collaborators:
  * BridgeAR – Ruben Bridgewater

PR-URL: #15308
@jasnell
Copy link
Member

jasnell commented Sep 12, 2017

In the changelog under notable entries re: perf_hooks, the part 'as is a Node.js specific flavor of the Frame Timing for measuring event loop duration.' ... needs to be removed.

@MylesBorins MylesBorins merged commit a2a2ff4 into v8.x Sep 12, 2017
MylesBorins added a commit that referenced this pull request Sep 12, 2017
MylesBorins added a commit that referenced this pull request Sep 12, 2017
Notable Changes

* build:
  * Snapshots are now re-enabled in V8
  #14875

* console:
  * Implement minimal `console.group()`.
  #14910

* deps:
  * upgrade libuv to 1.14.1
    #14866
  * update nghttp2 to v1.25.0
    #14955

* dns:
  * Add `verbatim` option to dns.lookup(). When true, results from the
    DNS resolver are passed on as-is, without the reshuffling that
    Node.js otherwise does that puts IPv4 addresses before IPv6
    addresses.
    #14731

* fs:
  * add fs.copyFile and fs.copyFileSync which allows for more efficient
    copying of files.
    #15034

* inspector:
  * Enable async stack traces
    #13870

* module:
  * Add support for ESM. This is currently behind the
    `--experimental-modules` flag and requires the .mjs extension.
    `node --experimental-modules index.mjs`
    #14369

* napi:
  * implement promise
    #14365

* os:
  * Add support for CIDR notation to the output of the
    networkInterfaces() method.
    #14307

* perf_hooks:
  * An initial implementation of the Performance Timing API for
    Node.js. This is the same Performance Timing API implemented by
    modern browsers with a number of Node.js specific properties. The
    User Timing mark() and measure() APIs are implemented, as is a
    Node.js specific flavor of the Frame Timing for measuring event
    loop duration.
    #14680

* tls:
  * multiple PFX in createSecureContext
    [#14793](#14793)

* Added new collaborators:
  * BridgeAR – Ruben Bridgewater

PR-URL: #15308
MylesBorins added a commit to nodejs/nodejs.org that referenced this pull request Sep 12, 2017
@gibfahn gibfahn deleted the v8.5.0-proposal branch September 12, 2017 17:10
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
Notable Changes

* build:
  * Snapshots are now re-enabled in V8
  nodejs#14875

* console:
  * Implement minimal `console.group()`.
  nodejs#14910

* deps:
  * upgrade libuv to 1.14.1
    nodejs#14866
  * update nghttp2 to v1.25.0
    nodejs#14955

* dns:
  * Add `verbatim` option to dns.lookup(). When true, results from the
    DNS resolver are passed on as-is, without the reshuffling that
    Node.js otherwise does that puts IPv4 addresses before IPv6
    addresses.
    nodejs#14731

* fs:
  * add fs.copyFile and fs.copyFileSync which allows for more efficient
    copying of files.
    nodejs#15034

* inspector:
  * Enable async stack traces
    nodejs#13870

* module:
  * Add support for ESM. This is currently behind the
    `--experimental-modules` flag and requires the .mjs extension.
    `node --experimental-modules index.mjs`
    nodejs#14369

* napi:
  * implement promise
    nodejs#14365

* os:
  * Add support for CIDR notation to the output of the
    networkInterfaces() method.
    nodejs#14307

* perf_hooks:
  * An initial implementation of the Performance Timing API for
    Node.js. This is the same Performance Timing API implemented by
    modern browsers with a number of Node.js specific properties. The
    User Timing mark() and measure() APIs are implemented, as is a
    Node.js specific flavor of the Frame Timing for measuring event
    loop duration.
    nodejs#14680

* tls:
  * multiple PFX in createSecureContext
    [nodejs#14793](nodejs#14793)

* Added new collaborators:
  * BridgeAR – Ruben Bridgewater

PR-URL: nodejs#15308
MylesBorins added a commit to MylesBorins/node that referenced this pull request Sep 13, 2017
The original changelog included incorrect information regarding
the new perf_hooks api.

refs: nodejs#15308 (comment)
MylesBorins added a commit that referenced this pull request Sep 14, 2017
The original changelog included incorrect information regarding
the new perf_hooks api.

refs: #15308 (comment)

PR-URL: #15384
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Sep 14, 2017
The original changelog included incorrect information regarding
the new perf_hooks api.

refs: #15308 (comment)

PR-URL: #15384
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 17, 2017
The original changelog included incorrect information regarding
the new perf_hooks api.

refs: nodejs/node#15308 (comment)

PR-URL: nodejs/node#15384
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
The original changelog included incorrect information regarding
the new perf_hooks api.

refs: nodejs/node#15308 (comment)

PR-URL: nodejs/node#15384
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.