doc: clarify async/asynchronous in deprecations.md #15172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change _async_ to _asynchronous_ in `deprecations.md` to avoid confusion with the `async` keyword. This has the additional minor benefit of being more formal and less conversational prose.
TimothyGu
approved these changes
Sep 4, 2017
targos
approved these changes
Sep 4, 2017
vsemozhetbyt
approved these changes
Sep 4, 2017
hiroppy
approved these changes
Sep 4, 2017
benjamingr
approved these changes
Sep 4, 2017
lpinca
approved these changes
Sep 4, 2017
cjihrig
approved these changes
Sep 4, 2017
jasnell
approved these changes
Sep 5, 2017
jasnell
pushed a commit
that referenced
this pull request
Sep 5, 2017
Change _async_ to _asynchronous_ in `deprecations.md` to avoid confusion with the `async` keyword. This has the additional minor benefit of being more formal and less conversational prose. PR-URL: #15172 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in a25c754 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Change _async_ to _asynchronous_ in `deprecations.md` to avoid confusion with the `async` keyword. This has the additional minor benefit of being more formal and less conversational prose. PR-URL: #15172 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 11, 2017
Change _async_ to _asynchronous_ in `deprecations.md` to avoid confusion with the `async` keyword. This has the additional minor benefit of being more formal and less conversational prose. PR-URL: #15172 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Change _async_ to _asynchronous_ in `deprecations.md` to avoid confusion with the `async` keyword. This has the additional minor benefit of being more formal and less conversational prose. PR-URL: #15172 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
Change _async_ to _asynchronous_ in `deprecations.md` to avoid confusion with the `async` keyword. This has the additional minor benefit of being more formal and less conversational prose. PR-URL: nodejs#15172 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change async to asynchronous in
deprecations.mdto avoid confusionwith the
asynckeyword. This has the additional minor benefit of beingmore formal and less conversational prose.
Checklist
Affected core subsystem(s)
doc