docs: changed example in streams for write() after end() #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there's an example using http.ServerResponse stream, which has a known bug and will not throw an error while writing after end(). Changed to a writable stream from fs which behaves as expected. fixes nodejs/node-v0.x-archive#8814
|
👍 from me |
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 14, 2014
Currently there's an example using http.ServerResponse stream, which has a known bug and will not throw an error while writing after end(). Changed to a writable stream from fs which behaves as expected. Fixes nodejs/node-v0.x-archive#8814. PR-URL: #155 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brendan Ashworth <squirrelslikeacorns@gmail.com>
|
Cheers Alejandro, landed in 524882f with @brendanashworth as co-reviewer. Heads up, I had to tweak the commit log a little to make it conform to the style guide. |
|
awesome! thanks @bnoordhuis and @brendanashworth |
kunalspathak
referenced
this pull request
in nodejs/node-chakracore
Jan 22, 2016
If `--debug` is specified, the in-built 'Debug' object is exposed by chakra.dll that has some [APIs](https://msdn.microsoft.com/en-us/library/bs12a9wf(v=vs.94).aspx) that node-uwp relies on. With my change in #155, I had overriden 'Debug' global object and hence certain Debug APIs stopped working with `--debug` switch. The original intent of adding `Debug` object was that `util.js` fetches this object in Debugging context. In absense of `--debug` flag this object is unavailable and hence `util.js` throws TypeError. The fix is to expose `Debug` object only in the DebugContext (called from `util.js`). If ran with `--debug`, by the time `utill.js` code executes, engine would have already expose in-built `Debug` object and we won't overwrite it. Without `--debug` we would override `Debug` object. Thanks @agarwal-sandeep for helping debugging this issue. Fixes : #175
boingoing
pushed a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
napi: add finalize hint support Change napi_finalize_callback to support a hint parameter APIs that take in a finalize callback now also take a hint This hint is passed back in when the finalize callback is called Fixes: nodejs#111 Reviewed-By: @jasongin @boingoing @mhdawson PR-Url: nodejs/abi-stable-node#155
This was referenced Jan 31, 2020
This was referenced Sep 28, 2021
This was referenced Nov 30, 2023
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Dec 5, 2023
…dejs#155) The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
May 28, 2024
…dejs#155) The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
syg
pushed a commit
to syg/node
that referenced
this pull request
Jun 20, 2024
…dejs#155) The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever. # Conflicts: # test/parallel/parallel.status
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Aug 28, 2024
…dejs#155) The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever. # Conflicts: # test/parallel/parallel.status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's an example using http.ServerResponse stream, which
has a known bug and will not throw an error while writing after end().
Changed to a writable stream from fs which behaves as expected.
fixes nodejs/node-v0.x-archive#8814