test: fix flaky test-crypto-classes.js #15662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024. This should be quite a bit faster, and therefore prevent the timeouts. Fixes: nodejs#15655
refack
approved these changes
Sep 28, 2017
BridgeAR
approved these changes
Sep 28, 2017
lpinca
approved these changes
Sep 29, 2017
jasnell
approved these changes
Sep 29, 2017
|
Looks like CI didn't run on Raspberry Pi, and that's where this fix matters, so here's another CI: https://ci.nodejs.org/job/node-test-pull-request/10342/ |
|
CI is green for Raspberry Pi devices. Other failures in CI are unrelated. Anyone besides me OK with an expedited landing? |
Trott
approved these changes
Sep 29, 2017
jasnell
pushed a commit
that referenced
this pull request
Oct 1, 2017
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024. This should be quite a bit faster, and therefore prevent the timeouts. PR-URL: #15662 Fixes: #15655 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 3e4f34c |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024. This should be quite a bit faster, and therefore prevent the timeouts. PR-URL: nodejs/node#15662 Fixes: nodejs/node#15655 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
This will need to be backported with #8188 |
bengl
added a commit
to bengl/node
that referenced
this pull request
Oct 17, 2017
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024. This should be quite a bit faster, and therefore prevent the timeouts. PR-URL: nodejs#15662 Fixes: nodejs#15655 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Oct 23, 2017
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024. This should be quite a bit faster, and therefore prevent the timeouts. Backport-PR-URL: #16245 PR-URL: #15662 Fixes: #15655 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
added
baking-for-lts
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2018
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024. This should be quite a bit faster, and therefore prevent the timeouts. Backport-PR-URL: #16245 PR-URL: #15662 Fixes: #15655 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 17, 2018
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024. This should be quite a bit faster, and therefore prevent the timeouts. Backport-PR-URL: #16245 PR-URL: #15662 Fixes: #15655 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024. This should be quite a bit faster, and therefore prevent the timeouts. Backport-PR-URL: #16245 PR-URL: #15662 Fixes: #15655 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024. This should be quite a bit faster, and therefore prevent the timeouts. Backport-PR-URL: #16245 PR-URL: #15662 Fixes: #15655 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
removed
the
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.
Fixes: #15655
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test