Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.13.0 proposal #18342

Merged
merged 113 commits into from
Feb 13, 2018
Merged

v6.13.0 proposal #18342

merged 113 commits into from
Feb 13, 2018

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Jan 24, 2018

2018-02-13, Version 6.13.0 'Boron' (LTS), @MylesBorins

This LTS release comes with 112 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related,
31 which are test related, 8 which are build / tool related and 1 commit which updates a dependency.

Notable Changes

  • console:
    • added console.count() and console.clear() (James M Snell) #12678
  • crypto:
    • expose ECDH class (Bryan English) #8188
    • added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) #10209
    • warn on invalid authentication tag length (Tobias Nießen) #17566
  • deps:
    • upgrade libuv to 1.16.1 (cjihrig) #16835
  • dgram:
    • added socket.setMulticastInterface() (Will Young) #7855
  • http:
    • add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of Agent (Fedor Indutny) #13005
  • lib:
    • return this from net.Socket.end() (Sam Roberts) #13481
  • module:
    • add builtinModules api that provides list of all builtin modules in Node (Jon Moss) #16386
  • net:
    • return this from getConnections() (Sam Roberts) #13553
  • promises:
    • more robust stringification for unhandled rejections (Timothy Gu) #13784
  • repl:
    • improve require() autocompletion (Alexey Orlenko) #14409
  • src:
    • add openssl-system-ca-path configure option (Daniel Bevenius) #16790
    • add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) #12087
    • add process.ppid (cjihrig) #16839
  • tls:
    • accept lookup option for tls.connect() (Fedor Indutny) #12839
  • tools, build:
    • a new macOS installer! (JP Wesselink) #15179
  • url:
    • WHATWG URL api support (James M Snell) #7448
  • util:
    • add %i and %f formatting specifiers (Roman Reiss) #10308

Commits

  • [6f33953d90] - benchmark: fix timeout in write-stream-throughput (Anatoli Papirovski) #17958
  • [ce136392fb] - (SEMVER-MINOR) console: add console.count() and console.clear() (James M Snell) #12678
  • [691cd5a3d1] - crypto: warn on invalid authentication tag length (Tobias Nießen) #17566
  • [4b4e4db1c1] - crypto: add ocsp_request ClientHelloParser::Reset (Daniel Bevenius) #17753
  • [c377d2299a] - crypto: remove unused header in clienthello.h (Daniel Bevenius) #17752
  • [ddd9d85681] - crypto: remove BIO_set_shutdown (Daniel Bevenius) #17542
  • [f3b3437e48] - (SEMVER-MINOR) crypto: expose ECDH class (Bryan English) #8188
  • [6f62f83468] - (SEMVER-MINOR) crypto: add randomFill and randomFillSync (Evan Lucas) #10209
  • [a1d7469aef] - (SEMVER-MINOR) deps: upgrade libuv to 1.16.1 (cjihrig) #16835
  • [8f2e52abd7] - (SEMVER-MINOR) dgram: added setMulticastInterface() (Will Young) #7855
  • [1b689863ee] - doc: remove x86 from os.arch() options (Gibson Fahnestock) #17899
  • [8f80548b7f] - doc: move matthewloring to emeriti (Rich Trott) #17998
  • [15d0ed5f33] - doc: move joshgav to TSC emeriti list (Rich Trott) #17953
  • [12db4d97b2] - doc: improve security section of README.md (Rich Trott) #17929
  • [b79189b9b6] - doc: copy-edit COLLABORATOR_GUIDE.md (Rich Trott) #17922
  • [7628640db6] - doc: improve alt text (Rich Trott) #17922
  • [bb022dbb96] - doc: fix spelling of contributors (Rich Trott) #17922
  • [21c5d820bb] - doc: add references to PR communication articles (Salame William) #17902
  • [3c3a631643] - doc: fix typo (Tobias Nießen) #17900
  • [5b00ee31ee] - doc: use my legal name in README (Timothy Gu) #17894
  • [0ce48f9094] - doc: use dashes instead of asterisks (Ruben Bridgewater) #17722
  • [f6b4aa62bc] - doc: update AUTHORS list (Ruben Bridgewater) #17805
  • [653c026578] - doc: add starkwang to collaborators (Weijia Wang) #17847
  • [68164145de] - doc: improve fs api descriptions (Evan Lucas) #17679
  • [722640f562] - doc: instructions on how to make membership public (Michael Dawson) #17688
  • [1553c7326c] - doc: removed extra explanation in api/buffer.md (Waleed Ashraf) #17796
  • [22607951b8] - doc: use american spelling as per style guide (sreepurnajasti) #17818
  • [d85840dd8f] - doc: require CI status indicator in PRs (Nikolai Vavilov) #17151
  • [5cc6dd6295] - doc: remove duplicate the from onboarding.md (sreepurnajasti) #17733
  • [a6f7ba4f09] - doc: fix typo in README.md (Weijia Wang) #17729
  • [df48a5ded8] - doc: fix typo in child_process.md (Rich Trott) #17727
  • [4cba4324ff] - doc: improve release guide (Evan Lucas) #17677
  • [423ef3ddbf] - doc: not all example code can be run without 1:1 (Jeremiah Senkpiel) #17702
  • [c683efbf6d] - doc: adjust TTY wording & add inter-doc links (Jeremiah Senkpiel) #17702
  • [14ffddd989] - doc: add isTTY property documentation (SonaySevik) #16828
  • [9c8d0366b3] - doc: fix fs.existsSync description (Jeremiah Senkpiel) #17702
  • [6abd4599af] - doc: improve documentation.md (Jeremiah Senkpiel) #17702
  • [d0b89a12ec] - doc: add countdown module to writing tests guide (Bamieh) #17201
  • [1eac4055f0] - doc: include Daniel Bevenius as a TSC member (Rich Trott) #17652
  • [83fe79c558] - doc: correct pbkdf2 salt length recommendation (Will Clark) #17524
  • [43a2bc040f] - doc: improve randomfill and fix broken link (Sakthipriyan Vairamani (thefourtheye)) #12541
  • [ef0213c0b8] - doc: move Code of Conduct to admin repo (Myles Borins) #17301
  • [e16d01fc94] - gitignore: ignore *.VC.db files (Tobias Nießen) #17898
  • [1390c280bc] - (SEMVER-MINOR) http: overridable keep-alive behavior of Agent (Fedor Indutny) #13005
  • [063c4fa345] - (SEMVER-MINOR) lib: return this from net.Socket.end() (Sam Roberts) #13481
  • [cdf4a9c394] - (SEMVER-MINOR) module: add builtinModules (Jon Moss) #16386
  • [ffc1444117] - net: remove ADDRCONFIG DNS hint on Windows (Bartosz Sosnowski) #17662
  • [6a27774882] - (SEMVER-MINOR) net: return this from getConnections() (Sam Roberts) #13553
  • [a09e2fd43b] - net: fix timeout with null handle (Anatoli Papirovski) #16489
  • [a301c1a0e0] - net: fix timeouts during long writes (Anatoli Papirovski) #15791
  • [c64a73ba6c] - promises: more robust stringification (Timothy Gu) #13784
  • [3b9fea0782] - (SEMVER-MINOR) repl: improve require() autocompletion (Alexey Orlenko) #14409
  • [9181fbb699] - src: dumb down code by removing std::move (Anna Henningsen) #18324
  • [57865a9213] - src: use correct OOB check for IPv6 parsing (Anna Henningsen) #17470
  • [f306d3eb7a] - src: make url host a proper C++ class (Anna Henningsen) #17470
  • [1976c7c7a5] - src: move url internals into anonymous namespace (Anna Henningsen) #17470
  • [d66f469931] - src: minor cleanups to node_url.cc (Anna Henningsen) #17470
  • [979af518c1] - src: remove nonexistent method from header file (Anna Henningsen) #17748
  • [2268d00e38] - (SEMVER-MINOR) src: add openssl-system-ca-path configure option (Daniel Bevenius) #16790
  • [a6d2384c9a] - src: clean up MaybeStackBuffer (Timothy Gu) #11464
  • [9f3b4ad5bd] - src: fix incorrect macro comment (Daniel Bevenius) #12688
  • [2b29cea1b4] - src: guard bundled_ca/openssl_ca with HAVE_OPENSSL (Daniel Bevenius) #12302
  • [758dc81e8d] - (SEMVER-MAJOR) src: add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) #12087
  • [2d4fca2c41] - (SEMVER-MINOR) src: add process.ppid (cjihrig) #16839
  • [b6ce918e0a] - stream: fix disparity between buffer and the count (jlvivero) #15661
  • [f82065fbe1] - test: make test-cli-syntax engine agnostic (Rich Trott) #16272
  • [a4e2ced73b] - test: decrease duration of test-cli-syntax (Evan Lucas) #14187
  • [734ce678f4] - test: use valid authentication tag length (Tobias Nießen) #17566
  • [694828df0e] - test: mark test-inspector-stop-profile-after-done flaky (Myles Borins) #18491
  • [5668403ddb] - test: improve flaky test-listen-fd-ebadf.js (Rich Trott) #17797
  • [fce10f722d] - test: fix test-tls-server-verify.js on Windows CI (Rich Trott) #18382
  • [4473c6c807] - test: fix flaky test-http-pipeline-flood (Anatoli Papirovski) #17955
  • [001b67296e] - test: rename regression tests (Tobias Nießen) #17948
  • [0c3f23ef59] - test: fix flaky test-pipe-unref (Anatoli Papirovski) #17950
  • [9e760285de] - test: fix crypto test case to use correct encoding (Tobias Nießen) #17956
  • [1c4aa61388] - test: simplify test-buffer-slice.js (Weijia Wang) #17962
  • [2c554a9d2b] - test: improve to use template string (sreepurnajasti) #17895
  • [8c1f41fc11] - test: make test-tls-invoke-queued use public API (Anna Henningsen) #17864
  • [b3e625d67a] - test: refactor test-tls-securepair-fiftharg (Anna Henningsen) #17836
  • [038e52627f] - test: remove undefined function (Rich Trott) #17845
  • [5314754685] - test: use common module API in test-child-process-exec-stdout-stderr-data-string (sreepurnajasti) #17751
  • [f291bc1d98] - test: refactor test-repl-definecommand (Rich Trott) #17795
  • [cb7854354f] - test: change callback function to arrow function (rt33) #17734
  • [bdb535c731] - test: Use countdown in test file (sreepurnajasti) #17646
  • [31c5db6c03] - test: update test-http-content-length to use countdown (Bamieh) #17201
  • [cc03470b82] - test: change callback function to arrow function (routerman) #17697
  • [81e6569990] - test: change callback function to arrow function (you12724) #17698
  • [2d77241f33] - test: change callback function to arrow function (Shinya Kanamaru) #17699
  • [af3e074249] - (SEMVER-MINOR) test: add makeDuplexPair() helper (Anna Henningsen) #16269
  • [fb0bd8a584] - test: fix flaky test-child-process-pass-fd (Rich Trott) #17598
  • [b3b245665e] - test: add test description to fs.readFile tests (Jamie Davis) #17610
  • [5f7944842a] - test: fix truncation of argv (Daniel Bevenius) #12110
  • [699c6638c3] - test: add common.hasIntl (James M Snell) #9246
  • [365dba2195] - test: fix flaky test-crypto-classes.js (Bryan English) #15662
  • [d29a6202e7] - (SEMVER-MINOR) test: crypto createClass instanceof Class (Bryan English) #8188
  • [7b801b5f83] - test: don't skip when common.mustCall() is pending (cjihrig) #15421
  • [4f6dd9649f] - test,doc: do not indicate that non-functions "return" values (Rich Trott) #17267
  • [a08925dcbd] - tls: comment about old-style errors (xortiz) #17759
  • [56e1586608] - tls: unconsume stream on destroy (Anna Henningsen) #17478
  • [00b279087e] - (SEMVER-MINOR) tls: accept lookup option for tls.connect() (Fedor Indutny) #12839
  • [521dc2511f] - tls: properly track writeQueueSize during writes (Anatoli Papirovski) #15791
  • [51bfd32922] - tools: do not override V8's gitignore (Yang Guo) #18010
  • [32f528a92e] - tools: fix AttributeError: exit on Python 2.6 (Dmitriy Kasyanov) #17663
  • [6187aec242] - tools: autofixer for lowercase-name-for-primitive (Shobhit Chittora) #17715
  • [928b7c87cd] - tools: simplify lowercase-name-for-primitive rule (cjihrig) #17653
  • [7821a4c899] - tools: add lowercase-name-for-primitive eslint rule (Weijia Wang) #17568
  • [1d706026a7] - tools: make doc tool a bit more readable (Tobias Nießen) #17125
  • [b8a5d6dbbc] - tools: remove useless function declaration (Tobias Nießen) #17125
  • [18803bc409] - (SEMVER-MINOR) tools, build: refactor macOS installer (JP Wesselink) #15179
  • [24def19417] - (SEMVER-MINOR) url: adding WHATWG URL support (James M Snell) #7448
  • [60b10f0896] - url: update IDNA handling (Timothy Gu) #13362
  • [7af1ad0ec1] - (SEMVER-MINOR) util: add %i and %f formatting specifiers (Roman Reiss) #10308

Trott and others added 10 commits January 2, 2018 14:06
Update documentation for test `common` module so that properties that
are not functions do not specify a return type and functions that do
return values specify the type.

PR-URL: #17267
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Backport-PR-URL: #17788
PR-URL: #17125
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: #17788
PR-URL: #17125
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
The CoC and moderation guidelines now live in the Admin repo.

This PR updates the copy of CODE_OF_CONDUCT.md and references in
other documents to the proper location.

PR-URL: #17301
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This changes the disparity of bufferedRequestCount and the actual buffer
on file _stream_writable.js

PR-URL: #15661
Fixes: #6758
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Make writeQueueSize represent the actual size of the write queue
within the TLS socket. Add tls test to confirm that bufferSize
works as expected.

Backport-PR-URL: #16420
PR-URL: #15791
Fixes: #15005
Refs: #15006
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Add updateWriteQueueSize which updates and returns queue size
(net & tls). Make _onTimeout check whether an active write
is ongoing and if so, call _unrefTimer rather than emitting
a timeout event.

Add http & https test that checks whether long-lasting (but
active) writes timeout or can finish writing as expected.

Backport-PR-URL: #16420
PR-URL: #15791
Fixes: #15082
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
This commit handles the case where _onTimeout is called with a
null handle.

Backport-PR-URL: #16420
Refs: #15791
Fixes: #16484
PR-URL: #16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
`net.connect()` and consequently `http.Agent` support custom DNS
`lookup` option. However, as we move to `https.Agent` - this option no
longer works because it is not proxied by `tls.connect`.

Fix this inconsistency by passing it down to `net.connect`.

PR-URL: #12839
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This change brings formatting specifiers available in `util.format` and
consequently, `console.*` closer to what is supported in all major
browsers.

- `%i` is introduced to format integer values.
- `%f` is introduced to format floating point values.

Fixes: #10292
PR-URL: #10308
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project. v6.x labels Jan 24, 2018
MylesBorins added a commit that referenced this pull request Jan 24, 2018
Notable Changes:

Coming Soon

PR-URL: #18342
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Jan 24, 2018

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Jan 24, 2018

arm odroid failure is expected

windows failure seems to be a known flake

  ...
not ok 293 parallel/test-tls-server-verify
  ---
  duration_ms: 60.243
  severity: fail
  stack: |-
    timeout
  ...

here's a run on v6.12.3 to compare https://ci.nodejs.org/job/node-test-commit/15656/

@MylesBorins
Copy link
Contributor Author

/cc @nodejs/platform-aix tons of failures due to npm, can someone take a look?

@richardlau
Copy link
Member

Maybe related to nodejs/build#1090?

@richardlau
Copy link
Member

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1225/nodes=aix61-ppc64/consoleFull

warn:                     | npm ERR! code ENOSPC                                               
warn:                     | npm ERR! errno -28                                                 
warn:                     | npm ERR! syscall write                                             
warn:                     |
warn:                     | npm ERR! nospc ENOSPC: no space left on device, write              
warn:                     | npm ERR! nospc This is most likely not a problem with npm itself   
warn:                     | npm ERR! nospc and is related to insufficient space on your system.

cc @nodejs/build

@gibfahn
Copy link
Member

gibfahn commented Jan 24, 2018

Looks like the machine was restarted so the ramdisk has dropped on be-2. I'll fix it.

EDIT: Should be fixed now.

@MylesBorins
Copy link
Contributor Author

I'm seeing the windows failure on v6.12.3, which leads me to believe the test is now flakey in build

not ok 290 parallel/test-tls-server-verify
  ---
  duration_ms: 60.284
  severity: fail
  stack: |-
    timeout

/cc @nodejs/build @nodejs/platform-windows

@MylesBorins
Copy link
Contributor Author

MylesBorins added a commit that referenced this pull request Feb 7, 2018
Notable Changes:

Coming Soon

PR-URL: #18342
@MylesBorins
Copy link
Contributor Author

gibfahn and others added 11 commits February 12, 2018 19:28
It is not possible for `process.arch` (which comes from V8's
`target_arch`) to be `x86`.

Also updates `process.arch` to have the same information.

PR-URL: #17899
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
- Remove pointless pointers
- Make `WriteHost` take a const argument so that it’s functionality
  is clear from the signature
- Make `FindLongestZeroSequence` templated to accommodate the constness
  in `WriteHost` and because using `uint16_t` is an articifial,
  unnecessary restriction
- Remove string copying when no copies are needed
- Make `PercentDecode` just return its return value
- Make `ParseHost` (string-only version) take its constant argument
  as a constant reference

Backport-PR-URL: #18324
PR-URL: #17470
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
This helps because `static` doesn’t work for C++ classes,
but refactoring `url_host` into a proper C++ class seems the
most reasonable soluation for the memory leak fixed by the next commit.

Backport-PR-URL: #18324
PR-URL: #17470
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
- Gives `URLHost` a proper destructor that clears memory
  depending on the type of the host (This fixes a memory leak)
- Hide the host type enums and class layout as implementation details
- Make the `Parse` methods members of `URLHost`
- Turn `WriteHost` into a `ToString()` method on the `URLHost` class
- Verify that at the beginning of a parse attempt, the type is set
  to “failed”
- Remove a lot of `goto`s from the source code 🐢🚀

Backport-PR-URL: #18324
PR-URL: #17470
Fixes: #17448
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
`last_piece` pointed to the end of the 8×16 bit array,
so `piece_pointer == last_piece` already means that the pointer
is not writable any longer.

Previously, this still worked most of the time but could
result in an out-of-bounds-write.

Also, rename `last_piece` to `buffer_end` to avoid this pitfall.

Backport-PR-URL: #18324
PR-URL: #17470
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
This would require C++11 features that would
otherwise not be available on clang + OS X on Node 6.x.

PR-URL: #18324
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Find an invalid file descriptor rather than assuming 42 will be invalid.

PR-URL: #17797
Fixes: #17762
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Using authentication tags of invalid length does not conform to NIST
standards.

Backport-PR-URL: #18347
PR-URL: #17566
Refs: #17523
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: #18347
PR-URL: #17566
Refs: #17523
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 13, 2018
This LTS release comes with 109 commits, 17 of which are considered
Semver-Minor. This includes 32 which are doc related, 29 which are test
related, 8 which are build / tool related and 1 commit which updates
a dependency.

Notable Changes:

* console:
  - added console.count() and console.clear() (James M Snell)
    #12678
* crypto:
  - expose ECDH class (Bryan English)
    #8188
  - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas)
    #10209
  - warn on invalid authentication tag length (Tobias Nießen)
    #17566
* deps:
  - upgrade libuv to 1.16.1 (cjihrig)
    #16835
* dgram:
  - added socket.setMulticastInterface() (Will Young)
    #7855
* http:
  - add agent.keepSocketAlive and agent.reuseSocket as to allow
    overridable keep-alive behavior of `Agent` (Fedor Indutny)
    #13005
* lib:
  - return this from net.Socket.end() (Sam Roberts)
    #13481
* module:
  - add builtinModules api that provides list of all builtin modules in
    Node (Jon Moss)
    #16386
* net:
  - return this from getConnections() (Sam Roberts)
    #13553
* promises:
  - more robust stringification for unhandled rejections (Timothy Gu)
    #13784
* repl:
  - improve require() autocompletion (Alexey Orlenko)
    #14409
* src:
  - add openssl-system-ca-path configure option (Daniel Bevenius)
    #16790
  - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius)
    #12087
  - add process.ppid (cjihrig)
    #16839
* tls:
  - accept `lookup` option for `tls.connect()` (Fedor Indutny)
    #12839
* tools, build:
  - a new macOS installer! (JP Wesselink)
    #15179
* url:
  - WHATWG URL api support (James M Snell)
    #7448
* util:
  - add %i and %f formatting specifiers (Roman Reiss)
    #10308

PR-URL: #18342
@MylesBorins
Copy link
Contributor Author

OK! I think I found a fix to the jQuery failure (which was a failure in a dependencies polyfill of Symbol fwiw)

CI: https://ci.nodejs.org/job/node-test-pull-request/13130/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1284/
r.c.4: https://nodejs.org/download/rc/v6.13.0-rc.4/

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Feb 13, 2018

Landed potential fixes for AIX failures (test only changes)

https://ci.nodejs.org/job/node-test-pull-request/13135/

evanlucas and others added 3 commits February 13, 2018 02:00
Previously, test/parallel/test-cli-syntax.js was spawning a lot of child
processes, but using spawnSync, which made the test run each child
process serially. This switches most of the test cases to use exec so
that they are asynchronous. Locally, the test went from > 5 seconds to
under 2 seconds.

PR-URL: #14187
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Do not check the error message if it is generated by the JavaScript
engine (V8, ChakraCore, etc.). Do confirm that it is a `SyntaxError`.

PR-URL: #16272
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This LTS release comes with 112 commits, 17 of which are considered
Semver-Minor. This includes 32 which are doc related, 30 which are test
related, 8 which are build / tool related and 1 commit which updates
a dependency.

Notable Changes:

* console:
  - added console.count() and console.clear() (James M Snell)
    #12678
* crypto:
  - expose ECDH class (Bryan English)
    #8188
  - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas)
    #10209
  - warn on invalid authentication tag length (Tobias Nießen)
    #17566
* deps:
  - upgrade libuv to 1.16.1 (cjihrig)
    #16835
* dgram:
  - added socket.setMulticastInterface() (Will Young)
    #7855
* http:
  - add agent.keepSocketAlive and agent.reuseSocket as to allow
    overridable keep-alive behavior of `Agent` (Fedor Indutny)
    #13005
* lib:
  - return this from net.Socket.end() (Sam Roberts)
    #13481
* module:
  - add builtinModules api that provides list of all builtin modules in
    Node (Jon Moss)
    #16386
* net:
  - return this from getConnections() (Sam Roberts)
    #13553
* promises:
  - more robust stringification for unhandled rejections (Timothy Gu)
    #13784
* repl:
  - improve require() autocompletion (Alexey Orlenko)
    #14409
* src:
  - add openssl-system-ca-path configure option (Daniel Bevenius)
    #16790
  - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius)
    #12087
  - add process.ppid (cjihrig)
    #16839
* tls:
  - accept `lookup` option for `tls.connect()` (Fedor Indutny)
    #12839
* tools, build:
  - a new macOS installer! (JP Wesselink)
    #15179
* url:
  - WHATWG URL api support (James M Snell)
    #7448
* util:
  - add %i and %f formatting specifiers (Roman Reiss)
    #10308

PR-URL: #18342
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Feb 13, 2018

@MylesBorins MylesBorins merged commit 9441526 into v6.x Feb 13, 2018
MylesBorins added a commit that referenced this pull request Feb 13, 2018
MylesBorins added a commit that referenced this pull request Feb 13, 2018
This LTS release comes with 112 commits, 17 of which are considered
Semver-Minor. This includes 32 which are doc related, 30 which are test
related, 8 which are build / tool related and 1 commit which updates
a dependency.

Notable Changes:

* console:
  - added console.count() and console.clear() (James M Snell)
    #12678
* crypto:
  - expose ECDH class (Bryan English)
    #8188
  - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas)
    #10209
  - warn on invalid authentication tag length (Tobias Nießen)
    #17566
* deps:
  - upgrade libuv to 1.16.1 (cjihrig)
    #16835
* dgram:
  - added socket.setMulticastInterface() (Will Young)
    #7855
* http:
  - add agent.keepSocketAlive and agent.reuseSocket as to allow
    overridable keep-alive behavior of `Agent` (Fedor Indutny)
    #13005
* lib:
  - return this from net.Socket.end() (Sam Roberts)
    #13481
* module:
  - add builtinModules api that provides list of all builtin modules in
    Node (Jon Moss)
    #16386
* net:
  - return this from getConnections() (Sam Roberts)
    #13553
* promises:
  - more robust stringification for unhandled rejections (Timothy Gu)
    #13784
* repl:
  - improve require() autocompletion (Alexey Orlenko)
    #14409
* src:
  - add openssl-system-ca-path configure option (Daniel Bevenius)
    #16790
  - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius)
    #12087
  - add process.ppid (cjihrig)
    #16839
* tls:
  - accept `lookup` option for `tls.connect()` (Fedor Indutny)
    #12839
* tools, build:
  - a new macOS installer! (JP Wesselink)
    #15179
* url:
  - WHATWG URL api support (James M Snell)
    #7448
* util:
  - add %i and %f formatting specifiers (Roman Reiss)
    #10308

PR-URL: #18342
@gibfahn gibfahn deleted the v6.13.0-proposal branch February 14, 2018 08:19
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This LTS release comes with 112 commits, 17 of which are considered
Semver-Minor. This includes 32 which are doc related, 30 which are test
related, 8 which are build / tool related and 1 commit which updates
a dependency.

Notable Changes:

* console:
  - added console.count() and console.clear() (James M Snell)
    nodejs#12678
* crypto:
  - expose ECDH class (Bryan English)
    nodejs#8188
  - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas)
    nodejs#10209
  - warn on invalid authentication tag length (Tobias Nießen)
    nodejs#17566
* deps:
  - upgrade libuv to 1.16.1 (cjihrig)
    nodejs#16835
* dgram:
  - added socket.setMulticastInterface() (Will Young)
    nodejs#7855
* http:
  - add agent.keepSocketAlive and agent.reuseSocket as to allow
    overridable keep-alive behavior of `Agent` (Fedor Indutny)
    nodejs#13005
* lib:
  - return this from net.Socket.end() (Sam Roberts)
    nodejs#13481
* module:
  - add builtinModules api that provides list of all builtin modules in
    Node (Jon Moss)
    nodejs#16386
* net:
  - return this from getConnections() (Sam Roberts)
    nodejs#13553
* promises:
  - more robust stringification for unhandled rejections (Timothy Gu)
    nodejs#13784
* repl:
  - improve require() autocompletion (Alexey Orlenko)
    nodejs#14409
* src:
  - add openssl-system-ca-path configure option (Daniel Bevenius)
    nodejs#16790
  - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius)
    nodejs#12087
  - add process.ppid (cjihrig)
    nodejs#16839
* tls:
  - accept `lookup` option for `tls.connect()` (Fedor Indutny)
    nodejs#12839
* tools, build:
  - a new macOS installer! (JP Wesselink)
    nodejs#15179
* url:
  - WHATWG URL api support (James M Snell)
    nodejs#7448
* util:
  - add %i and %f formatting specifiers (Roman Reiss)
    nodejs#10308

PR-URL: nodejs#18342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.