test: fix test for inherited properties on vm #16411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Oct 23, 2017
| assert.deepStrictEqual(Object.keys(sandbox), ['z', 'x']); | ||
|
|
||
| // Check that y is not an own property. | ||
| assert.strictEqual((Object.keys(sandbox)).indexOf('y'), -1); |
There was a problem hiding this comment.
I think we can remove this assert. It's implicitly checked on line 37.
There was a problem hiding this comment.
You're right. Deleted.
Now that most of the vm issues are fixed, we could go through and consolidate all the tests.
fhinkel
force-pushed
the
Oct/inheritedProps
branch
from
5adea63 to
0ee6536
Compare
cjihrig
approved these changes
Oct 23, 2017
The known issue is fixed with nodejs#16293. The text needs to call `Object.hasOwnProperty(this)` instead of `this.hasOwnProperty()`, otherwise `this` is from the wrong context is used. Add a second test case taken verbatim from issue nodejs#5350 Fixes: nodejs#5350 Refs: nodejs#16293
fhinkel
force-pushed
the
Oct/inheritedProps
branch
from
0ee6536 to
76dde73
Compare
fhinkel
added a commit
to fhinkel/node
that referenced
this pull request
Oct 25, 2017
The known issue is fixed with nodejs#16293. The text needs to call `Object.hasOwnProperty(this)` instead of `this.hasOwnProperty()`, otherwise `this` is from the wrong context is used. Add a second test case taken verbatim from issue nodejs#5350 PR-URL: nodejs#16411 Fixes: nodejs#5350 Ref: nodejs#16293 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Thanks, landed as ed116dc |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
The known issue is fixed with nodejs/node#16293. The text needs to call `Object.hasOwnProperty(this)` instead of `this.hasOwnProperty()`, otherwise `this` is from the wrong context is used. Add a second test case taken verbatim from issue nodejs/node#5350 PR-URL: nodejs/node#16411 Fixes: nodejs/node#5350 Ref: nodejs/node#16293 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
The known issue is fixed with #16293. The text needs to call `Object.hasOwnProperty(this)` instead of `this.hasOwnProperty()`, otherwise `this` is from the wrong context is used. Add a second test case taken verbatim from issue #5350 PR-URL: #16411 Fixes: #5350 Ref: #16293 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Marked as dont-land-on as #16293 was, LMK if wrong. |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
The known issue is fixed with nodejs/node#16293. The text needs to call `Object.hasOwnProperty(this)` instead of `this.hasOwnProperty()`, otherwise `this` is from the wrong context is used. Add a second test case taken verbatim from issue nodejs/node#5350 PR-URL: nodejs/node#16411 Fixes: nodejs/node#5350 Ref: nodejs/node#16293 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The known issue is fixed with
#16293.
The text needs to call
Object.hasOwnProperty(this)instead of
this.hasOwnProperty(), otherwisethisisfrom the wrong context is used.
Add a second test case taken verbatim from issue
#5350
Fixes: #5350
Refs: #16293
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test