Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: remove unused header in clienthello.h #17752

Closed
wants to merge 1 commit into from
Closed

crypto: remove unused header in clienthello.h #17752

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Dec 19, 2017

This commit removes stdlib.h header as it does not seem to be used any
more.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

@danbev
crypto: remove unused header in clienthello.h
6e31635 
This commit removes stdlib.h header as it does not seem to be used any
more.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Dec 19, 2017
@danbev
Copy link
Contributor Author

danbev commented Dec 19, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12191/

@addaleax
Copy link
Member

Landed in 85d5885

@addaleax addaleax closed this Dec 19, 2017
addaleax pushed a commit that referenced this pull request Dec 19, 2017
@danbev @addaleax
crypto: remove unused header in clienthello.h
85d5885 
This commit removes stdlib.h header as it does not seem to be used any
more.

PR-URL: #17752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@danbev @MylesBorins
crypto: remove unused header in clienthello.h
cdd6f7b 
This commit removes stdlib.h header as it does not seem to be used any
more.

PR-URL: #17752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@danbev @MylesBorins
crypto: remove unused header in clienthello.h
7d03567 
This commit removes stdlib.h header as it does not seem to be used any
more.

PR-URL: #17752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@danbev @MylesBorins
crypto: remove unused header in clienthello.h
6ce22e4 
This commit removes stdlib.h header as it does not seem to be used any
more.

PR-URL: #17752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@danbev @MylesBorins
crypto: remove unused header in clienthello.h
7fa140f 
This commit removes stdlib.h header as it does not seem to be used any
more.

PR-URL: #17752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@danbev @gibfahn
crypto: remove unused header in clienthello.h
2f3d91d 
This commit removes stdlib.h header as it does not seem to be used any
more.

PR-URL: #17752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@danbev @MylesBorins
crypto: remove unused header in clienthello.h
019c528 
This commit removes stdlib.h header as it does not seem to be used any
more.

PR-URL: #17752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@danbev @MylesBorins
crypto: remove unused header in clienthello.h
bb32161 
This commit removes stdlib.h header as it does not seem to be used any
more.

PR-URL: #17752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@danbev @MylesBorins
crypto: remove unused header in clienthello.h
c377d22 
This commit removes stdlib.h header as it does not seem to be used any
more.

PR-URL: #17752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danbev danbev deleted the crypto_remove_unused_header_clienthello.h branch February 28, 2018 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danbev @addaleax @cjihrig @gireeshpunathil @MylesBorins @nodejs-github-bot