build: always use BUILDTYPE binary to run JS tests #20362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
cc @nodejs/build |
addaleax
approved these changes
Apr 27, 2018
cjihrig
approved these changes
Apr 27, 2018
richardlau
approved these changes
Apr 27, 2018
Trott
reviewed
Apr 28, 2018
|
|
||
| test-check-deopts: all | ||
| $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=release --check-deopts parallel sequential | ||
| $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) --check-deopts parallel sequential |
There was a problem hiding this comment.
This change is also needed in vcbuild.bat. I think node-check-deopts might be the only one in vcbuild.bat that has --mode=release hard-coded. So just one line needs to change in vcbuild.bat I think.
There was a problem hiding this comment.
@Trott I don't think there is a equivalent of BUILDTYPE_LOWER in vcbuild.bat, the test_args are manipulated in a different way. With my limited knowledge of batch, I suspect node-check-deopts is running the tests twice and the first round can be replaced by adding --check-deopts to test_args, but that probably belongs to another PR.
BridgeAR
approved these changes
Apr 29, 2018
|
CI before landing: https://ci.nodejs.org/job/node-test-pull-request/14684/ |
jasnell
approved these changes
May 6, 2018
trivikr
approved these changes
May 14, 2018
|
Landed in 657723e, thanks! |
joyeecheung
added a commit
that referenced
this pull request
May 14, 2018
PR-URL: #20362 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
May 14, 2018
PR-URL: #20362 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes