v10.2.0 proposal #20724
Merged
v10.2.0 proposal #20724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #20552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Add parameters for the callback for the ClientHttp2Session:altsvc event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: #20598 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Add parameters for the callback for the Http2Stream:error event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: #20610 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit updates the VM section with suggestion for a minor improvement (hopefully) of the text. PR-URL: #20595 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit renames the handle parameter for the BaseObject constructor to object instead of handle. The motivation for doing this is that when stepping through an inheritance chain it can sometimes be a little confusing when HandleWrap is in involved. HandleWrap has a handle parameter but calls the object that is passed to AsyncWrap object, but then when you end up in BaseObject it is named handle. PR-URL: #20570 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit moves the creation of argv and only creates an undefined value if the passed in status was not 0. The variable name client_handle was already used in this function but I've change that usage so that this variable name matches the onconnection callback functions parameter name clientHandle. PR-URL: #20573 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit removes `lear` from the code comment in setTimeout. I'm not 100% sure this is a typo but I've struggled to think what it could mean. Hopefully someone else might be able to shed some light on this. PR-URL: #20576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: v8/v8@9fb02b5 Original commit message: Allow function callbacks to have Proxy as receiver. R=verwaest@chromium.org Bug: v8:5773 Change-Id: Ifd29a1116ee8c86b8d8d24485bbfd19e260ab66b Reviewed-on: chromium-review.googlesource.com/1046088 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53015} PR-URL: #20575 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
- Use `std::max` instead of a custom variant - Use member method pointers to avoid an extra layer of indirection - Stop transferring `Vector` into the `node` namespace PR-URL: #20546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This helps embedders wishing to use Node.js in a multi-threaded fashion and helps pave the way for thread-based worker support. Thanks to Stephen Belanger for reviewing this commit in its original PR. Refs: ayojs/ayo#82 PR-URL: #20539 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Protect environment variables and inherently per-process state with mutexes, to better accommodate Node’s usage in multi-threading environments. Thanks to Stephen Belanger for reviewing this change in its original PR. Refs: ayojs/ayo#82 PR-URL: #20542 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Always easy enough to re-introduce if we do need it. PR-URL: #20544 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This commit moves emitExperimentalWarning into the second object destructoring of require internal/util. PR-URL: #20593 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Also, make the type name notation more consistent. PR-URL: #20631 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
These methods are exposed, even though the BigInt64Array and BigUint64Array types are currently behind the --harmony-bigint command line flag. PR-URL: #20615 Fixes: #20602 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
These variables can as well be stack-allocated. This avoids relying on global state that is not protected by mutexes. Thanks to Stephen Belanger for reviewing this change in its original PR. Refs: ayojs/ayo#82 PR-URL: #20541 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit updates readPackage to return directly when calling packageMainCache instead of storing the result in a local var and returning later. PR-URL: #20591 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit removes the usage of qualified names for consistency. PR-URL: #20594 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Add gitignore rules to ignore compiler output under deps/v8/gypfiles. PR-URL: #20527 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This makes sure regular expressions on validation objects validate against strings when used with `assert.throws` and `assert.rejects`. PR-URL: #20485 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This adds concrete expected types to the assert documentation. It also fixes a `changes` entry and improves some minor comments. PR-URL: #20486 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This moves the `assert` parts from `internal/errors` into an own file. `internal/errors` got bigger and bigger and it was difficult to keep a good overview of what was going on. While doing so it also removes the `internalAssert` function and just lazy loads `assert`. PR-URL: #20486 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This makes sure the functions are actually directly beneath the specification of an error code. That way it is not necessary to jump around when looking at the functionality. PR-URL: #20486 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This fixes a test failure when running `test/parallel/test-child-process-spawnsync-kill-signal.js` under load. What would happen is that `SignalExit()` tries to shutdown the tracing agent, which might not have been set up by the point that Node.js receives the signal. PR-URL: #20637 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This fixes some possible issues with `assert.throws` and `assert.rejects` in combination with an validation object. It will now properly handle primitive values being thrown as error. It also makes sure the `generatedMessage` property is properly set if `assert.throws` or `assert.rejects` is used in combination with an validation object and improves the error performance in such cases by only creating the error once. In addition it will fix detecting regular expressions from a different context such as n-api that are passed through as validator for `assert.throws` or `assert.rejects`. Until now those were not tested. PR-URL: #20482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #20656 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1. Merge rule sets for identical selectors. 2. Delete impossible selector block: we have only stability indexes 0, 1, and 2, so there can't be `.api_stability_3` class. Refs: nodejs.org/api/documentation.html#documentation_stability_index PR-URL: #20601 Refs: https://nodejs.org/api/documentation.html#documentation_stability_index Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
V8 uses a thread pool provided by the host to schedule background tasks for concurrent GC and compiation. Emit trace events to identify the background threads. Ensure that the tracing infrastructure is started before the thread pool is initialized. PR-URL: #20823 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit defines SharedArrayBuffer as a global for all tests, rather than adding comments to individual tests. PR-URL: #20849 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Use err.code checking instead of err.message checking in test-child-process-fork-closed-channel-segfault. PR-URL: #20859 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Currently http2 does not properly submit GOAWAY frames when a session is being destroyed. It also doesn't properly handle when the other party severs the connection after sending a GOAWAY frame, even though it should. Edge, IE & Safari are currently unable to handle empty TRAILERS frames despite them being correctly to spec. Instead send an empty DATA frame with END_STREAM flag in those situations. Fix and adjust several flaky and/or incorrect tests. PR-URL: #20772 Fixes: #20705 Fixes: #20750 Fixes: #20850 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
It's possible for the connections to take too long and since the server is already unrefed, the process will just exit. Instead adjust the test so that server unref only happens after all sessions have been successfuly established and unrefed. That still tests the same condition but will not fail under load. PR-URL: #20772 Fixes: #20705 Fixes: #20750 Fixes: #20850 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Do not use the `'agentRemove'` event to null `socket._httpMessage` as that event is public and can be used to not keep a request in the agent. PR-URL: #20786 Fixes: #20690 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Update the message to be consistent with RFC 7168. Add a note to "Multiple Choices" regarding RFC 7231 superseding RFC 7168. PR-URL: #20700 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>t Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Add a short description and one question to a TLS test. Also, rename it since the previous name might unintentionally evoke connotations to an internet meme that would generally not be considered appropriate in our context. PR-URL: #20820 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Add tests for readline keys to improve coverage. PR-URL: #20840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Adds a note to test/README.md that setting autocrlf to true when checking out sources is required for the tests to run successfully. PR-URL: #20752 Ref: #18967 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Apply the second of five test cases in test-fs-append-fil to the promise-based API in addition to the callback-based API. PR-URL: #20842 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #20846 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Make test runner capable of skipping tests, which makes it possible to skip the failing test/message/core_line_numbers.js test. Make nyc no longer generate compact instrumentation (this causes significantly different code output, which leads to failing test assertions). PR-URL: #20794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
> If `failure` is true, parsing `about:blank` against `base` > must give failure. This tests that the logic for converting > base URLs into strings properly fails the whole parsing > algorithm if the base URL cannot be parsed. Fixes: #20720 PR-URL: #20796 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #20895 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
* addons:
- Fixed a memory leak for users of `AsyncResource` and N-API.
(Michael Dawson)
#20668
* assert:
- The `error` parameter of `assert.throws()` can be an object containing
regular expressions now. (Ruben Bridgewater)
#20485
* crypto:
- The `authTagLength` option has been made more flexible (Tobias Nießen)
#20235)
#20039
* esm:
- Builtin modules (e.g. `fs`) now provide named exports in ES6 modules.
(Gus Caplan)
#20403
* http:
- Handling of `close` and `aborted` events has been made more consistent.
(Robert Nagy)
#20075
#20611
* module:
- add --preserve-symlinks-main (David Goldstein)
#19911
* timers:
- `timeout.refresh()` has been added to the public API.
(Jeremiah Senkpiel)
#20298
* Embedder support:
- Functions for creating V8 `Isolate` and `Context` objects with
Node.js-specific behaviour have been added to the API.
(Allen Yonghuang Wang)
#20639
- Node.js `Environment`s clean up resources before exiting now.
(Anna Henningsen)
#19377
- Support for multi-threaded embedding has been improved.
(Anna Henningsen)
#20542
#20539
#20541
PR-URL: #20724
MylesBorins
force-pushed
the
v10.2.0-proposal
branch
from
f6b6b3f to
5cbb905
Compare
|
Looks like it may have been caused by 3e7741c... removed it and rebasing one more CI: https://ci.nodejs.org/job/node-test-pull-request/15065/ |
MylesBorins
pushed a commit
that referenced
this pull request
May 23, 2018
* addons:
- Fixed a memory leak for users of `AsyncResource` and N-API.
(Michael Dawson)
#20668
* assert:
- The `error` parameter of `assert.throws()` can be an object containing
regular expressions now. (Ruben Bridgewater)
#20485
* crypto:
- The `authTagLength` option has been made more flexible (Tobias Nießen)
#20235)
#20039
* esm:
- Builtin modules (e.g. `fs`) now provide named exports in ES6 modules.
(Gus Caplan)
#20403
* http:
- Handling of `close` and `aborted` events has been made more consistent.
(Robert Nagy)
#20075
#20611
* module:
- add --preserve-symlinks-main (David Goldstein)
#19911
* timers:
- `timeout.refresh()` has been added to the public API.
(Jeremiah Senkpiel)
#20298
* Embedder support:
- Functions for creating V8 `Isolate` and `Context` objects with
Node.js-specific behaviour have been added to the API.
(Allen Yonghuang Wang)
#20639
- Node.js `Environment`s clean up resources before exiting now.
(Anna Henningsen)
#19377
- Support for multi-threaded embedding has been improved.
(Anna Henningsen)
#20542
#20539
#20541
PR-URL: #20724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-05-23, Version 10.2.0 (Current), @MylesBorins
Notable Changes
AsyncResourceand N-API. (Michael Dawson) #20668errorparameter ofassert.throws()can be an object containing regular expressions now. (Ruben Bridgewater) #20485authTagLengthoption has been made more flexible. (Tobias Nießen) #20235, #20039fs) now provide named exports in ES6 modules. (Gus Caplan) #20403closeandabortedevents has been made more consistent. (Robert Nagy) #20075, #20611timeout.refresh()has been added to the public API. (Jeremiah Senkpiel) #20298IsolateandContextobjects with Node.js-specific behaviour have been added to the API. (Allen Yonghuang Wang) #20639Environments clean up resources before exiting now. (Anna Henningsen) #19377Commits
014a2d1035] - assert: fix wrong message indentation (Ruben Bridgewater) #20791338e663860] - assert: fix EOL issue in messages on Windows (Ruben Bridgewater) #207541160d61cd9] - assert: support symbols as assertion messages (cjihrig) #20693bb857d9e71] - assert: make sure throws is able to handle primitives (Ruben Bridgewater) #204825d06c1e1ae] - assert: move AssertionError into own file (Ruben Bridgewater) #20486a5ee31bba1] - (SEMVER-MINOR) assert: accept regular expressions to validate (Ruben Bridgewater) #2048574db9f43ba] - assert,util: lazy load comparison functions (Ruben Bridgewater) #205679feca3ea32] - async_hooks: lazy loading for startup performance (Ruben Bridgewater) #20567e61337d36d] - async_wrap: fix memory leak in AsyncResource (Michael Dawson) #2066856de3bfb70] - benchmark: add tls benchmark for legacy SecurePair (Alex Fernández) #203443b516177c8] - build: use nyc's merge command (Benjamin Coe) #20760aaf1df59be] - build: export openssl TLSv1 methods again (Ben Noordhuis) #207127a980086c8] - build: always use BUILDTYPE binary to run JS tests (Joyee Cheung) #2036247103493f7] - child_process: fix exec set stdout.setEncoding (killagu) #189764a872b98a0] - cluster: remove obsolete array allocation (Ruben Bridgewater) #20567a41c44a307] - codeowners: add rule for *.gypi files (Ben Noordhuis) #20740b701f5af18] - codeowners: fix typo in v8-inspector team name (Ben Noordhuis) #207403fd67249df] - console: .table fall back to logging for function too (ohbarye) #20681bc6dbc3bfc] - console: lazy load cli (Ruben Bridgewater) #20567cecec46204] - crypto: add test case for AES key wrapping (Yihong Wang) #2058734d67085d5] - crypto: allocate more memory for cipher.update() (Yihong Wang) #203702b2ccae390] - (SEMVER-MINOR) crypto: support authTagLength in GCM encryption (Tobias Nießen) #202351e5de6fe97] - crypto: add using directives for v8::Int32, Uint32 (Tobias Nießen) #20225f5e7010eb9] - crypto: use kNoAuthTagLength in InitAuthenticated (Tobias Nießen) #202255ea1a58db9] - crypto: remove rsaPrivate and rename rsaPublic (Daniel Bevenius) #20164503844eb73] - crypto: add addCipherPrototypeFunctions function (Daniel Bevenius) #2016472029b8cc7] - crypto: add createCipher/WithIV functions (Daniel Bevenius) #20164bdd2856152] - (SEMVER-MINOR) crypto: allow to restrict valid GCM tag length (Tobias Nießen) #20039e56716e396] - deps: cherry-pick ff0a9793334 from upstream V8 (Anna Henningsen) #207198e058d5f94] - deps: patch V8 to 6.6.346.32 (Myles Borins) #20748cb94601cf2] - deps: cherry-pick 23652c5f from upstream V8 (Eugene Ostroukhov) #2060891e60b0d33] - deps: V8: cherry-pick b49206d from upstream (Ali Ijaz Sheikh) #207276ce589f7f4] - deps: patch V8 to 6.6.346.31 (Myles Borins) #20603f69a823f8e] - deps: upgrade to libuv 1.20.3 (cjihrig) #2058560eab9100f] - dns: lazy loaded (Ruben Bridgewater) #20567b9848bf8cd] - doc: add note about autocrlf required for tests (Bartosz Sosnowski) #207528a17a259f3] - doc: fix some nits in hardcoded manpage links (Vse Mozhet Byt) #208548317a468db] - doc: fix fs.promises sample codes (Keita Akutsu) #2083837b9fe1e68] - doc: fix typo in http2.md (Keita Akutsu) #2084388aee8a65c] - doc: improve _Deprecation_ definition (Rich Trott) #207887b1c035218] - doc: describe using multiple link-module on win (Bartosz Sosnowski) #207749a8cdc93ff] - doc: fix typo in COLLABORATOR_GUIDE.md (Vse Mozhet Byt) #20742657f8cbe41] - doc: fix linter warnings and typos in manpage (Alhadis) #20741165971d35b] - doc: sort references in ASCII order (Rich Trott) #207908f489a2447] - doc: add .github to CODEOWNERS (Rich Trott) #207337943449305] - doc: improve specificity in CODEOWNERS (Rich Trott) #207297d28f5bb1b] - doc: reorder CODEOWNERS file (Rich Trott) #20732fd14ec1101] - doc: add missingchanges:entry for assert.throws (Anna Henningsen) #20723a66aad4a50] - doc: fixup NODE_EXTERN -> NAPI_EXTERN (Michael Dawson) #20641f263340731] - doc: fix signature for napi_create_range_error (Michael Dawson) #20641d11a435875] - doc: fix typo in dns docs (Anna Henningsen) #20711512982c0ff] - doc: update AUTHORS list (Michaël Zasso) #20658e06c5874f6] - doc: add global node_modules to require.resolve() (musgravejw) #205341d7379d641] - doc: fix stability text for n-api (Michael Dawson) #2065973492233c3] - doc: add util.types.isModuleNamespaceObject() (Gus Caplan) #206163929516a6f] - doc: fix nits in doc/api_assets/style.css (Vse Mozhet Byt) #2060101abed1c36] - doc: update assert documentation (Ruben Bridgewater) #20486c546746396] - doc: add util.types.isBig{Int,Uint}64Array() (cjihrig) #20615d568952b8c] - doc: fix missing napi_get_typedarray_info() param (Gabriel Schulhof) #206319177f734e3] - doc: update VM section text (Daniel Bevenius) #2059588bc6da6e9] - doc: add parameters for Http2Stream:error event (Ujjwal Sharma) #20610b3b267a87c] - doc: add params for ClientHttp2Session:altsvc (Ujjwal Sharma) #20598d327893193] - doc: refactor mode constants parts in fs.md (Shobhit Chittora) #205584a7bb406fe] - doc, tools: unify stability signatures (Vse Mozhet Byt) #20552c244436707] - errors: move functions to error code (Ruben Bridgewater) #20486104c3bc443] - (SEMVER-MINOR) esm: provide named exports for builtin libs (Gus Caplan) #204039b43af3703] - fs: lazy load createPromise/promiseResolve (James M Snell) #207662d2897855f] - fs: lazy load the promises impl (James M Snell) #20766dc30d36467] - fs: consistent constants use and cleanup (James M Snell) #20765e5a0c197bd] - fs: refactor promises version of lchown and lchmod (cjihrig) #2055139caa6ddaf] - fs: use _final() for fs.WriteStream (Jackson Tian) #20562de06115d18] - fs: make fs.promises non-enumerable (cjihrig) #20632545a9d839b] - http: fix capitalization of 418 status message (я котик пур-пур) #207003c05b0323e] - http: do not rely on the 'agentRemove' event (Luigi Pinca) #207864c6bfbdbb4] - http: fix client response close & aborted (Robert Nagy) #200758029a2473e] - http: always emit close on req and res (Robert Nagy) #20611171600d00d] - http2: fix several serious bugs (Anatoli Papirovski) #20772b2fb1d70bb] - http2: fix end without read (Anatoli Papirovski) #20621de2b04772b] - http2: avoid bind and properly clean up in compat (Robert Nagy) #2037428ecf93dc5] - http2: destroy the socket properly and add tests (Mathias Buus) #1985204f7678edb] - inspector: add a "NodeTracing" domain support (Eugene Ostroukhov) #20608ccf69dd3b6] - inspector: fix inspector::Agent::HasConnectedSessions (helloshuangzi) #20614e0fd80c641] - lib: do not call performance hooks (Ruben Bridgewater) #20567bd13193979] - lib: remove unnecessary require (Ruben Bridgewater) #2056707537749db] - lib: use capital letters in comments (Ruben Bridgewater) #2056772f3228203] - lib: lazy loaded (Ruben Bridgewater) #205673aab6ce39d] - lib: lazy load necessary loaders (Ruben Bridgewater) #20567486ac23cb0] - lib: only load inspector stuff if necessary (Ruben Bridgewater) #2056761415dccc4] - (SEMVER-MINOR) lib: defer pausing stdin to the next tick (Anna Henningsen) #193777c13e54ca7] - lib: return directly from packageMainCache (Daniel Bevenius) #20591fb7a775242] - lib,src: use V8 API for collection inspection (Anna Henningsen) #207191f01830ede] - lib,src,test: fix comments (Tobias Nießen) #20846b10823506d] - meta: add initial CODEOWNERS file (James M Snell) #20554678b7544df] - module: introduce defaultModuleName in module.js (Daniel Bevenius) #20709b6ea5df08a] - (SEMVER-MINOR) module: add --preserve-symlinks-main (David Goldstein) #19911eac7aad55e] - net: lazy load dns (Ruben Bridgewater) #205671f34c04bd0] - net: remove typo in setTimeout comment (Daniel Bevenius) #20576d614511b9f] - net,http2: refactor _write and _writev (Ujjwal Sharma) #2064328d00a18c8] - os: lazy loaded (Ruben Bridgewater) #205672e9957641e] - perf_hooks: always set bootstrapComplete (James M Snell) #20768c8fe8e8f5d] - (SEMVER-MINOR) process: create stdin withmanualStart: true(Anna Henningsen) #193774a92da15dc] - querystring: lazy loaded (Ruben Bridgewater) #205673eb38debb4] - readline: lazy loaded (Ruben Bridgewater) #20567ada41b02c5] - repl: make console, module and require non-enumerable (Ruben Bridgewater) #2071783119db45e] - repl: add friendly tips about how to exit repl (monkingxue) #2061732c3006fd0] - src: trace_events: background thread events (Ali Ijaz Sheikh) #208233110d15f2b] - src: make pointers lean left in node_crypto.cc (Daniel Bevenius) #20799b6225349f4] - src: use unqualified names in node_crypto.cc (Daniel Bevenius) #20799010ad8c26c] - src: move *Exceptions out to separate cc/h (James M Snell) #2078908b98d17f1] - src: fix odd linting issue (James M Snell) #2078936d4a42e35] - src: move CallbackScope to separate cc/h (James M Snell) #207894b64c847f1] - src: trace_events: support for metadata events (Ali Ijaz Sheikh) #207573edb04d065] - src: remove 2ndundefinedargument in node_file.cc (Dan Kang) #20629d6805c15a5] - src: add override to ThreadPool methods in zlib (Daniel Bevenius) #2076901aa0581fe] - src: order C++ error list alphabetically (Anna Henningsen) #207075eb0765fc9] - src: handle TryCatch with empty message (Ben Noordhuis) #20708e0b438a641] - (SEMVER-MINOR) src: add public API to create isolate and context (helloshuangzi) #20639d223e3ca41] - src: makeAsyncResourcedestructor virtual (Anna Henningsen) #2063328b58b56a8] - src: replacetemplate\<→template \<(Anna Henningsen) #2067530aceedba6] - src: make env_ and context_ private (Daniel Bevenius) #206719422909e07] - src: remove unused includes from node_contextify.h (Daniel Bevenius) #20670e732b4ce5c] - src: use unqualified names in node_contextify.cc (Daniel Bevenius) #2066957dfd64f8f] - src: add missing override to ThreadPoolWork funcs (Daniel Bevenius) #206632347ce8870] - (SEMVER-MINOR) src: unify thread pool work (Anna Henningsen) #193777153bec955] - (SEMVER-MINOR) src: always call ReadStop() before Close() (Anna Henningsen) #193779e1dcdc5bd] - (SEMVER-MINOR) src: remove NodeCategorySet destructor (Anna Henningsen) #1937797d939a5f0] - (SEMVER-MINOR) src: store fd for libuv streams on Windows (Anna Henningsen) #193775b0d2e7b19] - (SEMVER-MINOR) src: add can_call_into_js flag (Anna Henningsen) #193779e2554ce98] - (SEMVER-MINOR) src: use cleanup hooks to tear down BaseObjects (Anna Henningsen) #193778995408748] - (SEMVER-MINOR) src: keep track of open requests (Anna Henningsen) #1937775aad9069b] - (SEMVER-MINOR) src: unify ReqWrap libuv calling (Anna Henningsen) #19377e253edb48a] - (SEMVER-MINOR) src: make CleanupHandles() tear down handles/reqs (Anna Henningsen) #19377ba269585ed] - (SEMVER-MINOR) src: add environment cleanup hooks (Anna Henningsen) #1937740fb885ecf] - src: more automatic memory management in node_crypto.cc (Anna Henningsen) #20238fd5adbc9c3] - src: fix node_crypto.cc compiler warnings (Daniel Bevenius) #20216db457cb6a0] - src: fix typo in util.h comment (Anna Henningsen) #20656e93726ad10] - src: fix nullptr dereference for signal during startup (Anna Henningsen) #206370824ea9d7b] - src: use unqualified names in module_wrap.cc (Daniel Bevenius) #2059443ec938634] - src: remove static variables from string_search (Anna Henningsen) #205414873fbaf63] - src: remove unused freelist.h header (Anna Henningsen) #20544a89cc2886e] - src: protect global state with mutexes (Anna Henningsen) #205422df99ac095] - src: use lock for c-ares library init/cleanup (Anna Henningsen) #205395803973206] - src: minor refactor to string_search.h (Anna Henningsen) #20546983cb269e0] - src: don't create Undefined if not needed (Daniel Bevenius) #20573e01e060763] - src: rename handle parameter object (Daniel Bevenius) #20570328a2c7c28] - stream: lazy load end-of-stream (Ruben Bridgewater) #2056794d217f877] - stream: lazy load ReadableAsyncIterator (Ruben Bridgewater) #20567ed5f253cfa] - stream: refactor getHighWaterMark in state.js (Daniel Bevenius) #2041539a41120d4] - stream: simplify writable's validChunk() (cjihrig) #20696981a2f7b16] - stream: simplify Writable.prototype.cork() (cjihrig) #20697ebc1b77e5a] - stream: no need to initial er with false (Jackson Tian) #206070ace8f9835] - string_decoder: lazy loaded (Ruben Bridgewater) #20567235a272838] - test: test about:blank against invalid WHATWG URL (Joyee Cheung) #20796d68f6e699d] - test: fix tests that fail under coverage (Benjamin Coe) #2079424286c4b4b] - test: add promise API test for appendFile() (Rich Trott) #20842086d108e92] - test: improve coverage for internal/readline (Masashi Hirano) #208406a113da1f8] - test: rename and document tls test (Anna Henningsen) #20820275907f7be] - test: fix flaky http2-session-unref (Anatoli Papirovski) #20772ce40c70995] - test: use error code rather than message in test (Rich Trott) #208593afeaaa934] - test: define SharedArrayBuffer as a known global (cjihrig) #208493e7741c488] - test: reduce runtime (Ruben Bridgewater) #2068822f46e7766] - test: remove common.globalCheck (Ruben Bridgewater) #207175ffce3ef06] - test: remove untested knownGlobals (Ruben Bridgewater) #20717e7c2616d10] - test: mark tests as flaky as intermediate step (Ruben Bridgewater) #20835b664a848fa] - test: improve assertion in test-performance (Anna Henningsen) #20809045b37b32d] - test: add eslint rule to verify assertion input (Ruben Bridgewater) #207181ae076b30e] - test: add loaded modules test (Ruben Bridgewater) #205679e432ca79c] - test: add promise API test for appendFile() (Rich Trott) #20739a6667d68f3] - test: slightly improve test-util-inspect assertions (Anna Henningsen) #20721a4cbe30791] - test: improve reliability of http2-session-timeout (Rich Trott) #206920d28b4b6ba] - test: disable colors in test-assert-checktag.js (cjihrig) #20695dccbc3a153] - test: disable colors in test-assert-deep.js (cjihrig) #2069590c77bcc18] - test: disable colors in test-assert.js (cjihrig) #206952b6e8ccfd4] - test: increase test coverage for fs/promises.js (David Humphrey) #19811e6c0bbe185] - test: display values in AssertionErrors (RakshithNM) #20545886116f837] - test: apply test-fs-access to promises API (Rich Trott) #206672a7c863d3d] - test: modernize and correct test-doctool-html.js (Vse Mozhet Byt) #206769c1c03e5d4] - test: better error message in trace events test (Anna Henningsen) #206550aab92f6b2] - test: add test for async hooks parity for async/await (Maya Lekova) #206262db83fdc0c] - test: remove deepStrictEqual() third argument (Francesco Falanga) #2070287f3f5af2e] - test: plug AliasedBuffer cctest memory leak (Anna Henningsen) #20665eb21a6b7f6] - test: remove crypto.DEFAULT_ENCODING usage (Daniel Bevenius) #20221de34cfad58] - test: make sure linked lists are inspectable with defaults (Anna Henningsen) #2001741e1dc09de] - test: add regression test for stderr redirection breaks require #11257 (Benjamin Coe) #2039156530f0844] - (SEMVER-MINOR) timers: make timer.refresh() a public API (Jeremiah Senkpiel) #20298bd500af2ff] - tools: update prohibited-strings md linting (Rich Trott) #207422361f6454c] - tools: stricter eslint rule for globals (Ruben Bridgewater) #2056738fc741c36] - tools: eliminate intermediate module in doctools (Vse Mozhet Byt) #207016f4e9ffb7b] - tools: fix "the the" typos in comments (Masashi Hirano) #20716b795953b5f] - tools: hide symbols for builtin JS files in binary (Anna Henningsen) #2063444960a0d5a] - tools: make C++ linter rejecttemplate\<(Anna Henningsen) #206757bff6d15b2] - tools: overhaul tools/doc/html.js (Vse Mozhet Byt) #20613f2ad1d5d22] - (SEMVER-MINOR) tools: remove--quietfrom run-valgrind.py (Anna Henningsen) #19377ebd102e473] - tools: use macOS as operating system name (Rich Trott) #2057908097ccf84] - tools: ignore VS compiler output (Yulong Wang) #205278781bcb1ee] - tools, doc: wrap manpage links in code elements (Vse Mozhet Byt) #20785e1ff587a26] - tools, doc: fix stability index isssues (Vse Mozhet Byt) #20731526163cff9] - url: introduceURL\_FLAGS\_IS\_DEFAULT\_SCHEME\_PORTflag (Ayush Gupta) #20479c8c9211fa6] - util: improve error inspection (Ruben Bridgewater) #20802f0d6a37c5c] - util: fix inspected stack indentation (Ruben Bridgewater) #2080238bc5fbd6b] - util: remove erroneous whitespace (Ruben Bridgewater) #208025ce85a72cb] - util: wrap error in brackets without stack (Ruben Bridgewater) #20802b308a07301] - util: support inspecting namespaces of unevaluated modules (Gus Caplan) #20782105f606202] - v8: backport 9fb02b526f1cd3b859a530a01adb08bc0d089f4f (Gus Caplan) #205758604481b2e] - vm: move emitExperimentalWarning (Daniel Bevenius) #20593740bf783e5] - vm,trace_events: add node.vm.script trace events category (James M Snell) #20728d5db576d15] - zlib: reduce number of static internal methods (Anna Henningsen) #20674