Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: ignore VS compiler output under deps/v8/gypfiles #20527

Closed
wants to merge 1 commit into from
Closed

tools: ignore VS compiler output under deps/v8/gypfiles #20527

wants to merge 1 commit into from

Conversation

fs-eire
Copy link
Contributor

@fs-eire fs-eire commented May 4, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 4, 2018
@fs-eire fs-eire changed the title Ignore VS compiler output under deps/v8/gypfiles meta: Ignore VS compiler output under deps/v8/gypfiles May 4, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2018
@BridgeAR
Copy link
Member

BridgeAR commented May 5, 2018

The commit message has to be fixed to e.g., tools: ignore VS compiler output before or while landing.

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 5, 2018
@fs-eire fs-eire changed the title meta: Ignore VS compiler output under deps/v8/gypfiles tools: ignore VS compiler output under deps/v8/gypfiles May 7, 2018
targos pushed a commit that referenced this pull request May 10, 2018
@fs-eire @targos
tools: ignore VS compiler output
81b99da 
Add gitignore rules to ignore compiler output under deps/v8/gypfiles.

PR-URL: #20527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos
Copy link
Member

targos commented May 10, 2018

Landed in 81b99da 🎉

@fs-eire Congratulations on your first commit in Node.js core!

@targos targos closed this May 10, 2018
targos pushed a commit that referenced this pull request May 12, 2018
@fs-eire @targos
tools: ignore VS compiler output
08097cc 
Add gitignore rules to ignore compiler output under deps/v8/gypfiles.

PR-URL: #20527
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fs-eire @BridgeAR @targos @jasnell @cjihrig @trivikr @nodejs-github-bot