Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: return directly from packageMainCache #20591

Closed
wants to merge 1 commit into from
Closed

lib: return directly from packageMainCache #20591

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 8, 2018

This commit updates readPackage to return directly when calling
packageMainCache instead of storing the result in a local var
and returning later.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
lib: return directly from packageMainCache
0fc159b 
This commit updates readPackage to return directly when calling
packageMainCache instead of storing the result in a local var
and returning later.
@danbev
Copy link
Contributor Author

danbev commented May 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14711/

@trivikr trivikr added the lib / src Issues and PRs related to general changes in the lib or src directory. label May 8, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 8, 2018
@danbev
Copy link
Contributor Author

danbev commented May 10, 2018

Landed in 6446510.

@danbev danbev closed this May 10, 2018
@danbev danbev deleted the loaders_readPackage branch May 10, 2018 03:23
danbev added a commit that referenced this pull request May 10, 2018
@danbev
lib: return directly from packageMainCache
6446510 
This commit updates readPackage to return directly when calling
packageMainCache instead of storing the result in a local var
and returning later.

PR-URL: #20591
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request May 12, 2018
@danbev @targos
lib: return directly from packageMainCache
7c13e54 
This commit updates readPackage to return directly when calling
packageMainCache instead of storing the result in a local var
and returning later.

PR-URL: #20591
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@danbev @jasnell @targos @cjihrig @tniessen @devsnek @BridgeAR @trivikr