doc: fix stability text for n-api #20659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While some places list n-api as stable, the reference in doc/api/addons.md was missed. This fixes that instance. Fixes: nodejs#20645
nodejs-github-bot
added
addons
vsemozhetbyt
approved these changes
May 10, 2018
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
the
author ready
lpinca
approved these changes
May 10, 2018
jasnell
approved these changes
May 10, 2018
cjihrig
approved these changes
May 10, 2018
trivikr
approved these changes
May 11, 2018
addaleax
approved these changes
May 11, 2018
tniessen
approved these changes
May 11, 2018
|
Landed in 3706c65 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 11, 2018
While some places list n-api as stable, the reference in doc/api/addons.md was missed. This fixes that instance. Fixes: nodejs#20645 PR-URL: nodejs#20659 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
May 12, 2018
While some places list n-api as stable, the reference in doc/api/addons.md was missed. This fixes that instance. Fixes: #20645 PR-URL: #20659 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While some places list n-api as stable, the reference
in doc/api/addons.md was missed. This fixes that
instance.
Fixes: #20645
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes