Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: simplify writable's validChunk() #20696

Merged
merged 1 commit into from
May 14, 2018
Merged

stream: simplify writable's validChunk() #20696

merged 1 commit into from
May 14, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 13, 2018

In the spirit of #20607, this commit simplifies validChunk() by removing an unnecessary intermediate variable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label May 13, 2018
@lpinca
Copy link
Member

lpinca commented May 13, 2018 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/14830/

EDIT (cjihrig): For future reference, CI was green.

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 13, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 13, 2018
@cjihrig
stream: simplify writable's validChunk()
a9c34b4 
This commit simplifies validChunk() by removing an unnecessary
intermediate variable.

PR-URL: nodejs#20696
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit a9c34b4 into nodejs:master May 14, 2018
@cjihrig cjihrig deleted the chunk branch May 14, 2018 17:33
addaleax pushed a commit that referenced this pull request May 14, 2018
@cjihrig @addaleax
stream: simplify writable's validChunk()
86d396c 
This commit simplifies validChunk() by removing an unnecessary
intermediate variable.

PR-URL: #20696
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@cjihrig @MylesBorins
stream: simplify writable's validChunk()
39a4112 
This commit simplifies validChunk() by removing an unnecessary
intermediate variable.

PR-URL: #20696
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacksonTian JacksonTian JacksonTian approved these changes

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjihrig @lpinca @JacksonTian @danbev @jasnell @addaleax @TimothyGu @BridgeAR @trivikr @nodejs-github-bot