dns: default to verbatim=true in dns.lookup() #20710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
the
semver-major
addaleax
approved these changes
May 14, 2018
| **Default:** currently `false` (addresses are reordered) but this is | ||
| expected to change in the not too distant future. | ||
| New code should use `{ verbatim: true }`. | ||
| IPv4 addresses are placed before IPv6 addresses. **Default:** `true` |
There was a problem hiding this comment.
Nit: a period after `true` for consistency with the previous option.
There was a problem hiding this comment.
I guess that can also be done why landing the PR.
cjihrig
approved these changes
May 14, 2018
BridgeAR
approved these changes
May 14, 2018
trivikr
approved these changes
May 14, 2018
jasnell
approved these changes
May 14, 2018
lpinca
approved these changes
May 14, 2018
BridgeAR
added
the
author ready
|
CI https://ci.nodejs.org/job/node-test-pull-request/14880/ ❌ Please address the nit while landing. |
BridgeAR
removed
the
author ready
|
There are lots of related CI failures. |
bnoordhuis
force-pushed
the
dns-lookup-verbatim-true
branch
from
f1945c9
to
91e03fe
Compare
|
I kinda expected that, I was pretty sure the test suite would be full of assumptions about localhost. I fixed them, PTAL. I also removed |
BridgeAR
added
author ready
|
Needs a rebase and another CI run after. |
bnoordhuis
force-pushed
the
dns-lookup-verbatim-true
branch
from
91e03fe
to
b173c9e
Compare
BridgeAR
added
the
author ready
|
Thanks, Ruben. Looks like there are still some tests to fix up... |
BridgeAR
removed
the
author ready
|
ping @bnoordhuis |
|
ping @bnoordhuis |
sam-github
approved these changes
Oct 17, 2018
treysis
pushed a commit
to treysis/io.js
that referenced
this pull request
Mar 10, 2021
Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Reissue of nodejs#31567
treysis
pushed a commit
to treysis/io.js
that referenced
this pull request
Mar 13, 2021
Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Reissue of nodejs#31567
treysis
pushed a commit
to treysis/io.js
that referenced
this pull request
Mar 26, 2021
Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Reissue of nodejs#31567 Reissue of nodejs#37681
treysis
pushed a commit
to treysis/io.js
that referenced
this pull request
Sep 3, 2021
Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Reissue of nodejs#31567 Reissue of nodejs#37681 Reissue of nodejs#37931
treysis
pushed a commit
to treysis/io.js
that referenced
this pull request
Sep 3, 2021
Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Reissue of nodejs#31567 Reissue of nodejs#37681 Reissue of nodejs#37931
treysis
pushed a commit
to treysis/io.js
that referenced
this pull request
Sep 3, 2021
Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Reissue of nodejs#31567 Reissue of nodejs#37681 Reissue of nodejs#37931
treysis
pushed a commit
to treysis/io.js
that referenced
this pull request
Sep 3, 2021
Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Refs: nodejs#38099 Reissue of nodejs#31567 Reissue of nodejs#37681 Reissue of nodejs#37931
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2021
Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: #31566 Refs: #6307 Refs: #20710 Refs: #38099 Reissue of #31567 Reissue of #37681 Reissue of #37931 PR-URL: #39987 Refs: #6307 Refs: #20710 Refs: #38099 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2021
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #39987 Fixes: #31566 Refs: #6307 Refs: #20710 Refs: #38099 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2021
Switch the default from `ipv4first` to `verbatim` (return them exactly as the resolver sent them to us). PR-URL: #39987 Fixes: #31566 Refs: #6307 Refs: #20710 Refs: #38099 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2021
Switch the default from `ipv4first` to `verbatim` (return them exactly as the resolver sent them to us). PR-URL: #39987 Fixes: #31566 Refs: #6307 Refs: #20710 Refs: #38099 Co-authored-by: treysis <treysis@gmx.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)
This is intended to be released in Node.js 11.