dns: default to verbatim=true in dns.lookup() #39987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dns
treysis
force-pushed
the
verbatim-true-v17
branch
4 times, most recently
from
879d1ff to
e37e2be
Compare
Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Refs: nodejs#38099 Reissue of nodejs#31567 Reissue of nodejs#37681 Reissue of nodejs#37931
treysis
force-pushed
the
verbatim-true-v17
branch
from
e37e2be to
acdfa26
Compare
aduh95
reviewed
Sep 3, 2021
aduh95
added
the
semver-major
|
Now again we have some failing tests. Do you think I should remove where appropriate to listen on 127.0.0.1 an just listen "generally"? Or force listening on 127.0.0.1 and force connect on 127.0.0.1? |
|
Oooh, my careless mistakes. Let's hope it turns green after this run so we can spin up a CI job. |
|
Alright, can we get a CI @aduh95 ? |
github-actions
bot
removed
the
request-ci
|
Can we get a CI already before passing the other checks? Because I just need to see why some stuff is failing on CI @aduh95 |
This was referenced Apr 2, 2023
3 tasks
This was referenced May 11, 2023
1 task
1 task
Closed
2 tasks
9 tasks
6 tasks
Closed
2 tasks
Closed
fpm-peter
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
…7.0.0.1' rather than 'localhost' (elastic#3049) Starting in node v17 the defaults for DNS resolution order was changed (nodejs/node#39987) such that `dns.lookup()` no longer sorted IPv4 addresses first. This impacts usage of the *default* APM Server URL (the `serverUrl` config var), 'http://localhost:8200', when using node >=17 because the APM server only binds to the IPv4 address by default (elastic/apm-server#1405). Fixes: elastic#3045 Refs: elastic/apm#727
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)
After having the option to manually override the default behavior, this is another attempt at changing the default behavior.
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reissue of #31567
Reissue of #37681
Reissue of #37931