Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: sort references in ASCII order #20790

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 16, 2018

The references in the COLLABORATOR_GUIDE appear to be in no particular
order. Sort in ASCII order.

Checklist

The references in the COLLABORATOR_GUIDE appear to be in no particular
order. Sort in ASCII order.
@Trott Trott requested a review from a team as a code owner May 16, 2018 21:59
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 16, 2018
@Trott
Copy link
Member Author

Trott commented May 16, 2018

[`--pending-deprecation`]: doc/api/cli.md#--pending-deprecation
[git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
[`node-core-utils`]: https://github.com/nodejs/node-core-utils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backticks go before uppercase letters in ASCII?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backticks go before uppercase letters in ASCII?

Backticks are after uppercase and before lowercase.

uppercase letters: 65 through 90
backtick: 96
lowercase letters: 97 through 122

[git-node-metadata]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-metadata
[git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git-node before git-node-metadata?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a naïve sort so it's really [git-node] before [git-node-metadata]. I think sorting on the string excluding the [ and ] makes more sense, though, so yeah, I'll swap those two...

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project. labels May 17, 2018
Trott added a commit to Trott/io.js that referenced this pull request May 17, 2018
The references in the COLLABORATOR_GUIDE appear to be in no particular
order. Sort in ASCII order.

PR-URL: nodejs#20790
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

Trott commented May 17, 2018

Landed in c7831bb

@Trott Trott closed this May 17, 2018
MylesBorins pushed a commit that referenced this pull request May 22, 2018
The references in the COLLABORATOR_GUIDE appear to be in no particular
order. Sort in ASCII order.

PR-URL: #20790
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax addaleax mentioned this pull request May 22, 2018
@Trott Trott deleted the alphabetize-collab-guide branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants