-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: sort references in ASCII order #20790
Conversation
The references in the COLLABORATOR_GUIDE appear to be in no particular order. Sort in ASCII order.
COLLABORATOR_GUIDE.md
Outdated
[`--pending-deprecation`]: doc/api/cli.md#--pending-deprecation | ||
[git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md | ||
[`node-core-utils`]: https://github.com/nodejs/node-core-utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backticks go before uppercase letters in ASCII?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backticks go before uppercase letters in ASCII?
Backticks are after uppercase and before lowercase.
uppercase letters: 65 through 90
backtick: 96
lowercase letters: 97 through 122
COLLABORATOR_GUIDE.md
Outdated
[git-node-metadata]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-metadata | ||
[git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git-node
before git-node-metadata
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a naïve sort so it's really [git-node]
before [git-node-metadata]
. I think sorting on the string excluding the [
and ]
makes more sense, though, so yeah, I'll swap those two...
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
The references in the COLLABORATOR_GUIDE appear to be in no particular order. Sort in ASCII order. PR-URL: nodejs#20790 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Landed in c7831bb |
The references in the COLLABORATOR_GUIDE appear to be in no particular order. Sort in ASCII order. PR-URL: #20790 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
The references in the COLLABORATOR_GUIDE appear to be in no particular
order. Sort in ASCII order.
Checklist