Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve coverage for readline #20840

Closed
wants to merge 1 commit into from
Closed

test: improve coverage for readline #20840

wants to merge 1 commit into from

Conversation

shisama
Copy link
Contributor

@shisama shisama commented May 20, 2018

Add tests for readline keys to improve coverage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test: improve coverage for internal/readline
00a1647 
Add tests for readline keys to improve coverage.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 20, 2018
@hiroppy hiroppy added the readline Issues and PRs related to the built-in readline module. label May 20, 2018
@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 20, 2018
@benjamingr
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/14990/console

@trivikr FYI [author ready] is used only after CI is started.

@apapirovski
Copy link
Member

Landed in 731c55a

apapirovski pushed a commit that referenced this pull request May 22, 2018
@apapirovski
test: improve coverage for internal/readline
731c55a 
Add tests for readline keys to improve coverage.

PR-URL: #20840
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@MylesBorins
test: improve coverage for internal/readline
086d108 
Add tests for readline keys to improve coverage.

PR-URL: #20840
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@addaleax addaleax mentioned this pull request May 22, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 23, 2018
@MylesBorins
test: improve coverage for internal/readline
d9aecc0 
Add tests for readline keys to improve coverage.

PR-URL: #20840
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shisama @benjamingr @apapirovski @jasnell @cjihrig @trivikr @hiroppy @nodejs-github-bot