Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,win: disable DLL-interface warnings #20958

Closed
wants to merge 1 commit into from
Closed

build,win: disable DLL-interface warnings #20958

wants to merge 1 commit into from

Conversation

piscisaureus
Copy link
Contributor

@piscisaureus piscisaureus commented May 25, 2018 •
edited
Loading

Compiling node with vcbuild generates 10,000s of these warnings,
originating from v8.h. This makes it impossible to read any other
diagnostic messages.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label May 25, 2018
@piscisaureus piscisaureus force-pushed the warnings branch 2 times, most recently from fd8e255 to 65ceed1 Compare May 25, 2018 08:59
@BridgeAR
Copy link
Member

This came up before. See #15570

I guess we should indeed do this even though this should get fixed by Microsoft.

@piscisaureus
Copy link
Contributor Author

@BridgeAR

Good to see that the root cause is being addressed.
But for the moment, this many warnings makes contributing to node a terrible experience.

Scrolling back in the terminal has become a thing of the past.
My browser crashes when I try to look at the CI output.

People can't work like that.

@BridgeAR
Copy link
Member

I think it would be good to add a TODO to remove those two again as soon as it got fixed upstream. And please also open an issue at Microsoft https://developercommunity.visualstudio.com/spaces/62/index.html.

@BridgeAR
Copy link
Member

@nodejs/build PTAL

@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/15097/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 25, 2018
jasnell
jasnell approved these changes May 25, 2018
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a TODO as suggested

@richardlau
Copy link
Member

No objections, but just noting that since this is common.gypi we'll also be suppressing these for addons.

@piscisaureus piscisaureus requested a review from a team as a code owner May 25, 2018 22:03
@piscisaureus
build,win: disable DLL-interface warnings
61f735e 
Compiling node with vcbuild generates 10,000s of these warnings,
originating from v8.h. This makes it impossible to read any other
diagnostic messages.

Refs: nodejs#15570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: nodejs#20958
@piscisaureus
Copy link
Contributor Author

@BridgeAR, @nodejs/build: Added the TODO item; PTAL.

@piscisaureus
Copy link
Contributor Author

Note that I don't seem to have commit rights. Someone has to push the button for me.

@joyeecheung
Copy link
Member

joyeecheung commented May 27, 2018 •
edited
Loading 

✔  Approvals: 4, 3 from TSC (jasnell, cjihrig, joyeecheung)
ℹ  Last Full PR CI on 2018-05-25T11:36:20Z: https://ci.nodejs.org/job/node-test-pull-request/15097/
⚠  Commits were pushed after the last Full PR CI run:
⚠  - build,win: disable DLL-interface warnings
ℹ  This PR was created on Fri May 25 2018 (weekday in UTC)
⚠  2 hours left to land

The push button is not used in this repo. According to git-node there are 2 hours left to land this (we wait for 48 hours for PRs summited on UTC weekday so people can have time to weigh in).

@joyeecheung
Copy link
Member

Landed in 4f28015, thanks!

joyeecheung pushed a commit that referenced this pull request May 27, 2018
@piscisaureus @joyeecheung
build,win: disable DLL-interface warnings
4f28015 
Compiling node with vcbuild generates 10,000s of these warnings,
originating from v8.h. This makes it impossible to read any other
diagnostic messages.

PR-URL: #20958
Refs: #15570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@richardlau
Copy link
Member

Note that I don't seem to have commit rights. Someone has to push the button for me.

@piscisaureus That's because you were moved to Collaborator Emeriti in #16173. I'd suggest asking @nodejs/TSC if you wish to be moved back to Collaborator status.

@richardlau
Copy link
Member

I'd suggest asking @nodejs/TSC if you wish to be moved back to Collaborator status.

Should have been @nodejs/tsc.

MylesBorins pushed a commit that referenced this pull request May 29, 2018
@piscisaureus @MylesBorins
build,win: disable DLL-interface warnings
d7fed22 
Compiling node with vcbuild generates 10,000s of these warnings,
originating from v8.h. This makes it impossible to read any other
diagnostic messages.

PR-URL: #20958
Refs: #15570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@piscisaureus @BridgeAR @richardlau @joyeecheung @jasnell @cjihrig @nodejs-github-bot