Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "src: move context bootstrap to js" #21587

Closed
wants to merge 1 commit into from
Closed

Revert "src: move context bootstrap to js" #21587

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 29, 2018

This reverts commit d13cdd9.

The commit causes node to segfault if it is build --without-intl. This fact was revealed in CI testing, but alas, trust in CI infra is low enough that it was likely deemed an infra problem. I have some things to suggest around that, but first...let's fix the build, shall we?

👍 here to fast-track. (Fast-tracking is permitted for changes that unbreak CI. CI has been red due to this issue since it landed.)

@devsnek @refack @nodejs/build

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 29, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/173/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 29, 2018
@Trott Trott mentioned this pull request Jun 29, 2018
Closed
3 tasks
@refack refack added the i18n-api Issues and PRs related to the i18n implementation. label Jun 29, 2018
@Trott
Copy link
Member Author

Trott commented Jun 29, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15664/

@Trott Trott mentioned this pull request Jun 29, 2018
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Jun 29, 2018

Narrower alternative fix in #21589

@Trott
Copy link
Member Author

Trott commented Jun 29, 2018

Closing in favor of #21589

@Trott Trott closed this Jun 29, 2018
@Trott Trott deleted the revert-d13cdd9c485a2f167f9901f238b4412f2b8bb3e0 branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. i18n-api Issues and PRs related to the i18n implementation. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @refack @benjamingr