-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: fix segfault with --without-intl #21589
Conversation
Node.js segfaults when build with `--without-intl` due to an oversight in d13cdd9. This fixes the issue.
@nodejs/releasers What is your preference for how to do these kinds of things? Revert the offending commit and then re-land? Or a patch fix like this one is fine? Or it doesn't matter either way? |
(The revert commit causes a test to fail so it will take some tweaking if we want to go that route. So I'd prefer this PR over a revert at this point...) |
Resume Build for CI: https://ci.nodejs.org/job/node-test-pull-request/15667/ |
arm-fanned Rebuild: https://ci.nodejs.org/job/node-test-binary-arm/2095/ |
arm-fanned rebuild (https://ci.nodejs.org/job/node-test-binary-arm/2095/) is green. Just waiting for node-test-commit-linux to finish. Everything is green except fedora-latest-x64 which will hopefully be finished running in another 10 minutes or so.... |
@refack For what it's worth, I often find the console on that shows the Always stops on |
@refack: It's doing it right now...stuck at |
I've seen that... But it was at 37 minutes, and it felt unhealthy... |
The one host under Linux that wasn't green was green this time. There is another host that is taking a long time, but that platform was green last time. Given the CI situation and the fast-track approval, I think piecing together a green CI from different places like that is acceptable. I'm going to land this. (Plus, this is easy to revert since it's a one-line change.) |
Landed in 1c30343 |
Node.js segfaults when build with `--without-intl` due to an oversight in d13cdd9. This fixes the issue. PR-URL: nodejs#21589 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Node.js segfaults when build with `--without-intl` due to an oversight in d13cdd9. This fixes the issue. PR-URL: #21589 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Node.js segfaults when build with
--without-intl
due to an oversightin d13cdd9. This fixes the issue.
This is an alternate to #21587 and was proposed in IRC by @devsnek and also @refack. But @devsnek doesn't have access to GitHub right now, so I'm submitting it to fast-track it and get CI green again.
Speaking of which: 👍 to fast-track.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes