dns: deprecate passing falsy hostname to dns.lookup #23173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can `dns.lookup` a falsy `hostname` like `dns.lookup(false)` for the reason of backwards compatibility long before(see nodejs#13119 for detail). This behavior is undocumented and seems useless in real world apps. We could also make invalid `hostname` throw in the future and the change might be semver-major. Fixes: nodejs#13119
addaleax
added
semver-major
|
If you look around for other uses of |
|
Oh, I thought they are only used in markdowns. Thanks, I'm going to add a deprecation code. |
oyyd
force-pushed
the
remove-dns-falsy-error
branch
from
1c636bc
to
197af1c
Compare
|
Add a new deprecation code and the travis ci is green now. |
addaleax
approved these changes
Sep 30, 2018
lpinca
reviewed
Sep 30, 2018
lundibundi
reviewed
Oct 1, 2018
bnoordhuis
approved these changes
Oct 1, 2018
jasnell
reviewed
Oct 1, 2018
jasnell
approved these changes
Oct 1, 2018
BridgeAR
approved these changes
Oct 1, 2018
BridgeAR
added
the
author ready
|
Re-run of failing node-test-commit-windows-fanned |
|
Landed in 26af728 🎉 Thanks for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Oct 4, 2018
We can `dns.lookup` a falsy `hostname` like `dns.lookup(false)` for the reason of backwards compatibility long before(see #13119 for detail). This behavior is undocumented and seems useless in real world apps. We could also make invalid `hostname` throw in the future and the change might be semver-major. Fixes: #13119 PR-URL: #23173 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
We can `dns.lookup` a falsy `hostname` like `dns.lookup(false)` for the reason of backwards compatibility long before(see #13119 for detail). This behavior is undocumented and seems useless in real world apps. We could also make invalid `hostname` throw in the future and the change might be semver-major. Fixes: #13119 PR-URL: #23173 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can
dns.lookupa falsyhostnamelikedns.lookup(false)for the reason of backwards compatibility long before(see #13119
for detail). This behavior is undocumented and seems useless in
real world apps.
We could also make invalid
hostnamethrow in the future and thechange might be semver-major.
Fixes: #13119
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes