Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: deprecate passing falsy hostname to dns.lookup #23173

Closed
wants to merge 7 commits into from
Closed

dns: deprecate passing falsy hostname to dns.lookup #23173

wants to merge 7 commits into from

Commits on Sep 30, 2018

  1. dns: deprecate passing falsy hostname to dns.lookup 

    We can `dns.lookup` a falsy `hostname` like `dns.lookup(false)`
for the reason of backwards compatibility long before(see nodejs#13119
for detail). This behavior is undocumented and seems useless in
real world apps.

We could also make invalid `hostname` throw in the future and the
change might be semver-major.

Fixes: nodejs#13119
    @oyyd
    oyyd committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    0ae969f View commit details
    Browse the repository at this point in the history

  2. dns: add deprecation code and fix tests

    @oyyd
    oyyd committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    197af1c View commit details
    Browse the repository at this point in the history

  3. dns: replace the deprecation number with a temporal placeholder

    @oyyd
    oyyd committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    8b0fcee View commit details
    Browse the repository at this point in the history

  4. dns: only emit warning once

    @oyyd
    oyyd committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    69a614f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2018

  1. dns: fix doc typo

    @oyyd
    oyyd committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    b73cc6d View commit details
    Browse the repository at this point in the history

  2. dns: fix doc typo

    @oyyd
    oyyd committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    e96c0a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. dns: fix doc typo

    @oyyd
    oyyd committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    a712c0a View commit details
    Browse the repository at this point in the history