Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused UVHandle methods #23535

Closed
wants to merge 1 commit into from

Conversation

MarianneDr
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 12, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@MarianneDr
Copy link
Contributor Author

I just talked to a mentor and they suggested a message to make sure CI is triggered for this - thank you!

@MarianneDr
Copy link
Contributor Author

Oh, I see it is queued! Never mind - I'm a newbie!

@addaleax
Copy link
Member

@MarianneDr We still have to kick off a full CI manually :) Also, I think this is not a trivial pull requests like many other Code&Learn PRs, so it may have to wait our standard 48 hours before we merge it – just as a heads up, it doesn’t mean that you have to do anything.

CI: https://ci.nodejs.org/job/node-test-pull-request/17769/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 12, 2018
@mscdex
Copy link
Contributor

mscdex commented Oct 12, 2018

Shouldn't this at least go through CITGM? I'm not sure what variety of C++ addons we have in there, but it seems like removing a public method like this isn't safe to just remove (especially within an existing versioned branch)?

@MarianneDr
Copy link
Contributor Author

Thank you for letting me know! Let me know what I need to do!

@addaleax
Copy link
Member

@mscdex This is no way a public method, and never has been. All headers that are modified here are guarded by #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS . It was used internally before d527dde and is unused now.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
PR-URL: nodejs#23535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
PR-URL: nodejs#23535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR
Copy link
Member

Landed in 0d6f014 🎉

@MarianneDr congratulations on your commit to Node.js!

@BridgeAR BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
PR-URL: #23535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
PR-URL: #23535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
PR-URL: #23535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #23535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
PR-URL: #23535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants