Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused UVHandle methods #23535

Closed
wants to merge 1 commit into from
Closed

src: remove unused UVHandle methods #23535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/connection_wrap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ namespace node {
template <typename WrapType, typename UVType>
class ConnectionWrap : public LibuvStreamWrap {
public:
UVType* UVHandle() {
return &handle_;
}

static void OnConnection(uv_stream_t* handle, int status);
static void AfterConnect(uv_connect_t* req, int status);

Expand Down
5 changes: 0 additions & 5 deletions src/tty_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,6 @@ void TTYWrap::Initialize(Local<Object> target,
}


uv_tty_t* TTYWrap::UVHandle() {
return &handle_;
}


void TTYWrap::GuessHandleType(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
int fd;
Expand Down
2 changes: 0 additions & 2 deletions src/tty_wrap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ class TTYWrap : public LibuvStreamWrap {
v8::Local<v8::Value> unused,
v8::Local<v8::Context> context);

uv_tty_t* UVHandle();

SET_NO_MEMORY_INFO()
SET_MEMORY_INFO_NAME(TTYWrap)
SET_SELF_SIZE(TTYWrap)
Expand Down
7 changes: 0 additions & 7 deletions src/udp_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
#include "req_wrap-inl.h"
#include "util-inl.h"



namespace node {

using v8::Array;
Expand Down Expand Up @@ -526,11 +524,6 @@ Local<Object> UDPWrap::Instantiate(Environment* env,
}


uv_udp_t* UDPWrap::UVHandle() {
return &handle_;
}


} // namespace node

NODE_MODULE_CONTEXT_AWARE_INTERNAL(udp_wrap, node::UDPWrap::Initialize)
2 changes: 0 additions & 2 deletions src/udp_wrap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ class UDPWrap: public HandleWrap {
static v8::Local<v8::Object> Instantiate(Environment* env,
AsyncWrap* parent,
SocketType type);
uv_udp_t* UVHandle();

SET_NO_MEMORY_INFO()
SET_MEMORY_INFO_NAME(UDPWrap)
SET_SELF_SIZE(UDPWrap)
Expand Down