net: improve error message when no address #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when use 'listen(80)' will get the 'listen EACCES null:80'. this fix will make the error message better. like 'listen EACCES 0.0.0.0:80'.
JacksonTian
force-pushed
the
refine_address
branch
from
e1a03ad to
5d7328a
Compare
|
ping @reviewers |
| @@ -1135,6 +1135,7 @@ Server.prototype._listen2 = function(address, port, addressType, backlog, fd) { | |||
| debug('_listen2: create a handle'); | |||
| var rval = createServerHandle(address, port, addressType, fd); | |||
| if (util.isNumber(rval)) { | |||
| address = address || '0.0.0.0'; | |||
There was a problem hiding this comment.
Will this work on machines that only have IPv6 configured?
There was a problem hiding this comment.
@cjihrig , the listen will fallback to IPv4, when IPv6 failed.
if (address || port || isTCP) {
debug('bind to ' + (address || 'anycast'));
if (!address) {
// Try binding to ipv6 first
err = handle.bind6('::', port);
if (err) {
handle.close();
// Fallback to ipv4
return createServerHandle('0.0.0.0', port);
}
} else if (addressType === 6) {
err = handle.bind6(address, port);
} else {
err = handle.bind(address, port);
}
}
There was a problem hiding this comment.
I didn't notice before that this is just for formatting an exception. I don't know how I feel about setting the value artificially just for that, but I'm OK with the rest of the PR.
|
fixed by #539 |
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when use 'listen(80)' will get the 'listen EACCES null:80'. this fix will
make the error message better. like 'listen EACCES 0.0.0.0:80'.