net: move default address logic to _listen2
#539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
missed this: #239 /cc @JacksonTian and @cjihrig But it seems to always report IPv4 address no matter what |
| @@ -68,6 +70,7 @@ server4.listen(common.PORT + 3, 127, function() { | |||
| process.on('exit', function() { | |||
| assert.ok(address0.port > 100); | |||
| assert.equal(common.PORT, address1.port); | |||
| assert.equal(connectionKey1, (address1.family === 'IPv6' ? '6::::' : '4:0.0.0.0:') + address1.port); | |||
When address is not provided to `server.listen()` `_connectionKey` and error messages should include actual address and correct family.
vkurchatkin
force-pushed
the
net-default-address
branch
from
31f020a to
9e12f58
Compare
|
@bnoordhuis ping |
bnoordhuis
pushed a commit
that referenced
this pull request
Jan 23, 2015
When address is not provided to `server.listen()`, `_connectionKey` and error messages should include actual address and correct family. PR-URL: #539 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
@vkurchatkin Sorry for the delay. Thanks, landed in 8de89ec! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When address is not provided to
server.listen()_connectionKeyand error messages should include actual address and correct family.Before:
After:
R=@bnoordhuis?