Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reach res._dump after abort ClientRequest #24191

Closed
wants to merge 3 commits into from
Closed

test: reach res._dump after abort ClientRequest #24191

wants to merge 3 commits into from

Conversation

tadhgcreedon
Copy link
Contributor

@tadhgcreedon tadhgcreedon commented Nov 6, 2018 •
edited
Loading

Adds test coverage to lib/_http_client.js by reaching a line of code inside a callback that gets registered on the 'response' event after aborting a client request, by emitting that event.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@addaleax addaleax added http Issues or PRs related to the http subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 6, 2018
@tadhgcreedon tadhgcreedon force-pushed the http-client-request-abort-response-dump branch from 73a1820 to 4359904 Compare November 7, 2018 10:33
@addaleax
Copy link
Member

@tadhgcreedon I’m not sure, but would it maybe make sense to test both cases here, e.g. by creating a new test file rather than modifying an existing one? I think this might be affecting the previous functionality of the test…

(/cc @nodejs/http)

@jasnell
Copy link
Member

jasnell commented Nov 10, 2018

Yeah, a separate new test file may be better

@tadhgcreedon
Copy link
Contributor Author

tadhgcreedon commented Nov 11, 2018 •
edited
Loading

Sure, makes sense. Will create a new test file then update.

@tadhgcreedon tadhgcreedon force-pushed the http-client-request-abort-response-dump branch from 3179181 to 1a544be Compare November 11, 2018 12:50
@oyyd
Copy link
Contributor

oyyd commented Nov 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18572/

@trivikr
Copy link
Member

trivikr commented Nov 13, 2018

Hi @tadhgcreedon, the author of the commits in this PR is not registered on GitHub (steps defined here)

Either:

  • add the email ID associated with the commit to GitHub
  • change the author of the commit to current email ID registered with the GitHub by following these steps

@tadhgcreedon tadhgcreedon force-pushed the http-client-request-abort-response-dump branch from 1a544be to c37a91d Compare November 13, 2018 17:23
@Trott
Copy link
Member

Trott commented Nov 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18594/

@oyyd
Copy link
Contributor

oyyd commented Nov 14, 2018

Resume: https://ci.nodejs.org/job/node-test-commit-windows-fanned/22295/

@Trott
Copy link
Member

Trott commented Nov 14, 2018

@addaleax LGTY?

thefourtheye
thefourtheye reviewed Nov 20, 2018
View reviewed changes
test/parallel/test-http-client-abort-response-event.js Outdated

req.end();
req.abort();
req.abort();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Havn't checked this completely, but two req.aborts are intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ping @tadhgcreedon Two abort() calls like that are intentional? If so, great. If not, can you remove one? Or I can totally remove one. Either way. I just want to see this get merged....

@Trott
Copy link
Member

Trott commented Nov 28, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18987/

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19013/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 29, 2018
@tadhgcreedon @Trott
test: reach res._dump after abort ClientRequest
f5b8853 
PR-URL: nodejs#24191
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 29, 2018

Landed in f5b8853.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 29, 2018
targos pushed a commit that referenced this pull request Nov 29, 2018
@tadhgcreedon @targos
test: reach res._dump after abort ClientRequest
e96c60e 
PR-URL: #24191
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
This was referenced Dec 8, 2018
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@tadhgcreedon @refack
test: reach res._dump after abort ClientRequest
4e20fbf 
PR-URL: nodejs#24191
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@tadhgcreedon @BethGriggs
test: reach res._dump after abort ClientRequest
06208c8 
PR-URL: #24191
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@tadhgcreedon @rvagg
test: reach res._dump after abort ClientRequest
a06d19f 
PR-URL: #24191
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefourtheye thefourtheye thefourtheye left review comments

@oyyd oyyd oyyd approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tadhgcreedon @addaleax @jasnell @oyyd @trivikr @Trott @thefourtheye @BethGriggs @nodejs-github-bot