v10.15.3 proposal #26063
Merged
v10.15.3 proposal #26063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
BethGriggs
force-pushed
the
v10.15.2-proposal
branch
from
fdf5db1 to
7a2f782
Compare
BethGriggs
added a commit
that referenced
this pull request
Feb 12, 2019
Notable Changes PR-URL: #26063
|
CI: https://ci.nodejs.org/job/node-test-pull-request/20746/ [PASSED] |
BethGriggs
force-pushed
the
v10.15.2-proposal
branch
from
7a2f782 to
c103ae2
Compare
BethGriggs
added a commit
that referenced
this pull request
Feb 13, 2019
Notable Changes PR-URL: #26063
|
Pushed an extra two bug fixes. CI2: https://ci.nodejs.org/job/node-test-pull-request/20764/ Kicked off an RC build. |
richardlau
approved these changes
Feb 13, 2019
BethGriggs
force-pushed
the
v10.15.2-proposal
branch
from
c103ae2 to
441a321
Compare
BethGriggs
added a commit
that referenced
this pull request
Feb 19, 2019
Notable Changes PR-URL: #26063
|
Is it possible to also include #25993 in this release? |
BridgeAR
reviewed
Feb 20, 2019
doc/api/tls.md
Outdated
| @@ -995,7 +995,7 @@ argument. | |||
| <!-- YAML | |||
| added: v0.11.13 | |||
| changes: | |||
| - version: REPLACEME | |||
| - version: v10.15.2 | |||
There was a problem hiding this comment.
It seems like this feature has never landed in v10.x (there is a backport for 10.x open. See #24979). I guess we should remove the changes entry until it actually lands?
There was a problem hiding this comment.
Ah good catch, i'll back that one out
BethGriggs
force-pushed
the
v10.15.2-proposal
branch
from
441a321 to
ac4c04b
Compare
BethGriggs
added a commit
that referenced
this pull request
Feb 20, 2019
Notable Changes PR-URL: #26063
BridgeAR
approved these changes
Feb 21, 2019
|
We discussed postponing this by a week at the last TSC meeting due to the security releases. I'm not sure if that got spread around further than that meeting. So this is going to have to be 10.15.3. |
Merged
Backport-PR-URL: #25005 PR-URL: #23934 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Original commit message: Merged: [wasm] Fix dispatch table instance update This CL fixes a bug where the receiving instance was updated improperly in the dispatch table(s) of an imported table. BUG=chromium:875322 R=mstarzinger@chromium.org CC=titzer@chromium.org Change-Id: Iff24953a1fb6a8ab794e12a7a976d544b56fc3c2 Originally-reviewed-on: https://chromium-review.googlesource.com/1196886 No-Try: true No-Presubmit: true No-Treechecks: true Reviewed-on: https://chromium-review.googlesource.com/1212922 Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/branch-heads/6.9@{#45} Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1} Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{#54504} Refs: v8/v8@442977e PR-URL: #25242 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Original commit message:
inspector: return [[StableObjectId]] as internal property
This property might be useful for fast '===' check.
R=dgozman@chromium.org,yangguo@chromium.org
Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56095}
PR-URL: #25330
PR-URL: #25058 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
For consistency with the API docs, switch the order of --http-parser and --force-fips in node.1. PR-URL: #25045 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Otherwise this is global state that may be subject to race conditions e.g. when running `perf_hooks` inside of Worker threads. Tracking the GC type is removed entirely since the variable was unused. PR-URL: #25053 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit combines two related if statements into an if-else statement. PR-URL: #25054 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit enables ESLint's no-useless-constructor rule. Note that the documentation examples that only include constructor calls were left in tact. PR-URL: #25055 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Test didn't require child process creation. While this test has not been unstable, child process creation is slower and can be flaky in ci, so test directly for the segfault regression. PR-URL: #25025 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Several secureProtocol strings allow any supported TLS version as the maximum, but our maximum supported protocol version is TLSv1.2 even if someone configures a build against an OpenSSL that supports TLSv1.3. Fixes: #24658 PR-URL: #25024 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Simplify material about TSC approval for breaking changes. Omit extraneous material explaining that purely additive changes are not breaking changes. PR-URL: #25071 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>
1. Move the apilinks.json file into out/doc so it gets cleaned when running `make docclean` 2. When the apilinks.json generated is empty, throw a specific error so it's easier to understand what's wrong 3. Write to a file passed through CLI arguments instead writing to stdout in apilinks.js so the build process is more robust in the case of a bad binary PR-URL: #25019 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25056 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was essentially a typo that went unnoticed because we didn’t have tests for this particular situation. Fixes: #24647 PR-URL: #24654 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Loose map comparison had an logic error. It will now be properly compared. PR-URL: #24749 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Comparing sparse arrays did not work properly. That is fixed and tests were added to verify that everything works as expected. This had an impact on `util.isDeepStrictEqual()` and `assert.deepStrictEqual()` and their counterpart `assert.notDeepStrictEqual()`. PR-URL: #24749 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs
force-pushed
the
v10.15.2-proposal
branch
from
ac4c04b to
9f70f19
Compare
BethGriggs
added a commit
that referenced
this pull request
Feb 28, 2019
Notable Changes PR-URL: #26063
|
Rebased, new CIs CI: https://ci.nodejs.org/job/node-test-pull-request/21050/ [Green] |
BridgeAR
approved these changes
Feb 28, 2019
rvagg
reviewed
Mar 1, 2019
|
|
||
| * **Coming soon** | ||
|
|
||
| ### Commits |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
BethGriggs
force-pushed
the
v10.15.2-proposal
branch
from
9f70f19 to
1a96d83
Compare
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Mar 5, 2019
BethGriggs
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-03-05, Version 10.15.3 'Dubnium' (LTS), @BethGriggs
Notable Changes
Commits
732088dd44] - assert: fix loose deepEqual map comparison (Ruben Bridgewater) #247495a81a4f6cd] - assert,util: fix sparse array comparison (Ruben Bridgewater) #24749bd08ede3ab] - buffer: remove checkNumberType() (cjihrig) #24815fde56fa748] - build: make lint-addon-docs run only if needed (Daniel Bevenius) #249938d4d3963e0] - build: fix compiler version detection (Richard Lau) #24879552a5c080a] - build: add '.git' to 'make lint-py' exclude list (cclauss) #2480202e9a93d2c] - build: fix check-xz for platforms defaulting to sh (Rod Vagg) #24841920cab76cf] - build: make tar.xz creation opt-out, fail if no xz (Rod Vagg) #24551b72bc11a93] - build: fix line length off by one error (Ruben Bridgewater) #2474818d81c94a6] - build: add line break as soon tests are done (Ruben Bridgewater) #24748c57008e549] - build: fix c++ code coverage on macOS (Refael Ackermann) #2452095a3b3e142] - build: replace-notwith!infind(Rich Trott) #2463532d93cde01] - build, tools, win: add .S files support to GYP (Bartosz Sosnowski) #24553a2155e1010] - crypto: harden bignum-to-binary conversions (Ben Noordhuis) #247196f4e30d029] - crypto: convert to arrow function (yosuke ota) #245973b9fd0881a] - deps: V8: cherry-pick 3cc6919 (milad) #2587270322ea2ca] - deps: V8: cherry-pick d0468de (Milad Farazmand) #25827c9a3e401da] - deps: cherry-pick d9fbfeb from upstream V8 (Alexey Kozyatinskiy) #25330e20e3472a4] - deps: V8: backport 442977e (Ali Ijaz Sheikh) #252428af4f44130] - dns: simplify dns.promises warning logic (cjihrig) #24788cfd5773f8d] - doc: document fs.write limitation with TTY (Matteo Collina) #2457189ba5f41c8] - doc: revise "Breaking Changes" section of Collaborator Guide (Rich Trott) #250717382e8f648] - doc: fix node.1 --http-parser sort order (cjihrig) #2504566e6c2a88b] - doc: add EventTarget link to worker_threads (Azard) #25058d1f19a033c] - doc: make README formatting more consistent (wenjun ye) #250031880f23ed2] - doc: add codebytere's info to release team (Shelley Vohr) #250228f434414a4] - doc: revise internal vs. public API in Collaborator Guide (Rich Trott) #249758ae649d105] - doc: update a link of npm repository (Daijiro Wachi) #249699ffa8270b1] - doc: fix author-ready conflict (Ruben Bridgewater) #25015bdf21c1f10] - doc: update Useful CI Jobs section of Collaborator Guide (Rich Trott) #24916f8ac170608] - doc: add class worker documentation (yoshimoto koki) #24849f68ff0619c] - doc: remove bad link to irc info (Richard Lau) #249670701559336] - doc: simplify author ready (Ruben Bridgewater) #24893e7e8a25bb8] - doc: update "Testing and CI" in Collaborator Guide (Rich Trott) #24884a7f36dde00] - doc: update http doc for new Agent()/support options in socket.connect() (Beni von Cheni) #24846e9ad526297] - doc: fix order of events when request is aborted (Luigi Pinca) #24779189d2e2ab2] - doc: revise Waiting for Approvals documentation (Rich Trott) #24845f2df92cfc0] - doc: list all versions WHATWG URL api was added (Thomas Watson) #248472b03878de3] - doc: add authority and scheme psuedo headers (Kenigbolo Meya Stephen) #2477723cd76e9ef] - doc: add triaging section to releases.md (Beth Griggs) #20165f52ff588e2] - doc: use author's titles for linked resources (Rich Trott) #248370a3c88551a] - doc: revise code review guidelines (Rich Trott) #247907bd7328f0d] - doc: add a note on usage scope of AliasedBuffer (Gireesh Punathil) #24724184425e7e8] - doc: hide undocumented object artifacts in async_hooks (Gireesh Punathil) #24741ad40e781af] - doc: fix added version of randomFill+randomFillSync (Thomas Watson) #2481256916c8430] - doc: streamline Accepting Modifications in Collaborator Guide (Rich Trott) #248077ae17573e6] - doc: make release README link be consistent with text (ZYSzys) #247831c593c8192] - doc: cookie is joined using '; ' (Gerhard Stoebich) #247403e4b93ac8e] - doc: add antsmartian to collaborators (Anto Aravinth) #24655fe698d8ca0] - doc: revise accepting-modifications in guide (Rich Trott) #24650546f9419d7] - doc: clarify symlink resolution for __filename (Rich Trott) #24587a1a393bfbf] - doc: use arrow function for anonymous callbacks (koki-oshima) #246066788d856d5] - doc: revise handling-own-pull-requests text (Rich Trott) #24583bda73542be] - doc: fix duplicate "this" and "the" on http2.md (Yusuke Kawasaki) #2461173b99c7013] - doc: replace anonymous function with arrow function (ka2jun8) #246171eeb37c39c] - doc: use arrow function (sadness_ojisan) #24590283172771e] - doc: replace anonymous function with arrow function (yuriettys) #24627dd5bfd7f74] - doc: mark napi_add_finalizer experimental (Michael Dawson) #24572dacdd0113f] - esm: refactor dynamic modules (Myles Borins) #24560576d9c513a] - fs: simplify fs.promises warning logic (cjihrig) #24788741c5ef6cd] - http: fix error check inExecute()(Brian White) #25863f4aed8c3df] - http2: make compat writeHead not crash if the stream is destroyed (Matteo Collina) #24723d12c5a7a75] - http2: add compat support for nested array headers (Sebastiaan Deckers) #24665c7f876be38] - http2: fix session[kSession] undefined issue (leeight) #24547e8dfdc063d] - lib: ensure readable stream flows to end (Mikko Rantanen) #24918d5d8670783] - lib: remove some useless assignments (Gus Caplan) #2319996036ef798] - lib: do not register DOMException in a module (Joyee Cheung) #24708ef68349617] - lib: move setupAllowedFlags() into per_thread.js (Joyee Cheung) #247041b48c9d9e3] - lib: convert to arrow function in fs.js (exoego) #24604eaa5e3efa4] - lib: change callbacks to arrow function (/Jesse) #246254eec736a5e] - lib: chenged anonymous function to arrow function (nakashima) #246058c93bd4d17] - lib: rearm pre-existing signal event registrations (Gireesh Punathil) #246518f427eb987] - lib: convert to arrow function (horihiro) #24623e5abfe191e] - lib: convert to Arrow Function (Daiki Arai) #24615ccefef2d45] - lib: suppress crypto related env vars in help msg (Daniel Bevenius) #245561c2ce239a1] - lib: convert to arrow function (Naojirou Hisada) #24596c87af34886] - lib: change anonymous function to arrow function (takato) #24589ce2aa807f5] - lib: simplify own keys retrieval (Vse Mozhet Byt) #245829daf175483] - lib: fix nits in lib/internal/bootstrap/cache.js (Vse Mozhet Byt) #24581f2287c61e1] - module: use validateString in modules/esm (ZYSzys) #24868229f901a0f] - module: use validateString in modules/cjs (ZYSzys) #24863fe0e119f55] - n-api: handle reference delete before finalize (Michael Dawson) #24494760277e490] - n-api,test: remove last argument in assert.strictEqual() (susantruong) #24584f6e07fd809] - net: use strict comparisons for fd (cjihrig) #250147eda47e5c9] - path: replace assertPath() with validator (cjihrig) #2484033a907de20] - perf_hooks: make GC tracking state per-Environment (Anna Henningsen) #25053931a04e37e] - process: fix omitting--fromprocess.execArgv(Anna Henningsen) #24654a4068d9827] - process: properly close file descriptor on exit (Ruben Bridgewater) #24972fd8a481a12] - process: simplify check in previousValueIsValid() (cjihrig) #248365bca4c7cc0] - process: emit unhandled warning immediately (Anatoli Papirovski) #24632944e75d10b] - src: emit 'params' instead of 'data' for NodeTracing.dataCollected (Kelvin Jin) #249491cc5834180] - src: add GetLoadedLibraries routine (Gireesh Punathil) #24825fa84e91813] - src: create env->inspector_console_api_object earlier (Joyee Cheung) #2490612f0485c8c] - src: remove use of CallOnForegroundThread() (cjihrig) #2492516a1f96d6e] - src: do not alias new and old signal masks (Sam Roberts) #24810f0e7b2f509] - src: fix warning for potential snprintf truncation (Sam Roberts) #248107455597815] - src: remove finalized_ member from Hash class (Daniel Bevenius) #2482237047fc70a] - src: use arraysize instead of hardcode number (leeight) #24473eb20e3d23e] - src: set HAS_USERNAME/PASSWORD more strictly (Timothy Gu) #244954444cdb6cd] - src: elevate v8 namespaces referenced (Juan José Arboleda) #2465728a1cc1377] - src: simplify uptime and ppid return values (cjihrig) #245628c48302a50] - src: elevate v8 namespaces for node_url.cc (Jayasankar) #24573863d1987a3] - src: elevate v8 namespaces of node_trace_events.cc (Jayasankar) #2446926f7edbf71] - src: re-sort the symbol macros (Sam Roberts) #24382450bcde462] - src: use v8:: for consistency in util (ZYSzys) #239343f969d61ff] - stream: re-use existingonce()implementation (Anna Henningsen) #24991bb8a65dd84] - stream: fix end-of-stream for HTTP/2 (Anna Henningsen) #24926e356ce851f] - stream: make async iterator .next() always resolve (Matteo Collina) #24668e338e50213] - stream: use arrow function for callback (DoiChris) #246096be2d6187c] - test: improve comparison coverage to 100% (Ruben Bridgewater) #247491d083e29e5] - test: test internal/util/types in vm (ZYSzys) #2505656c6686fe5] - test: merge test with unnecessary child process (Sam Roberts) #25025ee054110b5] - test: remove unnecessary linter comment (cjihrig) #25013c9b0a36989] - test: use global.gc() instead of gc() (cjihrig) #25012bcfc1d1a7d] - test: run eslint on test file and fix errors (Ruben Bridgewater) #2500917527981d0] - test: remove dead code (Ruben Bridgewater) #2500948c54137d4] - test: use blocks instead of async IIFE (Anna Henningsen) #2498954d7e82530] - test: adding history regression test case (Anto Aravinth) #24843dd2b553874] - test: mark test-child-process-execfile flaky (Rich Trott) #25051bfa396a81e] - test: mark test-child-process-exit-code flaky (Rich Trott) #2505055680e3ecb] - test: mark test-worker-memory flaky on Windows CI (Rich Trott) #2504289b6d1b1fa] - test: mark test-child-process-execsync flaky on AIX (Rich Trott) #2503111d5c07c7d] - test: refactor test-enable-in-init (Mitch Hankins) #249760658424227] - test: from functools import reduce in test/testpy/__init__.py (cclauss) #249543bdff05cdb] - test: improve internet/test-dns (Ilarion Halushka) #249273f2c6ce9aa] - test: replace callback with arrows (Shubham Urkade) #248662869b7810d] - test: mark test-cli-syntax as flaky/unreliable (Rich Trott) #2495783c6f0a86e] - test: do not lint macros files (again) (cclauss) #24886a67d37d226] - test: prepare test/pseudo-tty/testcfg.py Python 3 (cclauss) #248874e51e3d550] - test: move test-cli-syntax to sequential (Rich Trott) #24907e20ad2e446] - test: move http2 test to parallel (Rich Trott) #248771a1811d1e0] - test: make http2 timeout test robust (Rich Trott) #24877a2dd3a62a7] - test: fix wrong parameter (zhmushan) #248441dff257280] - test: improve test-net-socket-timeout (Rich Trott) #248595e29865375] - test: prepare test/pseudo-tty/testcfg.py for Python 3 (cclauss) #24791520d041afb] - test: refactor test-fs-write-file-sync.js (cjihrig) #24834b1bbac726e] - test: prepare test/message/testcfg.py for Python 3 (cclauss) #24793ff90d17eb3] - test: remove unused addons-napi directory (Rich Trott) #24839d08b5e94f5] - test: add .gitignore file for node-api (Rich Trott) #24839546fc68ae4] - test: fixcommon.mustNotCall()usage in HTTP test (Anna Henningsen) #247501c746c7524] - test: use ES2017 syntax in test-fs-open-* (jy95) #23031e17dbd22c3] - test: add flag scenario in test-fs-write-file-sync (Gireesh Punathil) #24766fd5af6bfa9] - test: check invalid argument error for option (timothy searcy) #2473646e37adf59] - test: show stdout and stderr in test-cli-syntax when it fails (Joyee Cheung) #2472031c1ee405e] - test: minor refactoring of onticketkeycallback (Daniel Bevenius) #24718a7c72d7d5e] - test: mark test_threadsafe_function/test as flaky (Gireesh Punathil) #24714e74345b2f5] - test: verify order of error in h2 server stream (Myles Borins) #24685288a421dcc] - test: cover path empty string case (lakatostamas) #24569d4b1666686] - test: use arrow syntax for anonymous callbacks (Shubham Urkade) #24691af582096ad] - test: fix the arguments order in assert.strictEqual (pastak) #24620e89f5e59ea] - test: mark test-vm-timeout-escape-nexttick flaky (Gireesh Punathil) #24712288d60c2f6] - test: fix the arguments order in assert.strictEqual (sigwyg) #246249f66105e29] - test: fix the arguments order inassert.strictEqual(rt33) #2462606208c8313] - test: reach res._dump after abort ClientRequest (Tadhg Creedon) #2419185e948753b] - test: validate fs.rename() when NODE_TEST_DIR on separate mount (Drew Folta) #247075966dbed05] - test: test and docs for detached fork process (timothy searcy) #245241c609bf6e2] - test: fix arguments order inassert.strictEqual(sota1235) #24607dc7ed30437] - test: fix arguments order in assert.strictEqual (grimrose) #24608be17cc59c7] - test: make test-uv-binding-constant JS engine neutral (Rich Trott) #246662318c7fea3] - test: use arrow function (sagirk) #2448243bfb136f9] - test: fix arguments order inassert.strictEqual(Takahiro Nakamura) #246213811817290] - test: update strictEqual argument order (VeysonD) #24622ec7bd18146] - test: fix argument order in assert.strictEqual (feng jianmei) #245944cc91ff2b5] - test: use arrow functions in callbacks (apoorvanand) #244414093572c4d] - test: add test for socket.end callback (ajido) #240877dee5e5d16] - test: replace anonymous closure functions with arrow functions (tpanthera) #2444382d9ffc6a6] - test: fix arguments order inassert.strictEqual(tottokotkd) #24612372073e8da] - test: convert callback to arrow function (jamesgeorge007) #2451382376015ab] - test: change anonymous function to arrow function (Gagandeep Singh) #245285e3b34fbfd] - test: split out http2 from test-stream-pipeline (Rich Trott) #24631b6cceae96f] - test: cover path.basename when path and ext are the same (Laszlo.Moczo) #245707f0fb163a0] - test: fix assert.strictEqual (mki-skt) #24619e464a1dca5] - test: fix arguments order in assert.strictEqual (teppeis) #24591ec70330dab] - test: fix http2-binding strictEqual order (dominikeinkemmer) #246167b096026d8] - test: fix the arguments order inassert.strictEqual(sota1235) #245951658924d90] - test: replace callback with arrow functions (prodroy1) #244340e63d0abd5] - test: confirm tls server suite default is its own (Sam Roberts) #243743c2b40ba04] - test: rename agent1-pfx.pem to agent1.pfx (Sam Roberts) #2437443dcbbedb9] - test: add independent multi-alg crypto identities (Sam Roberts) #2437483145ec3a6] - test: cover tls multi-identity option mixtures (Sam Roberts) #2437477cf877ea2] - tls: re-define max supported version as 1.2 (Sam Roberts) #25024027ca95b46] - tools: make apilinks building more robust (Joyee Cheung) #25019694ea008d1] - tools: enable no-useless-constructor lint rule (cjihrig) #250555cbc0dbeaf] - tools: prepare ./tools/compress_json.py for Python 3 (cclauss) #2488987f20822c1] - tools: prepare tools/testp.py for Python 3 (cclauss) #2489091a96e446a] - tools: prepare tools/icu/icutrim.py for Python 3 (cclauss) #2488834212b531f] - tools: update ESLint to 5.10.0 (cjihrig) #24903229c0e0cc9] - tools: do not lint tools/inspector_protocol or tools/markupsafe (cclauss) #24882bece371639] - tools: prepare tools/js2c.py for Python 3 (cclauss) #24798e6afaa350b] - tools: prepare tools/specialize_node_d.py for Python 3 (cclauss) #24797544a20f37c] - tools: prepare tools/test.py for Python 3 (cclauss) #24799388ec8d77c] - tools: prepare tools/genv8constants.py for Python 3 (cclauss) #24801039097e276] - tools: prepare tools/install.py for Python 3 (cclauss) #24800f21137976e] - tools: fix eslint usage for Node.js 8 and before (Ruben Bridgewater) #24753691e1a69ff] - tools: don't use GH API for commit message checks (Rod Vagg) #24574f5f1266326] - tools: only sign release if promotion successful (Rod Vagg) #24669cc880fbeeb] - tools: check for git tag before promoting release (Rod Vagg) #246708a5b5e1fd0] - tools: use print() function on both Python 2 and 3 (cclauss) #24486f9933ff2c8] - tools,doc: fix version picker bug in html.js (Rich Trott) #24638b3932ef8e3] - url: remove an eslint-disable comment (cjihrig) #24995c0423cf34c] - url: simplify native URL object construction (Timothy Gu) #24495d06ea3e505] - url: reuse existing context in href setter (Timothy Gu) #244954e111ce050] - Revert "url: make the context non-enumerable" (Timothy Gu) #244957048cba388] - url: use SafeSet to filter known special protocols (Mike Samuel) #247038d953b7d26] - vm: simplify Script constructor options validation (cjihrig) #25054134d1e9526] - vm: add dynamic import support (Gus Caplan) #22381595bdc7603] - win, build: skip building cctest by default (Bartosz Sosnowski) #21408483ff7bcc7] - worker: drain messages from internal message port (Yael Hermon) #24932