-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src, test: fix V8 compiler warnings #24246
Conversation
Re-run of failing node-test-commit-windows-fanned. |
+1 for squashing all |
02979eb
to
7cfe2cf
Compare
@refack is this in a state that it can be rebased, squashed, and landed? The compiler warnings are currently a bit much 😄 |
No rebase CI: https://ci.nodejs.org/job/node-test-pull-request/18515/ |
7cfe2cf
to
2bd09a7
Compare
This commit changes the code to use the maybe version.
2bd09a7
to
1537d39
Compare
Re-run of failing /node-test-commit-freebsd ✔️ |
This commit changes the code to use the maybe version. PR-URL: #24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
This commit changes the code to use the maybe version. PR-URL: #24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
This commit changes the code to use the maybe version. PR-URL: nodejs#24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: nodejs#24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
@danbev this is a bit of a large backport and it definitely won't land cleanly, do you think it should be backported to |
@codebytere I think this can be skipped but if anyone thinks differently let me know and I can take a look at backporting it. |
PR-URL: #24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
This pull request follows up on #24060 and attempts to fix all the remaining v8 warnings regarding Set/Get.
There is currently one warning still being generated from [src/node.cc](a525283#diff-cd53544f44aab2c697bcd7b6a57f23ccR675-677)I've left a comment in the code as I was not sure how to get the correct context. Hopefully someone can help out and advise on this.The commits are currently separate for each C++ source file but can be squashed unless anyone objects.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes