v10.15.1 proposal #25346
Merged
v10.15.1 proposal #25346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
The fixed-size buffer on the stack is unnecessary and way too large for most applications. This change removes it and allocates the required memory directly instead of copying into heap later. PR-URL: #23427 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #23734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Introduced use of smart pointers instead of MallocedBuffer to manage memory allocated in the cares library. PR-URL: #23628 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Picking a path according to a boolean is essentially free, compared to the cost of a function call. Also, remove an unnecessary `TryCatch`. PR-URL: #23782 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
The convertProtocols() function now throws a range error when the byte length of a protocol is too long to fit in a Buffer. Also added a test case in test/parallel/test-tls-basic-validations.js to cover this. PR-URL: #23606 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Using `process.nextTick()` or `Promise`, it is possible to escape the `timeout` set when running code with `vm.runInContext()`, `vm.runInThisContext()`, and `vm.runInNewContext()`. This documents the issue and adds two known_issues tests. Refs: #3020 PR-URL: #23743 Refs: #3020 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Those categories are necessary to build addons that depends on libcurl and libssh, the following were the missing symbols: libcurl: OCSP_cert_status_str OCSP_check_validity OCSP_basic_verify OCSP_RESPONSE_free OCSP_single_get0_status OCSP_response_get1_basic OCSP_BASICRESP_free OCSP_crl_reason_str OCSP_resp_count OCSP_response_status OCSP_response_status_str OCSP_resp_get0 d2i_OCSP_RESPONSE SSL_CTX_set_next_proto_select_cb libssh: EVP_ripemd160 EVP_cast5_cbc Fixes: #23293 PR-URL: #23344 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Instead of getting a reference to the main `AliasedBuffer`, which would always unnecesarily allocate and destroy a `Persistent` handle, store and use a reference to the owning object. PR-URL: #23844 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Right now `node -p process.versions.openssl` always gets run in the Makefile even when it's not needed by the target (e.g. `make clean`, `make test-only`). This patch makes it a run time call instead of part of the global expansion. PR-URL: #24115 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
PR-URL: #24130 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24131 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Lazy load _http_common and HTTPParser so that the 'http_parser' binding can be monkey patched before any internal modules require it. This also probably improves startup performance minimally for programs that never require the HTTP stack. Fixes: #23716 Fixes: creationix/http-parser-js#57 PR-URL: #24006 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #24133 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Swapped the actual and expected arguments in `assert.strictEqual()` calls. Arguments are now in correct order. Literal value is now the second argument and the value returned by the function is the first argument. PR-URL: #24134 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
PR-URL: #24137 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
`assert.strictEqual` expects arguments in the following order: actual, expected[, message] PR-URL: #24138 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24142 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Switched arguments in assert.strictEqual() PR-URL: #24144 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #24146 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
These tests ensure that OutgoingMessage setTimeout method will call setTimeout on its socket Co-authored-by: ZauberNerd <zaubernerd@zaubernerd.de> PR-URL: #24148 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #24152 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
File: test/parallel/test-http-client-upload-buf.js PR-URL: #24140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
the actual and expected arguments in assert.strictEqual() calls are in the wrong order. Any literal value should be the second argument while the first argument should be the value returned by a function/be the calculated value. PR-URL: #24151 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
In the `test/parallel/test-vm-create-and-run-in-context.js` test the actual and expected arguments in the `assert.strictEqual()` call on line 32 are in the wrong order and they have to be switched around. PR-URL: #24141 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #24147 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #24155 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #24213 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #24160 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #24490 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #24480 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
- Using arrow functions in test-tls-client-resume.js
- Fixed error, Expected parentheses around arrow function
argument arrow-parens
PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24489 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
In `test/parallel/test-cluster-send-deadlock.js`, callbacks use anonymous closure functions. It is safe to replace them with arrow functions since these callbacks don't contain references to `this`, `super` or `arguments`. This results in shorter functions. PR-URL: #24479 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24540 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: #24542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24522 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #24433 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24525 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
test-fs-stat-bigint.js failed once in CI but there wasn't enough information to know what was giong on. Adding a bit of information to the assertion that failed in case it fails again. PR-URL: #24566 Refs: #24565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
PR-URL: #24526 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24527 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #24531 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #24541 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24459 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #24455 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
force-pushed
the
v10.15.1-proposal
branch
from
69bb4d0 to
3867ef0
Compare
|
one more CI for posterity https://ci.nodejs.org/job/node-test-pull-request/20408/ CITGM looked good, spurious failures in CI due to infra issues |
MylesBorins
approved these changes
Jan 29, 2019
PR-URL: #25346
codebytere
force-pushed
the
v10.15.1-proposal
branch
from
3867ef0 to
7840f71
Compare
codebytere
added a commit
that referenced
this pull request
Jan 29, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-01-29, Version 10.15.1 'Dubnium' (LTS), @codebytere
Notable Changes
Commits
fbf5321dcf] - async_hooks: add HandleScopes to C++ embedder/addon API (Anna Henningsen) #242850c206e0d6d] - benchmark: support more options in startup benchmark (Joyee Cheung) #242209a64ceca39] - buffer: fix writeUInt16BE range check (Brian White) #242080b81054d17] - build: fix Python detection when depot_tools are in PATH in Windows (Guy Bedford) #22539b61a51c4f5] - build: remove sudo:false from .travis.yml (Rich Trott) #245115c3736a772] - build: use print() function in configure.py (cclauss) #244845d2dadccff] - build: check minimum ICU in configure for system-icu (Steven R. Loomis) #2425531376d9a97] - build: remove unnecessary prerequisite in Makefile (Rich Trott) #2434233fd13c5ce] - build: fix benchmark tests on CI (Rich Trott) #2430707b7db2f81] - build: use BUILDTYPE in bench-addons-build targets (Daniel Bevenius) #240334e21eb4004] - build: lint commit message in separate Travis job (Richard Lau) #24254042749fd23] - build: only try to find node when it's needed by the target (Joyee Cheung) #2411572d2d2cd8e] - build: expose more openssl categories for addons (Jonathan Cardoso Machado) #23344dc5647f71b] - build,tools: update make-v8.sh for ppc64le (Refael Ackermann) #242935dfc1bb46c] - build,tools: update make-v8.sh for s390x (Refael Ackermann) #2383904f8d6bffd] - child_process: allow 'http_parser' monkey patching again (Jimb Esser) #240063ef68d8d97] - cli: add missing env vars to --help (cjihrig) #243834f13ac7941] - console: improve code readability (gengjiawen) #2441207b9a663e0] - console: cover .assert with single argument (Morgan Roderick) #241884749640b2e] - crypto: reduce memory usage of SignFinal (Tobias Nießen) #23427733cb1ef84] - deps: cherry-pick b87d408 from upstream V8 (Peter Marshall) #2427217b55bf1a4] - deps: V8: cherry-pick 52a9e67 (Ali Ijaz Sheikh) #25027185ccedf7c] - doc: clarify who may land on an LTS staging branch (Myles Borins) #244653283186934] - doc: reviseauthor readyexplanation (Rich Trott) #24558f918ad8e98] - doc: add readable and writable property to Readable and Writable (Dexter Leng) #23933d288a395f6] - doc: move trott to tsc emeritus (Rich Trott) #24492f0602f8df3] - doc: add Ruben Bridgewater to release team (Ruben Bridgewater) #23432b1bbedd701] - doc: edit COLLABORATOR_GUIDE.md on closing issues (Rich Trott) #2447708284dcdd8] - doc: move Timothy to TSC emeritus (Timothy Gu) #245356bb860cd20] - doc: add NODE_DEBUG_NATIVE to API docs (cjihrig) #24383ef1056f4bd] - doc: add missing env variables to man page (cjihrig) #2438340c9ee028b] - doc: minor cleanup of tls.getProtocol() (Sam Roberts) #24533c16b93233c] - doc: add Beth Griggs to release team (Beth Griggs) #24532492e2a4d11] - doc: add filehandle.write(string[, position[, encoding]]) (Dara Hayes) #23224a620c25c76] - doc: udpate list item spacing in changelogs (Rich Trott) #243917fd4ef7df1] - doc: update crypto examples to not use deprecated api (Mayank Asthana) #241072734c20bd9] - doc: simplify first-time contributors section of Collaborator Guide (Rich Trott) #24387e11d46cb84] - doc: adjusting formatting when printing (Thomas Hunter II) #24325c19d6e26a3] - doc: better linkage to node-addon-api (Michael Dawson) #24371ae3a19486f] - doc: update collaborator guide with LTS labels (Charalampos Fanoulis) #24379e111d71e60] - doc: document http request.finished boolean (Thomas Watson) #243191ca3c9d3e2] - doc: document NODE_TLS_REJECT_UNAUTHORIZED (cjihrig) #2428968aecff860] - doc: clarify issues and pull requests guidance (Rich Trott) #24316ac3e264f1c] - doc: fix comma splices in process.md (Rich Trott) #24357672879f406] - doc: use real protocol names in ALPN example (Sam Roberts) #242328a60798f4c] - doc: update core-validate-commit url (Daijiro Wachi) #24331a9a6cb1b06] - doc: fix echo example programs (Sam Roberts) #2423590f3f5e88f] - doc: clarify allowed encoding parameter types (Sam Roberts) #242304209e122b7] - doc: correct async_hooks resource names (Gerhard Stoebich) #24001d2cc9d72b6] - doc: sort bottom-of-file markdown links (Sam Roberts) #24679b4c1d8273c] - doc: update fs.open() changes record for optional 'flags' (Rod Vagg) #24240cf209171c9] - doc: add links to Stream section (Dmitry Igrishin) #243010260db525a] - doc: correct async_hooks sample outputs (Gerhard Stoebich) #24050c8d2635ed1] - doc: add oyyd to collaborators (Ouyang Yadong) #24300b305db8634] - doc: edit BUILDING.md (Rich Trott) #24243abe3edad48] - doc: fix code examples in stream.md (Grant Carthew) #2411231441f42c4] - doc: describe what tls servername is for (Sam Roberts) #24236cc688bb23f] - doc: fix some inconsistent use of hostname (Sam Roberts) #241996f3bc0d28a] - doc, test: document and test vm timeout escapes (James M Snell) #23743ef8c1deda6] - doc,meta: update PR approving info (Vse Mozhet Byt) #24561be56fb7ab9] - events: extract listener check as a function (ZYSzys) #243034a16a4da45] - fs: inline typeof check (dexterleng) #2439035d2397ae5] - http: remove obsolete function escapeHeaderValue (Lauri Piisang) #241738df4a168b3] - http2: replace unreachable error with assertion (Rich Trott) #244075516fbf1d7] - http2: order declarations in http2.js (ZYSzys) #244115e3c6799cb] - http2: elevate v8 namespaces of repeated references (Gagandeep Singh) #244534246a40b30] - lib: move encodeStr function to internal for reusable (ZYSzys) #242426bd055f7de] - lib: refactor setupInspector in bootstrap/node.js (leeight) #2444662a5679ca3] - lib: set stderr._destroy to dummyDestroy (Joyee Cheung) #243983450a4c536] - lib: gather all errors constant in the same place for consistency (ZYSzys) #240385c2c5b9094] - lib: improved conditional check in zlib (Dan Corman) #241907527632235] - lib: adjust params from uvExceptionWithHostPort (msmichellegar) #241593966b698f6] - lib: combine contructor, tag, Object into a function (Paul Isache) #24171c84b420457] - Revert "net: partially revert "simplify Socket.prototype._final"" (Anna Henningsen) #242900c2d1d57e8] - net: add comments explaining error check (Steven Gabarro) #242222d0105c751] - net: remove unreachable check in internalConnect (Philipp Dunkel) #24158897114bf94] - net: partially revert "simplify Socket.prototype._final" (Anna Henningsen) #2428810a27277ad] - net: simplify Socket.prototype._final (Anna Henningsen) #24075b7876ba6e1] - src: elevate namespaces for repeated entities (Sarath Govind K K) #244754b82aa80fe] - src: elevate namespaces of repeated artifacts (Maya Anilson) #24429bfde244576] - src: elevate repeated use of v8 namespaced type (Shubham Urkade) #24427be14283bcd] - src: use smart pointers in cares_wrap.cc (Daniel Bevenius) #23813fa52ba621b] - src: elevate v8 namespaces of referenced artifacts (Kanika Singhal) #244249a69d030ce] - src: reuse std::make_unique (alyssaq) #2413244a1993e9d] - src: avoid extraPersistentinDefaultTriggerAsyncIdScope(Anna Henningsen) #2384415d05bbf02] - src: simplifyTimerFunctionCall()innode\_perf.cc(Anna Henningsen) #23782383d512ed7] - src: memory management using smart pointer (Uttam Pawar) #23628ffb4087def] - src: remove function hasTextDecoder in encoding.js (Chi-chi Wang) #23625fa60eb83be] - stream: correctly pause and resume after once('readable') (Matteo Collina) #24366a7c1d0908a] - stream: do not use crypto.DEFAULT_ENCODING in lazy_transform.js (Joyee Cheung) #24396965098a8ca] - stream: change comment on duplex stream options (Jesse W. Collins) #242476ce4ef3387] - stream: make.destroy()interact better with write queue (Anna Henningsen) #24062bdab2e98f1] - test: mark test-cli-node-options flaky on arm (Rich Trott) #25032e5c4759eab] - test: use destructuring on require (Juan José Arboleda) #24455cb860870cd] - test: fix test case in test-child-process-fork-dgram.js (gengjiawen) #244599d7cb1f6d7] - test: replace callback with arrow functions (sreepurnajasti) #24541a9795f701d] - test: replace callback with arrow function (potham) #24531088b0db932] - test: replace anonymous function with arrow (Gagandeep Singh) #24527083925def0] - test: replace anonymous function with arrow (Gagandeep Singh) #2452695ba7615d1] - test: add information to assertion (Rich Trott) #24566313eaf958d] - test: replace anonymous function with arrow func (Gagandeep Singh) #245251ec6923276] - test: compare objects not identical by reference (Marie Terrier) #241896b904f6799] - test: change anonymous closure function to arrow function (Nethra Ravindran) #2443346e63a2a78] - test: replace closure functions with arrow functions (Gagandeep Singh) #245228e6729bb82] - test: replace anonymous function with arrow function (Gagandeep Singh) #2452954abfda5d3] - test: favor arrow function in callback (Pranay Kothapalli) #24542d82c0de250] - test: remove unused reject handlers (Dan Foley) #24540e0a11142b4] - test: refactor test to use arrow functions (sagirk) #244797dd64858c2] - test: replace closure with arrow function (Maya Anilson) #24489d71a607a09] - test: using arrow functions (NoSkillGirl) #244365b1fd6e246] - test: replace anonymous closure with arrow func (suman-mitra) #24480b7b6c12510] - test: replace callback with arrow functions (sreepurnajasti) #24490e02d553f7b] - test: replcae anonymous closure with arrow function (Sarath Govind K K) #24476351e69d5c5] - test: refactor test-http-write-empty-string to use arrow functions (sagirk) #24483d245f53db4] - test: replace anonymous closure with arrow functions (suman-mitra) #244818734c679f8] - test: add whatwg-encoding TextDecoder custom inspection with showHidden (ZauberNerd) #241667920e7bfb4] - test: replace anonymous closure functions with arrow functions (sagirk) #24478283a6b86bb] - test: replace anonymous closure functions with arrow function (Abhishek Dixit) #2442066c3dcab72] - test: replace anonymous closure with arrow funct (Prabu Subra) #24439e7d41c0312] - test: modify order of parameters for assertion (Mrityunjoy Saha) #24430164069cdb0] - test: replace closure with arrow functions (kanishk30) #24440f129e2c063] - test: replace anonymous closure function with arrow function (Kunda Sunil Kumar) #2443594553b2ea5] - test: add typeerror test for EC crypto keygen (Matteo) #244004425926452] - test: change anonymous closure functions to arrow functions (Namit Bhalla) #2441840773c0f2a] - test: use print() function on both Python 2 and 3 (cclauss) #244852ffbde3963] - test: favor arrow functions in callbacks (UjjwalUpadhyay) #244258f7326c369] - test: replace anonymous closure functions with arrow function (Amanpreet) #24417644a9d6919] - test: fix arguments order in napi test_exception (kanishk30) #24413abe9778ea4] - test: fix the arguments order inassert.strictEqual(Jay Arthanareeswaran) #2441694d200fe46] - test: replace closure with arrow functions (Amanpreet) #24438380da0473a] - test: change callback function to arrow function (Jay Arthanareeswaran) #244195ad224d6ae] - test: fix the arguments order inassert.strictEqual(apoorvanand) #2443152259d71d6] - test: assertion equality fix (NoSkillGirl) #244222d25cddbc1] - test: remove unused function arguments in async-hooks tests (Simon Bruce) #24406c29c510b5a] - test: fix actual parameter order for 'assert.strictEqual' (Selvaraj) #24428bf3bed56db] - test: swap actual&optional params (Nikhil M) #24426d2d6287355] - test: skip test that use --tls-v1.x flags (Daniel Bevenius) #2437639a561b3bc] - test: change callback function to arrow function (Lakshmi Shanmugam) #24421f4c2d9efbc] - test: replace anonymous closure for test-http-expect-handling.js (Jayasankar) #24423cf7bf27325] - test: replace callback functions with arrow functions (potham) #24432518bc9679d] - test: use arrow functions for callbacks (Pushkal B) #2444453973fde9d] - test: replace anonymous closure function (Jayasankar) #24415555ef65042] - test: fixed the arguments order inassert.strictEqual(Lakshmi Shanmugam) #244143b6135ff2c] - test: use destructuring and remove unused arguments (Julia) #243758c8199211b] - test: https agent clientcertengine coverage (Osmond van Hemert) #24248987df276cb] - test: remove unused function arguments in async-hooks tests (Rich Trott) #24368585db59b0a] - test: add typeerror for vm/compileFunction params (Dan Corman) #241796cad1b6877] - test: deep object to table not covered (Osmond van Hemert) #24257916ead940d] - test: add tests for Socket.setNoDelay (James Herrington) #24250fbdfd608dd] - test: add process no deprecation (razvanbh) #24196b29b23546d] - test: fix arguments order in assertions (Emanuel Kluge) #24149d4fd76a782] - test: remove unused parameters in function definition (Paul Hodgson) #24268817d871327] - test: esm loader unknown builtin module (Fran Herrero) #241838728361533] - test: fixed order of actual and expected arguments (kiyomizumia) #24178e21d784cf8] - test: add else and error case for TextDecoder (Lauri Piisang) #24162aba7b47e5c] - test: url format path ending hashchar not covered (Osmond van Hemert) #242599970d562c6] - test: test add and remove for lib/domain (Petar Dodev) #2416351643c208e] - test: fix args order in process-getactiverequests (Vladyslav Kopylash) #24186454ede2d90] - test: check control characters replacing (Alessandro Gatti) #241824d1a80363a] - test: fix v8 Set/Get compiler warnings (Daniel Bevenius) #24246a30f5a02b8] - test: fix flaky test-vm-timeout-escape-nexttick (Rich Trott) #242511bceb9d397] - test: fix test-repl-envvars (Anna Henningsen) #25226d04c3c2718] - test: move benchmark tests out of main test suite (Rich Trott) #2426509bb49165f] - test: fix strictEqual argument order (Martin Kask) #24153704d886000] - test: correct order of args in assert.strictEqual() (Natalie Cluer) #2415763dc2214f9] - test: add test case for completion bash flag (Aivo Paas) #24168dd67f39ae2] - test: add test for deepEqual Float32Array (Yehiyam Livneh) #241642359273868] - test: fix arguments order in assert.strictEqual() (Ulises Santana Suárez) #241923bb63721e3] - test: fix assert.strictEqual argument order (John Mc Quillan) #24172a6f786dee9] - test: replacing fixture directory with temp (saurabhSiddhu) #24077704b68aee4] - test: increase coverage internal readline (Berry de Witte) #24150d8ac55a012] - test: use NULL instead of 0 in common.h (Daniel Bevenius) #241044b9518dba3] - test: move test-fs-watch-system-limit from sequential to pummel (Marcus Scott) #236924054c24cac] - test: fix uses of deprecated assert.fail with multiple args (ivan.filenko) #23673c417c7a89a] - test: use assert.strictEqual instead of assert.equal (ivan.filenko) #236731b5b1cc08b] - test: add test for strictDeepEqual (Nikita Malyschkin) #24197cd2dedfa4f] - test: add coverage for systemerror set name (Amer Alimanović) #242009fa71468f5] - test: fix order of arguments in assert.strictEqual (Alex Seifert) #241452d6e942035] - test: add test for 'ERR_INVALID_CALLBACK' (razvanbh) #24224540b741ae2] - test: add coverage for escape key switch case (Artur Daschevici) #2419453b12c3731] - test: fix NewFromUtf8 compiler warning (Daniel Bevenius) #242168e9ff69d7f] - test: add error code tests in dgram test (Mark Arranz) #24215e57a5c3734] - test: fix order of arguments in test-delayed-require assertion (reineke-fox) #24165d7a3a3bd9f] - test: change arguments order in strictEqual (Paul Isache) #24156efd697bc57] - test: switch order of strictEqual arguments (Jonah Polack) #241859052a22dd1] - test: fix the arguments order inassert.strictEqual(mzucker) #24227d7722dd9d8] - test: fix the arguments order inassert.strictEqual(mzucker) #242262e0d3c9de9] - test: fix order in assert.strictEqual to actual, expected (Kevin Seidel) #24184b63e9cb3fe] - test: fix arguments order in assert.strictEqual (szabolcsit) #24143e0c6f5cbf7] - test: fix assert argument order (Manish Poddar) #24160fc84ccd0f0] - test: removed extraneous argument 's' (Jackson Chui) #2421390f98905f1] - test: fix arguments order in test-fs-write-buffer (razvanbh) #241551588fba73f] - test: fix argument order in assert.strictEqual() (Clement) #24147f46fa9072a] - test: switch arguments in strictEqual (Mathieu Pavageau) #241418f2bdaca69] - test: fix arguments order (Simona Cotin) #24151380789eb68] - test: fixe argument order in assert.strictEqual (Marc Posth) #24140cd07b02472] - test: fixing arguments order inassert.strictEqual()(G. Carcaci) #241526e8fa5361a] - test: add tests for OutgoingMessage setTimeout (Robin Drexler) #24148abf9bd15db] - test: swap expected and actual in assert.strictEqual (Florin-Daniel BÎLBÎE) #24146f0eee63ee0] - test: fix assert parameter order (Roland Broekema) #2414478a320130d] - test: change order of assert.strictEqual() (Remy Parzinski) #2414264fd19f102] - test: fix invalid argument order in test-http-expect-continue.js (Morgan Roderick) #241382d88af354f] - test: strictEqual argument order (actual, expected) (Ahmad Nassri) #2413711a84a7b32] - test: swap the order of arguments (Musa Hamwala) #24134e599889649] - test: fs readfile, swap arguments in strictEqual (Petar Dodev) #24133c37b3196b6] - test: fix arguments order (Fran Herrero) #2413174f1dad613] - test: http-client-timeout error assert arguments (Tadhg Creedon) #24130b16311b19f] - test: mark test-vm-timeout-* known issue tests flaky (James M Snell) #237430f6a9524f8] - tls: destroy TLS socket if StreamWrap is destroyed (Anna Henningsen) #242900c73221699] - tls: do not rely on 'drain' handlers in StreamWrap (Anna Henningsen) #242903170cb49d8] - tls: throw if protocol too long (Andre Jodat-Danbrani) #23606cc4d866697] - tools: update to remark-lint-preset-node@1.2.0 (Rich Trott) #2439121843c7659] - tools: fixmake lint-md-rollupand run it (Daijiro Wachi) #24333e8e93df148] - tools: update remark-lint to v6.0.3 from v6.0.2 (Daijiro Wachi) #243332bed68f341] - tools: update remark version to v10 from v8 (Daijiro Wachi) #2433339ccf1461e] - tools: update ESLint to 5.9.0 (cjihrig) #24280a1d7ed7de6] - tracing: fix static destruction order issue (Anna Henningsen) #241238c107a37f9] - url: make the context non-enumerable (Joyee Cheung) #24218eeb4715a56] - util: remove unreachable branch (rahulshuklab4u) #244477576a518b8] - util: deleted unreachable code from util.inspect (kiyomizumia) #24187c6a43fa2ef] - zlib: do not leak on destroy (Mathias Buus) #23734