async_hooks: add HandleScopes to C++ embedder/addon API #24285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `HandleScope`s to the public C++ API for embedders/addons, since these methods create V8 handles that should not leak into the outer scopes. In particular, for some of the methods it was not clear from the function signatures that these functions previously needed to be invoked with a `HandleScope`.
nodejs-github-bot
added
the
c++
addaleax
added
the
async_hooks
devsnek
approved these changes
Nov 10, 2018
jasnell
approved these changes
Nov 10, 2018
addaleax
added
the
author ready
joyeecheung
approved these changes
Nov 11, 2018
|
Failures in job https://ci.nodejs.org/job/node-test-pull-request/18507/ ubuntu1604_sharedlibs_debug_x64See failures on test-joyent-ubuntu1604_sharedlibs_container-x64-4:ubuntu1604_sharedlibs_openssl110_x64See failures on test-digitalocean-ubuntu1604_sharedlibs_container-x64-6:ubuntu1604_sharedlibs_shared_x64See failures on test-digitalocean-ubuntu1604_sharedlibs_container-x64-4:ubuntu1604_sharedlibs_withoutintl_x64See failures on test-digitalocean-ubuntu1604_sharedlibs_container-x64-10:ubuntu1604_sharedlibs_zlib_x64See failures on test-digitalocean-ubuntu1604_sharedlibs_container-x64-2:Resume: https://ci.nodejs.org/job/node-test-pull-request/18531/ |
|
@joyeecheung I think that’s my fault (#24288) 😄 Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/18531/ |
|
Landed in fcd7a72 |
addaleax
added a commit
that referenced
this pull request
Nov 13, 2018
Add `HandleScope`s to the public C++ API for embedders/addons, since these methods create V8 handles that should not leak into the outer scopes. In particular, for some of the methods it was not clear from the function signatures that these functions previously needed to be invoked with a `HandleScope`. PR-URL: #24285 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
Add `HandleScope`s to the public C++ API for embedders/addons, since these methods create V8 handles that should not leak into the outer scopes. In particular, for some of the methods it was not clear from the function signatures that these functions previously needed to be invoked with a `HandleScope`. PR-URL: #24285 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
Add `HandleScope`s to the public C++ API for embedders/addons, since these methods create V8 handles that should not leak into the outer scopes. In particular, for some of the methods it was not clear from the function signatures that these functions previously needed to be invoked with a `HandleScope`. PR-URL: nodejs#24285 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
Add `HandleScope`s to the public C++ API for embedders/addons, since these methods create V8 handles that should not leak into the outer scopes. In particular, for some of the methods it was not clear from the function signatures that these functions previously needed to be invoked with a `HandleScope`. PR-URL: #24285 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
HandleScopes to the public C++ API for embedders/addons,since these methods create V8 handles that should not leak into
the outer scopes.
In particular, for some of the methods it was not clear from
the function signatures that these functions previously
needed to be invoked with a
HandleScope.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes