Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced the pattern to (args)=> #24434

Closed
wants to merge 1 commit into from
Closed

replaced the pattern to (args)=> #24434

wants to merge 1 commit into from

Conversation

prodroy1
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos approved these changes Nov 17, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should start with test: replace ...

test/parallel/test-https-close.js Outdated Show resolved Hide resolved
test/parallel/test-https-close.js Outdated Show resolved Hide resolved
test/parallel/test-https-close.js Outdated Show resolved Hide resolved
Trott
Trott previously requested changes Nov 22, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs suggestions from @targos applied

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18878/

addaleax
addaleax reviewed Nov 23, 2018
View reviewed changes
test/parallel/test-https-close.js Outdated
@@ -37,7 +37,7 @@ function shutdown() {
}
}

server.listen(0, function() {
server.listen(0, () => {
const requestOptions = {
hostname: '127.0.0.1',
port: this.address().port,
Copy link
Member

@addaleax addaleax Nov 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function uses this, which is affected by the function vs arrow function distinction – I think you need to change this refernce?

Suggested change
port: this.address().port,
port: server.address().port,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks.

@targos
Copy link
Member

targos commented Nov 23, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18897/

@gireeshpunathil
Copy link
Member

@Trott - PTAL.

@Trott Trott dismissed their stale review November 24, 2018 06:26

changes made

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 24, 2018
@prodroy1 @Trott
test: replace callback with arrow functions
e214069 
PR-URL: nodejs#24434
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member

Trott commented Nov 24, 2018

Landed in e214069.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 24, 2018
targos pushed a commit that referenced this pull request Nov 24, 2018
@prodroy1 @targos
test: replace callback with arrow functions
28146d2 
PR-URL: #24434
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@prodroy1 @rvagg
test: replace callback with arrow functions
1067653 
PR-URL: #24434
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@prodroy1 @refack
test: replace callback with arrow functions
8572368 
PR-URL: nodejs#24434
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@prodroy1 @BethGriggs
test: replace callback with arrow functions
1658924 
PR-URL: #24434
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@prodroy1 @rvagg
test: replace callback with arrow functions
93ab4d2 
PR-URL: #24434
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@targos targos targos approved these changes

@Trott Trott Trott left review comments

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@prodroy1 @gireeshpunathil @targos @Trott @addaleax @trivikr @BethGriggs @nodejs-github-bot