crypto: convert to arrow function in lib/internal/crypto/cipher.js
#24597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed function expression to arrow function.
nodejs-github-bot
added
the
crypto
ronkorving
added
the
code-and-learn
addaleax
approved these changes
Nov 24, 2018
ronkorving
approved these changes
Nov 24, 2018
gireeshpunathil
approved these changes
Nov 24, 2018
|
fast-track? pls 👍 |
cjihrig
approved these changes
Nov 24, 2018
gireeshpunathil
added
the
author ready
|
landed as 519923f thank you @ota-meshi for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 26, 2018
Changed function expression to arrow function. PR-URL: #24597 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2018
Changed function expression to arrow function. PR-URL: #24597 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Changed function expression to arrow function. PR-URL: #24597 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Changed function expression to arrow function. PR-URL: nodejs#24597 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 11, 2019
Changed function expression to arrow function. PR-URL: #24597 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Changed function expression to arrow function. PR-URL: #24597 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed function expression to arrow function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes