Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promises: emit unhandled warning immediately #24632

Closed
wants to merge 1 commit into from
Closed

promises: emit unhandled warning immediately #24632

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

@apapirovski apapirovski commented Nov 24, 2018 •
edited
Loading

Fixes: #24209

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@apapirovski build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1697/pipeline

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Nov 24, 2018
@apapirovski apapirovski mentioned this pull request Nov 24, 2018
Closed
@Trott
Copy link
Member

Trott commented Nov 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18947/

@addaleax
Copy link
Member

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18960/

@addaleax addaleax added promises Issues and PRs related to ECMAScript promises. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 25, 2018
@Trott
Copy link
Member

Trott commented Nov 28, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18974/

@Trott
Copy link
Member

Trott commented Nov 28, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18979/

@Trott
Copy link
Member

Trott commented Nov 28, 2018

Landed in 3ce9305

@Trott Trott closed this Nov 28, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
@apapirovski @Trott
process: emit unhandled warning immediately
3ce9305 
PR-URL: nodejs#24632
Fixes: nodejs#24209
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Nov 28, 2018
@apapirovski @targos
process: emit unhandled warning immediately
81b42d2 
PR-URL: #24632
Fixes: #24209
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@apapirovski @refack
process: emit unhandled warning immediately
2650643 
PR-URL: nodejs#24632
Fixes: nodejs#24209
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@apapirovski @BethGriggs
process: emit unhandled warning immediately
5bca4c7 
PR-URL: #24632
Fixes: #24209
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@apapirovski @rvagg
process: emit unhandled warning immediately
664eed6 
PR-URL: #24632
Fixes: #24209
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@benjamingr benjamingr benjamingr approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. process Issues and PRs related to the process subsystem. promises Issues and PRs related to ECMAScript promises.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression: UnhandledPromiseRejection is not fired until process is terminated
8 participants
@apapirovski @nodejs-github-bot @Trott @addaleax @fhinkel @benjamingr @devsnek @BethGriggs