test: bailout test-vm-timeout-escape-nexttick

[gireeshpunathil]

This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Ref: #24620
Ref: #24120
/cc @Trott

[nodejs-github-bot]

@gireeshpunathil build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1716/pipeline

[Trott]

Is the entry respected when it includes the directory name like this? (I honestly don't know. We don't use it elsewhere, so regardless, for consistency, perhaps we shouldn't use it here?)

Suggested change

	known_issues/test-vm-timeout-escape-nexttick: PASS,FLAKY
	test-vm-timeout-escape-nexttick: PASS,FLAKY

[gireeshpunathil]

@Trott - thanks, fixed.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/19025/

[Trott]

Collaborators, 👍 here to fast-track.

[richardlau]

nit: Prefer if the commit message was something like test: mark test-vm-timeout-escape-nexttick as flaky to be more consistent with other similar commits.

[gireeshpunathil]

@richardlau - thanks, done. unfortunately the commit header often runs on a thin line between being 50 chars or less and being a meaningful phrase; often the length of the test case name limits every other creativity possible with the words. :) In this case, the standard was not possible as it steps few chars out of the limit; so I coined something to fit the meaning and the length.

[Trott]

@gireeshpunathil We've relaxed the "must be 50 chars or less" requirement to be more of a "try to make it 50 chars or less" guideline. The commit message linting only warns now, rather than throws an error, if the first line is more than 50 chars.

From https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines:

contain a short description of the change (preferably 50 characters or less, and no more than 72 characters)

And yeah, keeping it to 50 chars when you are including a long test name (or even when you're not!) can be quite a challenge sometimes.

On a meta issue: One problem we have is that we have too many rules, often with subtle variations, scattered across too many files. So it's really not surprising that nobody (very much including me) can keep all the rules straight. Automation helps. Additionally, I personally hope we can consolidate things and try to get rid of rule variations as much as possible. For example, we should take anything useful out of the onboarding-extras.md doc and put it in some other existing document, then get rid of onboarding-extras.md. Then do the same for probably about 8 other files. :-D

[Trott]

CI again (only because force-push--it was good the first time): https://ci.nodejs.org/job/node-test-pull-request/19027/

[Trott]

Collaborators: Can we fast track this? 👍 here to approve.

This test is a real problem for CI reliability as it is failing rather frequently on Pi 1 devices and takes a long time for the Raspberry Pi devices to rerun the test suite. I would love to see this fast-tracked so we could get CI to yellow at least.

[Trott]

Landed in 9e33e86. Thanks @gireeshpunathil!