New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert,util: fix comparison #24749

Closed

BridgeAR wants to merge 3 commits into nodejs:master from BridgeAR:fix-comparison

Member

BridgeAR commented Nov 30, 2018

Please have a look at the commit messages.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

BridgeAR added 3 commits

November 30, 2018 10:17


          assert: fix loose deepEqual map comparison

2a21991

Loose map comparison had an logic error. It will now be properly
compared.


          assert,util: fix sparse array comparison

02c2bd7

Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.


          test: improve comparison coverage to 100%

d851e08

Collaborator

nodejs-github-bot commented Nov 30, 2018

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1743/pipeline

nodejs-github-bot added the util label

addaleax approved these changes

View reviewed changes

targos approved these changes

View reviewed changes

Member Author

BridgeAR commented Nov 30, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/19082/

BridgeAR added the author ready label

Member Author

BridgeAR commented Dec 3, 2018 •

edited

Loading

Resumed build https://ci.nodejs.org/job/node-test-commit/23891/ ✔️

BridgeAR added a commit to BridgeAR/node that referenced this pull request


          assert: fix loose deepEqual map comparison

2eff120

Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BridgeAR added a commit to BridgeAR/node that referenced this pull request


          assert,util: fix sparse array comparison

4dd56a3

Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BridgeAR added a commit to BridgeAR/node that referenced this pull request


          test: improve comparison coverage to 100%

2f11fe3

PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

Member Author

BridgeAR commented Dec 3, 2018

Landed in e00639e...2f11fe3

BridgeAR closed this

BridgeAR added a commit that referenced this pull request


          assert: fix loose deepEqual map comparison

7fb8d31

Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BridgeAR added a commit that referenced this pull request


          assert,util: fix sparse array comparison

Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BridgeAR added a commit that referenced this pull request


          test: improve comparison coverage to 100%

5f58928

PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BridgeAR mentioned this pull request

v11.4.0 proposal #24854

Merged

4 tasks

This was referenced Dec 7, 2018

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264

Closed

2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265

Closed

refack pushed a commit to refack/node that referenced this pull request


          assert: fix loose deepEqual map comparison

a0740f1

Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

refack pushed a commit to refack/node that referenced this pull request


          assert,util: fix sparse array comparison

6ee8d61

Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

refack pushed a commit to refack/node that referenced this pull request


          test: improve comparison coverage to 100%

781764c

PR-URL: nodejs#24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BethGriggs pushed a commit that referenced this pull request


          assert: fix loose deepEqual map comparison

732088d

Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BethGriggs pushed a commit that referenced this pull request


          assert,util: fix sparse array comparison

5a81a4f

Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BethGriggs pushed a commit that referenced this pull request


          test: improve comparison coverage to 100%

6be2d61

PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BethGriggs mentioned this pull request

v10.15.3 proposal #26063

Merged

BethGriggs pushed a commit that referenced this pull request


          assert: fix loose deepEqual map comparison

b461597

Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BethGriggs pushed a commit that referenced this pull request


          assert,util: fix sparse array comparison

6fe174d

Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

rvagg pushed a commit that referenced this pull request


          assert: fix loose deepEqual map comparison

9da4af7

Loose map comparison had an logic error. It will now be properly
compared.

PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

rvagg pushed a commit that referenced this pull request


          assert,util: fix sparse array comparison

30aa8b2

Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.

This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.

PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BethGriggs added the backported-to-v10.x label

BridgeAR deleted the fix-comparison branch

January 20, 2020 11:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready util