Fix warnings about -Wrestrict and -Wformat-truncation #24810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc 8+ recognizes that space has not been left for the pid and that the return value of snprintf() isn't checked. Leave a little space for the pid to prevent `-Wformat-truncation`.
In recent gcc, -Wrestrict warns when an argument passed to a restrict-qualified parameter aliases with another argument.
sam-github
added
the
semver-major
nodejs-github-bot
added
c++
|
Can you explain the semver label? It’s not obvious to me :) |
sam-github
commented
Dec 3, 2018
| @@ -116,7 +116,8 @@ std::string GetHumanReadableProcessName() { | |||
| } | |||
|
|
|||
| void GetHumanReadableProcessName(char (*name)[1024]) { | |||
| char title[1024] = "Node.js"; | |||
| // Leave room after title for pid, which can be up to 20 digits for 64 bit. | |||
| char title[1000] = "Node.js"; | |||
There was a problem hiding this comment.
@addaleax see ---^ I'm OK with it not being semver-major, but if there was a process-name longer than 1000 chars, it would now be slightly truncated. How paranoid should we be? I'll let someone else decide.
There was a problem hiding this comment.
I think this is okay, given that names of that length are very unlikely, and we mostly only use this for debugging purposes?
sam-github
removed
the
semver-major
richardlau
approved these changes
Dec 7, 2018
|
Landed in bcef949...c49d87e |
sam-github
added a commit
that referenced
this pull request
Dec 7, 2018
gcc 8+ recognizes that space has not been left for the pid and that the return value of snprintf() isn't checked. Leave a little space for the pid to prevent `-Wformat-truncation`. PR-URL: #24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
sam-github
added a commit
that referenced
this pull request
Dec 7, 2018
In recent gcc, -Wrestrict warns when an argument passed to a restrict-qualified parameter aliases with another argument. PR-URL: #24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 7, 2018
gcc 8+ recognizes that space has not been left for the pid and that the return value of snprintf() isn't checked. Leave a little space for the pid to prevent `-Wformat-truncation`. PR-URL: #24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 7, 2018
In recent gcc, -Wrestrict warns when an argument passed to a restrict-qualified parameter aliases with another argument. PR-URL: #24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
gcc 8+ recognizes that space has not been left for the pid and that the return value of snprintf() isn't checked. Leave a little space for the pid to prevent `-Wformat-truncation`. PR-URL: nodejs#24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
In recent gcc, -Wrestrict warns when an argument passed to a restrict-qualified parameter aliases with another argument. PR-URL: nodejs#24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
gcc 8+ recognizes that space has not been left for the pid and that the return value of snprintf() isn't checked. Leave a little space for the pid to prevent `-Wformat-truncation`. PR-URL: #24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
In recent gcc, -Wrestrict warns when an argument passed to a restrict-qualified parameter aliases with another argument. PR-URL: #24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
gcc 8+ recognizes that space has not been left for the pid and that the return value of snprintf() isn't checked. Leave a little space for the pid to prevent `-Wformat-truncation`. PR-URL: #24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
In recent gcc, -Wrestrict warns when an argument passed to a restrict-qualified parameter aliases with another argument. PR-URL: #24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
gcc 8+ recognizes that space has not been left for the pid and that the return value of snprintf() isn't checked. Leave a little space for the pid to prevent `-Wformat-truncation`. PR-URL: #24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
In recent gcc, -Wrestrict warns when an argument passed to a restrict-qualified parameter aliases with another argument. PR-URL: #24810 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes