Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor test fixes for addons-napi / napi-api #24839

Closed
wants to merge 7 commits into from
Closed

minor test fixes for addons-napi / napi-api #24839

wants to merge 7 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 4, 2018

Collaborators, 👍 here to fast-track.

/cc @gabrielschulhof

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 4, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1832/pipeline

@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Dec 4, 2018
@Trott Trott mentioned this pull request Dec 4, 2018
Closed
4 tasks
@Trott
Copy link
Member Author

Trott commented Dec 4, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19213/ ✔️

@Trott
Copy link
Member Author

Trott commented Dec 5, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19214/ ✔️

@Trott
Copy link
Member Author

Trott commented Dec 5, 2018

Landed in a845d7a...06e5afa

@Trott Trott closed this Dec 5, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 5, 2018
@Trott
test: add .gitignore file for node-api
61e332b 
Refs: nodejs#24557 (comment)

PR-URL: nodejs#24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Dec 5, 2018
@Trott
test: remove unused addons-napi directory
06e5afa 
Refs: nodejs#24557 (comment)

PR-URL: nodejs#24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@Trott @BridgeAR
test: add .gitignore file for node-api
a240d41 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@Trott @BridgeAR
test: remove unused addons-napi directory
e26eb08 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@Trott @BridgeAR
test: add .gitignore file for node-api
7069ed7 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@Trott @BridgeAR
test: remove unused addons-napi directory
0ed669c 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@Trott @BridgeAR
test: add .gitignore file for node-api
b1b3448 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@Trott @BridgeAR
test: remove unused addons-napi directory
cf567f4 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: add .gitignore file for node-api
28de0e5 
Refs: nodejs#24557 (comment)

PR-URL: nodejs#24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: remove unused addons-napi directory
71459d8 
Refs: nodejs#24557 (comment)

PR-URL: nodejs#24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@Trott @BethGriggs
test: add .gitignore file for node-api
d08b5e9 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@Trott @BethGriggs
test: remove unused addons-napi directory
ff90d17 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@Trott @BethGriggs
test: add .gitignore file for node-api
3388922 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@Trott @BethGriggs
test: remove unused addons-napi directory
9da0683 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
test: add .gitignore file for node-api
da55d16 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
test: remove unused addons-napi directory
80c9282 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@Trott Trott deleted the napi-updates branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @danbev @cjihrig @richardlau