Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update http doc for new Agent()/support options in socket.connect() #24846

Closed
wants to merge 2 commits into from
Closed

doc: update http doc for new Agent()/support options in socket.connect() #24846

wants to merge 2 commits into from

Conversation

BeniCheni
Copy link
Contributor

@BeniCheni BeniCheni commented Dec 5, 2018 •
edited
Loading

Refs #24098, list the supported options in socket.connect() for new Agent() signature in http doc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Dec 5, 2018
vsemozhetbyt
vsemozhetbyt reviewed Dec 5, 2018
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
@BeniCheni
Copy link
Contributor Author

Thanks, @vsemozhetbyt. Updated to use a separate note for socket.connect's options, and correct the link to a bottom reference. Ready for review when convenient.

vsemozhetbyt
vsemozhetbyt approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc format LGTM.

@vsemozhetbyt
Copy link
Contributor

cc @nodejs/http

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2018
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1865/

@Trott
Copy link
Member

Trott commented Dec 8, 2018

Landed in 22564b9

@Trott Trott closed this Dec 8, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 8, 2018
@BeniCheni @Trott
doc: update http doc for new Agent()/support options in socket.connect()
22564b9 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: nodejs#24098

PR-URL: nodejs#24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BeniCheni BeniCheni deleted the doc-agent-newable-options branch December 8, 2018 23:02
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
@BeniCheni @BethGriggs
doc: update http doc for new Agent()/support options in socket.connect()
81dce68 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BeniCheni @refack
doc: update http doc for new Agent()/support options in socket.connect()
f073cda 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: nodejs#24098

PR-URL: nodejs#24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BeniCheni @BethGriggs
doc: update http doc for new Agent()/support options in socket.connect()
a7f36dd 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@BeniCheni @BethGriggs
doc: update http doc for new Agent()/support options in socket.connect()
e566bdc 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@BeniCheni @rvagg
doc: update http doc for new Agent()/support options in socket.connect()
478c191 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BeniCheni @vsemozhetbyt @Trott @lpinca @trivikr @BethGriggs @nodejs-github-bot