doc: list all versions WHATWG URL api was added #24847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@watson sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
doc
|
Just discovered a few other places in the URL docs where the |
watson
changed the title
|
I updated the PR to be a complete makeover of the |
lpinca
approved these changes
Dec 5, 2018
sam-github
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
LGTM. Also, I think its a general problem in the YAML annotations, I added a issue to track it: #24850
watson
added
author ready
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
approved these changes
Dec 5, 2018
|
@sam-github forgot to mention you in the above comment, so here it goes ^ |
|
Landed in 7868b6a |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2018
PR-URL: nodejs#24847 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 6, 2018
PR-URL: #24847 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 7, 2018
PR-URL: #24847 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 7, 2018
PR-URL: #24847 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24847 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24847 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
PR-URL: #24847 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24847 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally WHATWG URL api support was added in v7.x but was later backported to v6.13.0. This PR updates the docs to show support for the WHATWG URL api in that version + adds missing
added:info to a few functions that were missing it which were added in in v10.12.0.Question: Should I remove v7.0.0 from theUpdate: After I've seen it rendered, I think it makes sense to show both.added:list, or does it give historical context to see that it was added to v7.0.0 first and then later backported to v6.13.0?Checklist