Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: removing unused arguments, and conversion ES6 arrow function common.mustCall #24976

Closed
wants to merge 1 commit into from
Closed

test: removing unused arguments, and conversion ES6 arrow function common.mustCall #24976

wants to merge 1 commit into from

Conversation

mitchhankins01
Copy link

@mitchhankins01 mitchhankins01 commented Dec 12, 2018 •
edited
Loading

test: removing unused arguments, and conversion ES6 arrow function common.mustCall

  • Removed unused arguments to common.mustCall callback
  • Converted callback in common.mustCall to ES6 arrow function syntax
Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x ] commit message follows commit guidelines

Removing unused function arguments, and converting it to ES6 arrow sy…
10c5b0c 
…ntax in test/async-hooks/test-enable-in-init.js
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Dec 12, 2018
@mitchhankins01 mitchhankins01 changed the title Removing unused function arguments, and converting it to ES6 arrow sy… test: removing unused arguments, and conversion ES6 arrow function common.mustCall Dec 12, 2018
@Trott
Copy link
Member

Trott commented Dec 12, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19438/ ✔️

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 12, 2018
@Trott
Copy link
Member

Trott commented Dec 14, 2018

Landed in 848ae89

@Trott Trott closed this Dec 14, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 14, 2018
@Trott
test: refactor test-enable-in-init
848ae89 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: nodejs#24976
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 14, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@BethGriggs
test: refactor test-enable-in-init
d5b0ce1 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: #24976
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
test: refactor test-enable-in-init
47cbb05 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: nodejs#24976
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BethGriggs
test: refactor test-enable-in-init
11d5c07 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: #24976
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@BethGriggs
test: refactor test-enable-in-init
bb067d1 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: #24976
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
test: refactor test-enable-in-init
196b021 
Remove unused function arguments. Convert to ES6 arrow syntax.

PR-URL: #24976
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mitchhankins01 @Trott @danbev @cjihrig @BethGriggs @nodejs-github-bot